Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(32)

Issue 6451002: trytond: Avoid updating/rebuilding mptt tree when parent field hasn't been modified (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 12 months ago by pokoli
Modified:
2 years, 11 months ago
Reviewers:
ced
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 15

Patch Set 2 : Fix ced's comments #

Total comments: 15

Patch Set 3 : Remove mock after test and fix docstring #

Total comments: 9

Patch Set 4 : Remove uneeded line #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -2 lines) Patch
M setup.py View 1 1 chunk +1 line, -0 lines 2 comments Download
M trytond/model/modelsql.py View 1 1 chunk +2 lines, -2 lines 3 comments Download
M trytond/tests/test_mptt.py View 1 2 3 2 chunks +18 lines, -0 lines 2 comments Download

Messages

Total messages: 15
pokoli
2 years, 12 months ago (2014-07-30 15:50:35 UTC) #1
Paranoid Review Bot
http://codereview.tryton.org/6451002/diff/1/setup.py File setup.py (right): http://codereview.tryton.org/6451002/diff/1/setup.py#newcode2 setup.py:2: #This file is part of Tryton. The COPYRIGHT file ...
2 years, 12 months ago (2014-07-30 16:10:49 UTC) #2
ced
http://codereview.tryton.org/6451002/diff/1/setup.py File setup.py (right): http://codereview.tryton.org/6451002/diff/1/setup.py#newcode94 setup.py:94: test_require=['mock'], tests_require http://codereview.tryton.org/6451002/diff/1/trytond/model/modelsql.py File trytond/model/modelsql.py (right): http://codereview.tryton.org/6451002/diff/1/trytond/model/modelsql.py#newcode1160 trytond/model/modelsql.py:1160: def ...
2 years, 12 months ago (2014-07-31 08:14:15 UTC) #3
pokoli
2 years, 12 months ago (2014-07-31 09:21:15 UTC) #4
pokoli
http://codereview.tryton.org/6451002/diff/1/setup.py File setup.py (right): http://codereview.tryton.org/6451002/diff/1/setup.py#newcode94 setup.py:94: test_require=['mock'], On 2014/07/31 08:14:15, ced wrote: > tests_require Done. ...
2 years, 12 months ago (2014-07-31 09:22:23 UTC) #5
Paranoid Review Bot
http://codereview.tryton.org/6451002/diff/20001/setup.py File setup.py (right): http://codereview.tryton.org/6451002/diff/20001/setup.py#newcode2 setup.py:2: #This file is part of Tryton. The COPYRIGHT file ...
2 years, 12 months ago (2014-07-31 10:10:58 UTC) #6
ced
http://codereview.tryton.org/6451002/diff/20001/trytond/tests/test_mptt.py File trytond/tests/test_mptt.py (right): http://codereview.tryton.org/6451002/diff/20001/trytond/tests/test_mptt.py#newcode168 trytond/tests/test_mptt.py:168: '''The left and right fields must only be updated/rebuilded ...
2 years, 12 months ago (2014-07-31 10:41:59 UTC) #7
pokoli
2 years, 12 months ago (2014-07-31 13:30:50 UTC) #8
pokoli
http://codereview.tryton.org/6451002/diff/20001/trytond/tests/test_mptt.py File trytond/tests/test_mptt.py (right): http://codereview.tryton.org/6451002/diff/20001/trytond/tests/test_mptt.py#newcode168 trytond/tests/test_mptt.py:168: '''The left and right fields must only be updated/rebuilded ...
2 years, 12 months ago (2014-07-31 13:31:04 UTC) #9
Paranoid Review Bot
http://codereview.tryton.org/6451002/diff/40001/setup.py File setup.py (right): http://codereview.tryton.org/6451002/diff/40001/setup.py#newcode2 setup.py:2: #This file is part of Tryton. The COPYRIGHT file ...
2 years, 12 months ago (2014-07-31 14:10:44 UTC) #10
ced
http://codereview.tryton.org/6451002/diff/40001/trytond/tests/test_mptt.py File trytond/tests/test_mptt.py (right): http://codereview.tryton.org/6451002/diff/40001/trytond/tests/test_mptt.py#newcode170 trytond/tests/test_mptt.py:170: context=CONTEXT): one line
2 years, 11 months ago (2014-08-04 15:04:44 UTC) #11
pokoli
2 years, 11 months ago (2014-08-04 15:12:29 UTC) #12
pokoli
http://codereview.tryton.org/6451002/diff/40001/trytond/tests/test_mptt.py File trytond/tests/test_mptt.py (right): http://codereview.tryton.org/6451002/diff/40001/trytond/tests/test_mptt.py#newcode170 trytond/tests/test_mptt.py:170: context=CONTEXT): On 2014/08/04 15:04:44, ced wrote: > one line ...
2 years, 11 months ago (2014-08-04 15:13:01 UTC) #13
ced
LGTM
2 years, 11 months ago (2014-08-04 15:21:47 UTC) #14
Paranoid Review Bot
2 years, 11 months ago (2014-08-04 16:10:50 UTC) #15
http://codereview.tryton.org/6451002/diff/60001/setup.py
File setup.py (right):

http://codereview.tryton.org/6451002/diff/60001/setup.py#newcode2
setup.py:2: #This file is part of Tryton.  The COPYRIGHT file at the top level
of
E265 block comment should start with '# '

http://codereview.tryton.org/6451002/diff/60001/setup.py#newcode3
setup.py:3: #this repository contains the full copyright notices and license
terms.
E265 block comment should start with '# '

http://codereview.tryton.org/6451002/diff/60001/trytond/model/modelsql.py
File trytond/model/modelsql.py (right):

http://codereview.tryton.org/6451002/diff/60001/trytond/model/modelsql.py#new...
trytond/model/modelsql.py:1: #This file is part of Tryton.  The COPYRIGHT file
at the top level of
E265 block comment should start with '# '

http://codereview.tryton.org/6451002/diff/60001/trytond/model/modelsql.py#new...
trytond/model/modelsql.py:2: #this repository contains the full copyright
notices and license terms.
E265 block comment should start with '# '

http://codereview.tryton.org/6451002/diff/60001/trytond/model/modelsql.py#new...
trytond/model/modelsql.py:220: or (values[field_name] in create_records))
E127 continuation line over-indented for visual indent

http://codereview.tryton.org/6451002/diff/60001/trytond/tests/test_mptt.py
File trytond/tests/test_mptt.py (right):

http://codereview.tryton.org/6451002/diff/60001/trytond/tests/test_mptt.py#ne...
trytond/tests/test_mptt.py:2: #This file is part of Tryton.  The COPYRIGHT file
at the top level of
E265 block comment should start with '# '

http://codereview.tryton.org/6451002/diff/60001/trytond/tests/test_mptt.py#ne...
trytond/tests/test_mptt.py:3: #this repository contains the full copyright
notices and license terms.
E265 block comment should start with '# '
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842