Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(307)

Issue 44271002: Avoid warning when importing the chart plugin

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 4 days ago by lele
Modified:
1 week, 2 days ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

bug33

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M relatorio/templates/__init__.py View 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 5
lele
1 week, 4 days ago (2017-08-09 11:16:07 UTC) #1
reviewbot
Review's title does not follow the convention: '^([A-Za-z_][\w\.-]+)( [0-9.]+)?:' URL: https://codereview.tryton.org/44271002
1 week, 4 days ago (2017-08-09 11:30:29 UTC) #2
ced
See my comment on https://relatorio.tryton.org/bug33 Also try to write commit message (title) following this advise: ...
1 week, 2 days ago (2017-08-11 08:41:45 UTC) #3
lele
Cédric Krier <cedric.krier@b2ck.com> writes: > See my comment on https://relatorio.tryton.org/bug33 > > Also try to ...
1 week, 2 days ago (2017-08-11 10:22:28 UTC) #4
ced
1 week, 2 days ago (2017-08-11 11:15:47 UTC) #5
On 2017/08/11 10:22:28, lele wrote:
> Cédric Krier <mailto:cedric.krier@b2ck.com> writes:
> 
> > See my comment on https://relatorio.tryton.org/bug33
> >
> > Also try to write commit message (title) following this advise:
> > https://chris.beams.io/posts/git-commit/#imperative
> >
> > https://tryton-rietveld.appspot.com/44271002/
> 
> Yes, that my usual habit: what I missed is that I should treated my rietveld
> submission as a proper "commit", instead as of a plain diff to be reviewed.
> 
> How can I fix that? Just edit the issue on rietveld?

Yes just edit with https://tryton-rietveld.appspot.com/44271002/edit
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842