Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(308)

Issue 43411002: relatorio: Close ZipFile before returning the BytesIO

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week ago by ced
Modified:
1 week ago
Reviewers:
reviewbot
Visibility:
Public.

Description

The ZipFile must be closed to ensure to records are written. bug34

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M relatorio/templates/opendocument.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2
ced
1 week ago (2017-08-13 09:55:27 UTC) #1
reviewbot
1 week ago (2017-08-13 10:05:24 UTC) #2
https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:24:
E402 module level import not at top of file

https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:31:
E402 module level import not at top of file

https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:32:
E402 module level import not at top of file

https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:33:
E402 module level import not at top of file

https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:34:
E402 module level import not at top of file

https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:35:
E402 module level import not at top of file

https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:36:
E402 module level import not at top of file

https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:37:
E402 module level import not at top of file

https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:38:
E402 module level import not at top of file

https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:39:
E402 module level import not at top of file

https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:42:
E402 module level import not at top of file

https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:45:
E402 module level import not at top of file

https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:46:
E402 module level import not at top of file

https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:47:
E402 module level import not at top of file

https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:48:
E402 module level import not at top of file

https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:49:
E402 module level import not at top of file

https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:50:
E402 module level import not at top of file

https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:51:
E402 module level import not at top of file

https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:52:
E402 module level import not at top of file

https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:54:
E402 module level import not at top of file

https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:55:
E402 module level import not at top of file

https://codereview.tryton.org/43411002/diff/1/relatorio/templates/opendocumen...
relatorio/templates/opendocument.py:56:
E402 module level import not at top of file

URL: https://codereview.tryton.org/43411002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842