Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(102)

Issue 42471002: tryton: Add profile_name or login details in title (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 3 weeks ago by kstenger
Modified:
1 month, 3 weeks ago
Reviewers:
pokoli, rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Append to status_bar and use more URL format #

Total comments: 1

Patch Set 3 : Prepend URL to status_bar #

Total comments: 1

Patch Set 4 : Move to set_title() and show depending on login stage #

Total comments: 2

Patch Set 5 : Show information unconditionally #

Total comments: 2

Patch Set 6 : Update to tip and use join #

Patch Set 7 : Add CHANGELOG #

Total comments: 3

Patch Set 8 : No trailing comma nor single closing parenthesis #

Total comments: 1

Patch Set 9 : Add comment #

Patch Set 10 : Add extra space #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M tryton/gui/main.py View 1 2 3 4 5 6 7 8 9 2 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 33
kstenger
2 months, 3 weeks ago (2017-06-25 03:40:16 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/42471002
2 months, 3 weeks ago (2017-06-25 04:01:55 UTC) #2
ced
https://tryton-rietveld.appspot.com/42471002/diff/1/tryton/gui/main.py File tryton/gui/main.py (right): https://tryton-rietveld.appspot.com/42471002/diff/1/tryton/gui/main.py#newcode812 tryton/gui/main.py:812: if title == '': Why not: if not title:
2 months, 3 weeks ago (2017-06-25 08:24:11 UTC) #3
kstenger
Append to status_bar and use more URL format
2 months, 3 weeks ago (2017-06-26 16:31:58 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/42471002
2 months, 3 weeks ago (2017-06-26 17:02:27 UTC) #5
ced
https://tryton-rietveld.appspot.com/42471002/diff/20001/tryton/gui/main.py File tryton/gui/main.py (right): https://tryton-rietveld.appspot.com/42471002/diff/20001/tryton/gui/main.py#newcode821 tryton/gui/main.py:821: self.set_title(prefs.get('status_bar', '') + title) Is it not better to ...
2 months, 3 weeks ago (2017-06-29 08:21:45 UTC) #6
kstenger
Prepend URL to status_bar
2 months, 2 weeks ago (2017-07-02 00:55:06 UTC) #7
reviewbot
flake8 OK URL: https://codereview.tryton.org/42471002
2 months, 2 weeks ago (2017-07-02 01:13:52 UTC) #8
ced
https://tryton-rietveld.appspot.com/42471002/diff/40001/tryton/gui/main.py File tryton/gui/main.py (right): https://tryton-rietveld.appspot.com/42471002/diff/40001/tryton/gui/main.py#newcode819 tryton/gui/main.py:819: ) Will it not be better to include this ...
2 months, 2 weeks ago (2017-07-03 09:34:36 UTC) #9
kstenger
Move to set_title() and show depending on login stage
2 months, 2 weeks ago (2017-07-03 16:00:48 UTC) #10
reviewbot
flake8 OK URL: https://codereview.tryton.org/42471002
2 months, 2 weeks ago (2017-07-03 16:02:01 UTC) #11
ced
https://tryton-rietveld.appspot.com/42471002/diff/60001/tryton/gui/main.py File tryton/gui/main.py (right): https://tryton-rietveld.appspot.com/42471002/diff/60001/tryton/gui/main.py#newcode381 tryton/gui/main.py:381: if show_login: I do not like having a state ...
2 months, 2 weeks ago (2017-07-03 16:50:27 UTC) #12
kstenger
Show information unconditionally
2 months, 1 week ago (2017-07-11 19:22:44 UTC) #13
kstenger
https://tryton-rietveld.appspot.com/42471002/diff/60001/tryton/gui/main.py File tryton/gui/main.py (right): https://tryton-rietveld.appspot.com/42471002/diff/60001/tryton/gui/main.py#newcode381 tryton/gui/main.py:381: if show_login: On 2017/07/03 16:50:27, ced wrote: > I ...
2 months, 1 week ago (2017-07-11 19:22:49 UTC) #14
reviewbot
flake8 OK URL: https://codereview.tryton.org/42471002
2 months, 1 week ago (2017-07-11 19:41:05 UTC) #15
ced
Missing changelog entry https://tryton-rietveld.appspot.com/42471002/diff/80001/tryton/gui/main.py File tryton/gui/main.py (right): https://tryton-rietveld.appspot.com/42471002/diff/80001/tryton/gui/main.py#newcode387 tryton/gui/main.py:387: CONFIG['login.port'], has been removed. https://tryton-rietveld.appspot.com/42471002/diff/80001/tryton/gui/main.py#newcode392 tryton/gui/main.py:392: ...
2 months, 1 week ago (2017-07-12 21:37:54 UTC) #16
kstenger
Update to tip and use join
2 months, 1 week ago (2017-07-12 23:35:55 UTC) #17
reviewbot
flake8 OK URL: https://codereview.tryton.org/42471002
2 months, 1 week ago (2017-07-12 23:37:31 UTC) #18
pokoli
Still missing changelog
2 months ago (2017-07-17 08:23:32 UTC) #19
kstenger
Add CHANGELOG
2 months ago (2017-07-17 15:19:28 UTC) #20
reviewbot
flake8 OK URL: https://codereview.tryton.org/42471002
2 months ago (2017-07-17 15:30:30 UTC) #21
ced
https://tryton-rietveld.appspot.com/42471002/diff/120001/tryton/gui/main.py File tryton/gui/main.py (right): https://tryton-rietveld.appspot.com/42471002/diff/120001/tryton/gui/main.py#newcode387 tryton/gui/main.py:387: ) I do not see the need of such ...
2 months ago (2017-07-17 22:42:19 UTC) #22
kstenger
https://tryton-rietveld.appspot.com/42471002/diff/120001/tryton/gui/main.py File tryton/gui/main.py (right): https://tryton-rietveld.appspot.com/42471002/diff/120001/tryton/gui/main.py#newcode387 tryton/gui/main.py:387: ) On 2017/07/17 22:42:18, ced wrote: > I do ...
2 months ago (2017-07-17 22:48:56 UTC) #23
ced
https://tryton-rietveld.appspot.com/42471002/diff/120001/tryton/gui/main.py File tryton/gui/main.py (right): https://tryton-rietveld.appspot.com/42471002/diff/120001/tryton/gui/main.py#newcode387 tryton/gui/main.py:387: ) On 2017/07/17 22:48:56, kstenger wrote: > On 2017/07/17 ...
2 months ago (2017-07-17 22:54:54 UTC) #24
kstenger
No trailing comma nor single closing parenthesis
2 months ago (2017-07-17 23:01:56 UTC) #25
reviewbot
flake8 OK URL: https://codereview.tryton.org/42471002
2 months ago (2017-07-17 23:11:13 UTC) #26
ced
https://tryton-rietveld.appspot.com/42471002/diff/140001/tryton/gui/main.py File tryton/gui/main.py (right): https://tryton-rietveld.appspot.com/42471002/diff/140001/tryton/gui/main.py#newcode857 tryton/gui/main.py:857: self.set_title() It may require a comment to explain why ...
2 months ago (2017-07-18 07:34:45 UTC) #27
kstenger
Add comment
1 month, 3 weeks ago (2017-07-27 02:56:16 UTC) #28
reviewbot
https://codereview.tryton.org/42471002/diff/160001/tryton/gui/main.py#newcode857 tryton/gui/main.py:857: E261 at least two spaces before inline comment URL: https://codereview.tryton.org/42471002
1 month, 3 weeks ago (2017-07-27 03:00:45 UTC) #29
kstenger
Add extra space
1 month, 3 weeks ago (2017-07-27 17:15:40 UTC) #30
reviewbot
flake8 OK URL: https://codereview.tryton.org/42471002
1 month, 3 weeks ago (2017-07-27 17:38:34 UTC) #31
ced
LGTM
1 month, 3 weeks ago (2017-07-27 20:10:58 UTC) #32
rietveld-bot_tryton.org
1 month, 3 weeks ago (2017-07-29 22:57:03 UTC) #33
New changeset cc11e70789f6 by Karla Stenger in branch 'default':
Add profile_name or login details in title
http://hg.tryton.org/tryton/rev/cc11e70789f6
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842