Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(965)

Issue 41321002: trytond: Move cost price to product level instead of template

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 1 day ago by ced
Modified:
4 days, 18 hours ago
Reviewers:
albert, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -629 lines) Patch
M trytond/modules/account_asset/tests/scenario_account_asset.rst View 2 chunks +1 line, -3 lines 0 comments Download
M trytond/modules/account_dunning_fee/tests/scenario_account_dunning_fee.rst View 1 chunk +0 lines, -1 line 0 comments Download
M trytond/modules/account_invoice/tests/scenario_invoice.rst View 1 chunk +1 line, -5 lines 0 comments Download
M trytond/modules/account_invoice/tests/scenario_invoice_alternate_currency.rst View 1 chunk +1 line, -5 lines 0 comments Download
M trytond/modules/account_invoice/tests/scenario_invoice_supplier.rst View 1 chunk +1 line, -5 lines 0 comments Download
M trytond/modules/account_product/tests/test_account_product.py View 3 chunks +4 lines, -4 lines 0 comments Download
M trytond/modules/account_stock_anglo_saxon/tests/scenario_account_stock_anglo_saxon.rst View 6 chunks +10 lines, -16 lines 0 comments Download
M trytond/modules/account_stock_anglo_saxon/tests/scenario_account_stock_anglo_saxon_with_drop_shipment.rst View 3 chunks +4 lines, -6 lines 0 comments Download
M trytond/modules/account_stock_continental/product.py View 4 chunks +8 lines, -36 lines 0 comments Download
M trytond/modules/account_stock_continental/product.xml View 1 chunk +0 lines, -5 lines 0 comments Download
M trytond/modules/account_stock_continental/tests/scenario_account_stock_continental.rst View 3 chunks +7 lines, -10 lines 0 comments Download
M trytond/modules/account_stock_landed_cost/tests/scenario_account_stock_landed_cost.rst View 1 chunk +7 lines, -10 lines 0 comments Download
M trytond/modules/account_stock_landed_cost/view/template_form.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M trytond/modules/account_stock_landed_cost_weight/tests/scenario_account_stock_landed_cost_weight.rst View 1 chunk +11 lines, -15 lines 0 comments Download
M trytond/modules/analytic_invoice/tests/scenario_analytic_invoice.rst View 1 chunk +1 line, -5 lines 0 comments Download
M trytond/modules/analytic_invoice/tests/scenario_analytic_invoice_asset.rst View 2 chunks +1 line, -5 lines 0 comments Download
M trytond/modules/analytic_purchase/tests/scenario_analytic_purchase.rst View 1 chunk +1 line, -6 lines 0 comments Download
M trytond/modules/analytic_sale/tests/scenario_analytic_sale.rst View 1 chunk +1 line, -6 lines 0 comments Download
M trytond/modules/carrier_percentage/tests/scenario_carrier_percentage_with_purchase_shipment_cost.rst View 1 chunk +6 lines, -7 lines 0 comments Download
M trytond/modules/carrier_percentage/tests/test_carrier_percentage.py View 1 chunk +0 lines, -1 line 0 comments Download
M trytond/modules/carrier_weight/tests/scenario_carrier_weight.rst View 1 chunk +6 lines, -7 lines 0 comments Download
M trytond/modules/carrier_weight/tests/test_carrier_weight.py View 1 chunk +0 lines, -1 line 0 comments Download
M trytond/modules/commission/tests/scenario_commission.rst View 3 chunks +2 lines, -8 lines 0 comments Download
M trytond/modules/commission/tests/test_commission.py View 2 chunks +0 lines, -2 lines 0 comments Download
M trytond/modules/commission_waiting/tests/scenario_commission_waiting.rst View 1 chunk +1 line, -5 lines 0 comments Download
M trytond/modules/customs/tests/test_customs.py View 1 chunk +0 lines, -1 line 0 comments Download
M trytond/modules/product/CHANGELOG View 1 chunk +2 lines, -0 lines 0 comments Download
M trytond/modules/product/configuration.py View 1 chunk +2 lines, -2 lines 0 comments Download
M trytond/modules/product/product.py View 10 chunks +59 lines, -20 lines 1 comment Download
M trytond/modules/product/tests/test_product.py View 6 chunks +0 lines, -6 lines 0 comments Download
M trytond/modules/product/view/product_form.xml View 1 chunk +5 lines, -0 lines 0 comments Download
M trytond/modules/product/view/product_form_simple.xml View 1 chunk +4 lines, -0 lines 0 comments Download
M trytond/modules/product/view/template_form.xml View 1 chunk +0 lines, -2 lines 0 comments Download
M trytond/modules/product_cost_fifo/__init__.py View 1 chunk +0 lines, -1 line 0 comments Download
M trytond/modules/product_cost_fifo/move.py View 1 chunk +1 line, -1 line 0 comments Download
M trytond/modules/product_cost_fifo/product.py View 5 chunks +8 lines, -14 lines 0 comments Download
M trytond/modules/product_cost_fifo/tests/scenario_product_cost_fifo.rst View 5 chunks +9 lines, -10 lines 0 comments Download
M trytond/modules/product_cost_history/product.py View 3 chunks +5 lines, -5 lines 0 comments Download
M trytond/modules/product_cost_history/view/product_cost_history_tree.xml View 1 chunk +1 line, -1 line 0 comments Download
M trytond/modules/product_price_list/tests/test_product_price_list.py View 2 chunks +0 lines, -2 lines 0 comments Download
M trytond/modules/production/tests/scenario_production.rst View 1 chunk +11 lines, -13 lines 0 comments Download
M trytond/modules/production/tests/scenario_production_rounding.rst View 1 chunk +4 lines, -13 lines 0 comments Download
M trytond/modules/production_work/tests/scenario_production_work.rst View 1 chunk +10 lines, -12 lines 0 comments Download
M trytond/modules/project_invoice/tests/scenario_project_invoice_effort.rst View 1 chunk +2 lines, -5 lines 0 comments Download
M trytond/modules/project_invoice/tests/scenario_project_invoice_progress.rst View 1 chunk +2 lines, -5 lines 0 comments Download
M trytond/modules/project_invoice/tests/scenario_project_invoice_timesheet.rst View 1 chunk +2 lines, -5 lines 0 comments Download
M trytond/modules/purchase/tests/scenario_purchase.rst View 2 chunks +9 lines, -11 lines 0 comments Download
M trytond/modules/purchase/tests/test_purchase.py View 1 chunk +3 lines, -2 lines 0 comments Download
M trytond/modules/purchase_invoice_line_standalone/tests/scenario_purchase_invoice_line_standalone.rst View 2 chunks +5 lines, -6 lines 0 comments Download
M trytond/modules/purchase_request/tests/scenario_purchase_request.rst View 1 chunk +4 lines, -5 lines 0 comments Download
M trytond/modules/purchase_requisition/tests/scenario_purchase_requisition.rst View 1 chunk +4 lines, -5 lines 0 comments Download
M trytond/modules/purchase_shipment_cost/tests/scenario_purchase_shipment_cost.rst View 1 chunk +8 lines, -9 lines 0 comments Download
M trytond/modules/purchase_shipment_cost/tests/scenario_purchase_shipment_cost_with_account_stock.rst View 2 chunks +9 lines, -14 lines 0 comments Download
M trytond/modules/purchase_shipment_cost/tests/scenario_purchase_shipment_cost_with_account_stock_anglo_saxon.rst View 2 chunks +9 lines, -10 lines 0 comments Download
M trytond/modules/sale/tests/scenario_sale.rst View 2 chunks +3 lines, -11 lines 0 comments Download
M trytond/modules/sale_advance_payment/tests/scenario_advance_payment.rst View 4 chunks +3 lines, -9 lines 0 comments Download
M trytond/modules/sale_complaint/tests/scenario_sale_complaint.rst View 1 chunk +2 lines, -6 lines 0 comments Download
M trytond/modules/sale_extra/tests/scenario_sale_extra.rst View 3 chunks +4 lines, -9 lines 0 comments Download
M trytond/modules/sale_invoice_grouping/tests/scenario_sale_invoice_grouping.rst View 2 chunks +2 lines, -6 lines 0 comments Download
M trytond/modules/sale_opportunity/tests/scenario_sale_opportunity.rst View 1 chunk +2 lines, -6 lines 0 comments Download
M trytond/modules/sale_price_list/tests/scenario_sale_price_list.rst View 2 chunks +3 lines, -11 lines 0 comments Download
M trytond/modules/sale_promotion/tests/scenario_sale_promotion.rst View 1 chunk +0 lines, -1 line 0 comments Download
M trytond/modules/sale_shipment_cost/tests/scenario_sale_shipment_cost.rst View 3 chunks +4 lines, -9 lines 0 comments Download
M trytond/modules/sale_shipment_grouping/tests/scenario_sale_shipment_grouping.rst View 2 chunks +2 lines, -6 lines 0 comments Download
M trytond/modules/sale_stock_quantity/tests/scenario_sale_stock_quantity.rst View 2 chunks +2 lines, -6 lines 0 comments Download
M trytond/modules/sale_subscription/tests/scenario_sale_subscription.rst View 1 chunk +2 lines, -6 lines 0 comments Download
M trytond/modules/sale_supply/tests/scenario_sale_supply.rst View 4 chunks +4 lines, -9 lines 0 comments Download
M trytond/modules/sale_supply_drop_shipment/tests/scenario_sale_supply_drop_shipment.rst View 2 chunks +2 lines, -5 lines 0 comments Download
M trytond/modules/stock/move.py View 3 chunks +4 lines, -15 lines 0 comments Download
M trytond/modules/stock/product.py View 3 chunks +3 lines, -14 lines 0 comments Download
M trytond/modules/stock/tests/scenario_stock_average_cost_price.rst View 5 chunks +18 lines, -18 lines 0 comments Download
M trytond/modules/stock/tests/scenario_stock_inventory.rst View 2 chunks +7 lines, -4 lines 0 comments Download
M trytond/modules/stock/tests/scenario_stock_reporting.rst View 1 chunk +1 line, -4 lines 0 comments Download
M trytond/modules/stock/tests/scenario_stock_shipment_internal.rst View 1 chunk +1 line, -4 lines 0 comments Download
M trytond/modules/stock/tests/scenario_stock_shipment_out.rst View 1 chunk +1 line, -4 lines 0 comments Download
M trytond/modules/stock/tests/scenario_stock_shipment_out_same_storage_output.rst View 1 chunk +1 line, -4 lines 0 comments Download
M trytond/modules/stock/tests/test_stock.py View 8 chunks +0 lines, -16 lines 0 comments Download
M trytond/modules/stock_forecast/tests/test_stock_forecast.py View 2 chunks +0 lines, -4 lines 0 comments Download
M trytond/modules/stock_lot/tests/scenario_stock_lot_shipment_out.rst View 1 chunk +2 lines, -5 lines 0 comments Download
M trytond/modules/stock_lot/tests/test_stock_lot.py View 2 chunks +0 lines, -4 lines 0 comments Download
M trytond/modules/stock_lot_sled/tests/test_stock_lot_sled.py View 1 chunk +0 lines, -1 line 0 comments Download
M trytond/modules/stock_package/tests/scenario_stock_package.rst View 1 chunk +2 lines, -5 lines 0 comments Download
M trytond/modules/stock_package_shipping_dpd/tests/scenario_shipping_dpd.rst View 3 chunks +3 lines, -11 lines 0 comments Download
M trytond/modules/stock_package_shipping_ups/tests/scenario_shipping_ups.rst View 3 chunks +3 lines, -11 lines 0 comments Download
M trytond/modules/stock_product_location/tests/scenario_stock_product_location.rst View 1 chunk +2 lines, -4 lines 0 comments Download
M trytond/modules/stock_product_location/tests/scenario_stock_product_location_production.rst View 2 chunks +4 lines, -12 lines 0 comments Download
M trytond/modules/stock_shipment_measurements/tests/test_stock_shipment_measurements.py View 2 chunks +0 lines, -4 lines 0 comments Download
M trytond/modules/stock_split/tests/test_stock_split.py View 1 chunk +0 lines, -2 lines 0 comments Download
M trytond/modules/stock_supply/tests/scenario_stock_internal_supply.rst View 1 chunk +2 lines, -5 lines 0 comments Download
M trytond/modules/stock_supply/tests/scenario_stock_internal_supply_lead_time.rst View 1 chunk +2 lines, -5 lines 0 comments Download
M trytond/modules/stock_supply/tests/scenario_stock_internal_supply_overflow.rst View 1 chunk +2 lines, -5 lines 0 comments Download
M trytond/modules/stock_supply/tests/scenario_stock_supply_purchase_request.rst View 1 chunk +2 lines, -5 lines 0 comments Download
M trytond/modules/stock_supply/tests/test_stock_supply.py View 1 chunk +0 lines, -1 line 0 comments Download
M trytond/modules/stock_supply_day/tests/test_stock_supply_day.py View 1 chunk +0 lines, -1 line 0 comments Download
M trytond/modules/stock_supply_production/tests/scenario_stock_supply_production.rst View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 3
ced
1 week, 1 day ago (2017-05-19 10:37:06 UTC) #1
reviewbot
patch is not applicable URL: https://codereview.tryton.org/41321002
1 week, 1 day ago (2017-05-19 10:40:12 UTC) #2
albert
4 days, 18 hours ago (2017-05-23 15:52:16 UTC) #3
https://tryton-rietveld.appspot.com/41321002/diff/1/trytond/modules/product/p...
File trytond/modules/product/product.py (right):

https://tryton-rietveld.appspot.com/41321002/diff/1/trytond/modules/product/p...
trytond/modules/product/product.py:199: cost_price_method =
fields.MultiValue(fields.Selection(
I don't think cost_price_method should be moved to the variant but should be
kept in the template.

I guess it is hard to think of a use case where the user would want to have
different cost price methods for variants of the same template.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842