Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(29)

Issue 41281002: sao: selected_date undefined when creating new record from Calendar View (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by fmorato
Modified:
2 months, 4 weeks ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/view/calendar.js View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 3
fmorato
1 year, 2 months ago (2017-04-20 20:04:36 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/41281002
1 year, 2 months ago (2017-04-20 20:08:52 UTC) #2
ced
1 year, 2 months ago (2017-04-20 20:46:53 UTC) #3
https://tryton-rietveld.appspot.com/41281002/diff/1/src/view/calendar.js
File src/view/calendar.js (right):

https://tryton-rietveld.appspot.com/41281002/diff/1/src/view/calendar.js#newc...
src/view/calendar.js:266: if ((record.model.fields[dtstart].description.type ==
'datetime') && (selected_date !== undefined)) {
For me this is the wrong fix.
selected_date should always be set and for that this.date should be set.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922