Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(307)

Issue 40441002: account: Drop required on party receivable and payable accounts

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by pokoli
Modified:
1 week, 1 day ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Use the default account defined on configuration when the value is not set issue6561

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix ced's comments #

Total comments: 1

Patch Set 3 : Add account_payable_used and account_receivable_used properties #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -43 lines) Patch
M CHANGELOG View 1 chunk +2 lines, -0 lines 0 comments Download
M move.py View 1 2 3 chunks +20 lines, -22 lines 0 comments Download
M party.py View 1 2 5 chunks +21 lines, -21 lines 0 comments Download
M tests/test_account.py View 1 2 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 8
pokoli
1 month, 1 week ago (2017-06-12 11:18:45 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/40441002
1 month, 1 week ago (2017-06-12 11:41:32 UTC) #2
ced
https://tryton-rietveld.appspot.com/40441002/diff/1/party.py File party.py (right): https://tryton-rietveld.appspot.com/40441002/diff/1/party.py#newcode95 party.py:95: if name in ['account_payable', 'account_receivable'] and not value: Better ...
3 weeks, 2 days ago (2017-07-02 20:15:55 UTC) #3
pokoli
Fix ced's comments
3 weeks, 1 day ago (2017-07-03 16:13:10 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/40441002
3 weeks, 1 day ago (2017-07-03 16:38:50 UTC) #5
ced
https://tryton-rietveld.appspot.com/40441002/diff/20001/party.py File party.py (left): https://tryton-rietveld.appspot.com/40441002/diff/20001/party.py#oldcode94 party.py:94: def default_account_payable(cls, **pattern): I think we should keep them ...
3 weeks, 1 day ago (2017-07-03 16:58:32 UTC) #6
pokoli
Add account_payable_used and account_receivable_used properties
1 week, 1 day ago (2017-07-17 11:08:49 UTC) #7
reviewbot
1 week, 1 day ago (2017-07-17 11:41:59 UTC) #8
https://codereview.tryton.org/40441002/diff/40001/move.py#newcode75
move.py:75:
E131 continuation line unaligned for hanging indent

https://codereview.tryton.org/40441002/diff/40001/move.py#newcode909
move.py:909:
E127 continuation line over-indented for visual indent

URL: https://codereview.tryton.org/40441002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842