Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(95)

Issue 40441002: account: Drop required on party receivable and payable accounts

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by pokoli
Modified:
1 week, 4 days ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Use the default account defined on configuration when the value is not set issue6561

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix ced's comments #

Total comments: 1

Patch Set 3 : Add account_payable_used and account_receivable_used properties #

Patch Set 4 : Update to tip #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -21 lines) Patch
M CHANGELOG View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M party.py View 1 2 5 chunks +21 lines, -21 lines 1 comment Download
M tests/test_account.py View 1 2 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 11
pokoli
3 months, 1 week ago (2017-06-12 11:18:45 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/40441002
3 months, 1 week ago (2017-06-12 11:41:32 UTC) #2
ced
https://tryton-rietveld.appspot.com/40441002/diff/1/party.py File party.py (right): https://tryton-rietveld.appspot.com/40441002/diff/1/party.py#newcode95 party.py:95: if name in ['account_payable', 'account_receivable'] and not value: Better ...
2 months, 2 weeks ago (2017-07-02 20:15:55 UTC) #3
pokoli
Fix ced's comments
2 months, 2 weeks ago (2017-07-03 16:13:10 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/40441002
2 months, 2 weeks ago (2017-07-03 16:38:50 UTC) #5
ced
https://tryton-rietveld.appspot.com/40441002/diff/20001/party.py File party.py (left): https://tryton-rietveld.appspot.com/40441002/diff/20001/party.py#oldcode94 party.py:94: def default_account_payable(cls, **pattern): I think we should keep them ...
2 months, 2 weeks ago (2017-07-03 16:58:32 UTC) #6
pokoli
Add account_payable_used and account_receivable_used properties
2 months ago (2017-07-17 11:08:49 UTC) #7
reviewbot
https://codereview.tryton.org/40441002/diff/40001/move.py#newcode75 move.py:75: E131 continuation line unaligned for hanging indent https://codereview.tryton.org/40441002/diff/40001/move.py#newcode909 move.py:909: E127 continuation line over-indented ...
2 months ago (2017-07-17 11:41:59 UTC) #8
pokoli
Update to tip
1 month, 3 weeks ago (2017-07-27 08:45:39 UTC) #9
reviewbot
flake8 OK URL: https://codereview.tryton.org/40441002
1 month, 3 weeks ago (2017-07-27 09:10:06 UTC) #10
ced
1 week, 4 days ago (2017-09-08 17:38:24 UTC) #11
https://tryton-rietveld.appspot.com/40441002/diff/60001/party.py
File party.py (right):

https://tryton-rietveld.appspot.com/40441002/diff/60001/party.py#newcode220
party.py:220: value = config.get_multivalue('default_account_payable')
I think we should raise an error message if it is empty like we do for Product.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842