Issue 40441002: account: Drop required on party receivable and payable accounts

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 40441002: account: Drop required on party receivable and payable accounts

Can't Edit
Can't Publish+Mail
Start Review

Created:
1 month, 1 week ago by pokoli

Modified:
1 week, 1 day ago

Reviewers:
ced, reviewbot

Visibility:
Public.

More Reviews

Description

Use the default account defined on configuration when the value is not set issue6561

Patch Set 2 : Fix ced's comments #

Total comments: 1

Patch Set 3 : Add account_payable_used and account_receivable_used properties #

Created: 1 week, 1 day ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -43 lines)			Patch
M	CHANGELOG	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	move.py	View	1 2	3 chunks	+20 lines, -22 lines	0 comments	Download
M	party.py	View	1 2	5 chunks	+21 lines, -21 lines	0 comments	Download
M	tests/test_account.py	View	1 2	1 chunk	+28 lines, -0 lines	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

ced

https://tryton-rietveld.appspot.com/40441002/diff/1/party.py File party.py (right): https://tryton-rietveld.appspot.com/40441002/diff/1/party.py#newcode95 party.py:95: if name in ['account_payable', 'account_receivable'] and not value: Better ...

3 weeks, 2 days ago (2017-07-02 20:15:55 UTC) #3

ced

https://tryton-rietveld.appspot.com/40441002/diff/20001/party.py File party.py (left): https://tryton-rietveld.appspot.com/40441002/diff/20001/party.py#oldcode94 party.py:94: def default_account_payable(cls, **pattern): I think we should keep them ...

3 weeks, 1 day ago (2017-07-03 16:58:32 UTC) #6

pokoli

Add account_payable_used and account_receivable_used properties

1 week, 1 day ago (2017-07-17 11:08:49 UTC) #7

reviewbot

1 week, 1 day ago (2017-07-17 11:41:59 UTC) #8

https://codereview.tryton.org/40441002/diff/40001/move.py#newcode75
move.py:75:
E131 continuation line unaligned for hanging indent

https://codereview.tryton.org/40441002/diff/40001/move.py#newcode909
move.py:909:
E127 continuation line over-indented for visual indent

URL: https://codereview.tryton.org/40441002

Expand All Messages | Collapse All Messages