account: Drop required on party receivable and payable accounts

Use the default account defined on configuration when the value is not set

issue6561

[reviewbot, 2017-06-12 11:41:32]

flake8 OK
URL: https://codereview.tryton.org/40441002

[ced, 2017-07-02 20:15:55]

https://tryton-rietveld.appspot.com/40441002/diff/1/party.py
File party.py (right):

https://tryton-rietveld.appspot.com/40441002/diff/1/party.py#newcode95
party.py:95: if name in ['account_payable', 'account_receivable'] and not value:
Better to test first value.

https://tryton-rietveld.appspot.com/40441002/diff/1/party.py#newcode95
party.py:95: if name in ['account_payable', 'account_receivable'] and not value:
in test is better and semantically accurate on a set {}

[pokoli, 2017-07-03 16:13:10]

Fix ced's comments

[reviewbot, 2017-07-03 16:38:50]

flake8 OK
URL: https://codereview.tryton.org/40441002

[ced, 2017-07-03 16:58:32]

https://tryton-rietveld.appspot.com/40441002/diff/20001/party.py
File party.py (left):

https://tryton-rietveld.appspot.com/40441002/diff/20001/party.py#oldcode94
party.py:94: def default_account_payable(cls, **pattern):
I think we should keep them see comment on issue.

[pokoli, 2017-07-17 11:08:49]

Add account_payable_used and account_receivable_used properties

[reviewbot, 2017-07-17 11:41:59]

https://codereview.tryton.org/40441002/diff/40001/move.py#newcode75
move.py:75:
E131 continuation line unaligned for hanging indent

https://codereview.tryton.org/40441002/diff/40001/move.py#newcode909
move.py:909:
E127 continuation line over-indented for visual indent

URL: https://codereview.tryton.org/40441002

[pokoli, 2017-07-27 08:45:39]

Update to tip

[reviewbot, 2017-07-27 09:10:06]

flake8 OK
URL: https://codereview.tryton.org/40441002

[ced, 2017-09-08 17:38:24]

https://tryton-rietveld.appspot.com/40441002/diff/60001/party.py
File party.py (right):

https://tryton-rietveld.appspot.com/40441002/diff/60001/party.py#newcode220
party.py:220: value = config.get_multivalue('default_account_payable')
I think we should raise an error message if it is empty like we do for Product.

[pokoli, 2017-09-25 11:13:43]

Add error message and update to tip

[pokoli, 2017-09-25 11:16:15]

Add missing space

[reviewbot, 2017-09-25 11:40:36]

flake8 OK
URL: https://codereview.tryton.org/40441002

[ced, 2017-09-27 17:22:34]

LGTM

https://tryton-rietveld.appspot.com/40441002/diff/100001/party.py
File party.py (right):

https://tryton-rietveld.appspot.com/40441002/diff/100001/party.py#newcode89
party.py:89: 'party "%(name)s".'),
I think you could break at the beginning of the message and have it on one line.
(It is also more PEP8).

[rietveld-bot_tryton.org, 2017-09-28 08:31:39]

New changeset dd3fb646c8c3 by Sergi Almacellas Abellana in branch 'default':
Drop required on party receivable and payable accounts
http://hg.tryton.org/modules/account/rev/dd3fb646c8c3