Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(123)

Issue 40441002: account: Drop required on party receivable and payable accounts (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 2 weeks ago by pokoli
Modified:
1 month, 3 weeks ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Use the default account defined on configuration when the value is not set issue6561

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix ced's comments #

Total comments: 1

Patch Set 3 : Add account_payable_used and account_receivable_used properties #

Patch Set 4 : Update to tip #

Total comments: 1

Patch Set 5 : Add error message and update to tip #

Patch Set 6 : Add missing space #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -21 lines) Patch
M CHANGELOG View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M party.py View 1 2 3 4 5 6 chunks +39 lines, -21 lines 1 comment Download
M tests/test_account.py View 1 2 3 4 1 chunk +28 lines, -0 lines 0 comments Download

Messages

Total messages: 16
pokoli
5 months, 2 weeks ago (2017-06-12 11:18:45 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/40441002
5 months, 2 weeks ago (2017-06-12 11:41:32 UTC) #2
ced
https://tryton-rietveld.appspot.com/40441002/diff/1/party.py File party.py (right): https://tryton-rietveld.appspot.com/40441002/diff/1/party.py#newcode95 party.py:95: if name in ['account_payable', 'account_receivable'] and not value: Better ...
4 months, 3 weeks ago (2017-07-02 20:15:55 UTC) #3
pokoli
Fix ced's comments
4 months, 3 weeks ago (2017-07-03 16:13:10 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/40441002
4 months, 3 weeks ago (2017-07-03 16:38:50 UTC) #5
ced
https://tryton-rietveld.appspot.com/40441002/diff/20001/party.py File party.py (left): https://tryton-rietveld.appspot.com/40441002/diff/20001/party.py#oldcode94 party.py:94: def default_account_payable(cls, **pattern): I think we should keep them ...
4 months, 3 weeks ago (2017-07-03 16:58:32 UTC) #6
pokoli
Add account_payable_used and account_receivable_used properties
4 months, 1 week ago (2017-07-17 11:08:49 UTC) #7
reviewbot
https://codereview.tryton.org/40441002/diff/40001/move.py#newcode75 move.py:75: E131 continuation line unaligned for hanging indent https://codereview.tryton.org/40441002/diff/40001/move.py#newcode909 move.py:909: E127 continuation line over-indented ...
4 months, 1 week ago (2017-07-17 11:41:59 UTC) #8
pokoli
Update to tip
4 months ago (2017-07-27 08:45:39 UTC) #9
reviewbot
flake8 OK URL: https://codereview.tryton.org/40441002
4 months ago (2017-07-27 09:10:06 UTC) #10
ced
https://tryton-rietveld.appspot.com/40441002/diff/60001/party.py File party.py (right): https://tryton-rietveld.appspot.com/40441002/diff/60001/party.py#newcode220 party.py:220: value = config.get_multivalue('default_account_payable') I think we should raise an ...
2 months, 2 weeks ago (2017-09-08 17:38:24 UTC) #11
pokoli
Add error message and update to tip
2 months ago (2017-09-25 11:13:43 UTC) #12
pokoli
Add missing space
2 months ago (2017-09-25 11:16:15 UTC) #13
reviewbot
flake8 OK URL: https://codereview.tryton.org/40441002
2 months ago (2017-09-25 11:40:36 UTC) #14
ced
LGTM https://tryton-rietveld.appspot.com/40441002/diff/100001/party.py File party.py (right): https://tryton-rietveld.appspot.com/40441002/diff/100001/party.py#newcode89 party.py:89: 'party "%(name)s".'), I think you could break at ...
1 month, 4 weeks ago (2017-09-27 17:22:34 UTC) #15
rietveld-bot_tryton.org
1 month, 3 weeks ago (2017-09-28 08:31:39 UTC) #16
New changeset dd3fb646c8c3 by Sergi Almacellas Abellana in branch 'default':
Drop required on party receivable and payable accounts
http://hg.tryton.org/modules/account/rev/dd3fb646c8c3
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922