Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(957)

Issue 40291002: sao: Use fullcalendar date instead of saving it in view

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 4 days ago by xcodinas
Modified:
1 week, 2 days ago
Reviewers:
pokoli, rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Don't store the data value and use getDate #

Total comments: 6

Patch Set 3 : Remove selected_date variable, add get_selected_date #

Total comments: 8

Patch Set 4 : Keep design between clients, add comment for gotodate #

Total comments: 1

Patch Set 5 : Fix not necessary change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M src/screen.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/view/calendar.js View 1 2 3 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 29
xcodinas
3 weeks, 4 days ago (2017-05-02 10:23:42 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/40291002
3 weeks, 4 days ago (2017-05-02 10:36:49 UTC) #2
xcodinas
Don't store the data value and use getDate
3 weeks, 4 days ago (2017-05-02 11:47:55 UTC) #3
pokoli
https://tryton-rietveld.appspot.com/40291002/diff/20001/src/screen.js File src/screen.js (right): https://tryton-rietveld.appspot.com/40291002/diff/20001/src/screen.js#newcode1070 src/screen.js:1070: var selected_date = why you need a variable? https://tryton-rietveld.appspot.com/40291002/diff/20001/src/view/calendar.js ...
3 weeks, 4 days ago (2017-05-02 11:52:29 UTC) #4
xcodinas
On 2017/05/02 11:52:29, pokoli wrote: > https://tryton-rietveld.appspot.com/40291002/diff/20001/src/screen.js > File src/screen.js (right): > > https://tryton-rietveld.appspot.com/40291002/diff/20001/src/screen.js#newcode1070 > ...
3 weeks, 4 days ago (2017-05-02 11:58:54 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/40291002
3 weeks, 4 days ago (2017-05-02 12:01:14 UTC) #6
pokoli
On 2017/05/02 11:58:54, xcodinas wrote: > On 2017/05/02 11:52:29, pokoli wrote: > > https://tryton-rietveld.appspot.com/40291002/diff/20001/src/screen.js > ...
3 weeks, 4 days ago (2017-05-02 12:05:58 UTC) #7
ced
https://tryton-rietveld.appspot.com/40291002/diff/20001/src/screen.js File src/screen.js (right): https://tryton-rietveld.appspot.com/40291002/diff/20001/src/screen.js#newcode1071 src/screen.js:1071: this.current_view.el.fullCalendar('getDate'); I think it is better to not use ...
3 weeks, 4 days ago (2017-05-02 12:54:00 UTC) #8
xcodinas
https://tryton-rietveld.appspot.com/40291002/diff/20001/src/view/calendar.js File src/view/calendar.js (right): https://tryton-rietveld.appspot.com/40291002/diff/20001/src/view/calendar.js#newcode236 src/view/calendar.js:236: this.el.fullCalendar('gotoDate', date); On 2017/05/02 12:53:59, ced wrote: > Why ...
3 weeks, 3 days ago (2017-05-03 11:12:19 UTC) #9
ced
https://tryton-rietveld.appspot.com/40291002/diff/20001/src/view/calendar.js File src/view/calendar.js (right): https://tryton-rietveld.appspot.com/40291002/diff/20001/src/view/calendar.js#newcode236 src/view/calendar.js:236: this.el.fullCalendar('gotoDate', date); On 2017/05/03 11:12:19, xcodinas wrote: > On ...
3 weeks, 3 days ago (2017-05-03 11:14:53 UTC) #10
xcodinas
Remove selected_date variable, add get_selected_date
3 weeks, 3 days ago (2017-05-03 11:15:25 UTC) #11
reviewbot
flake8 OK URL: https://codereview.tryton.org/40291002
3 weeks, 3 days ago (2017-05-03 11:36:16 UTC) #12
ced
https://tryton-rietveld.appspot.com/40291002/diff/40001/src/screen.js File src/screen.js (left): https://tryton-rietveld.appspot.com/40291002/diff/40001/src/screen.js#oldcode1070 src/screen.js:1070: var selected_date = this.current_view.date; Why removing and not keep ...
3 weeks, 3 days ago (2017-05-03 11:40:43 UTC) #13
xcodinas
https://tryton-rietveld.appspot.com/40291002/diff/40001/src/screen.js File src/screen.js (left): https://tryton-rietveld.appspot.com/40291002/diff/40001/src/screen.js#oldcode1070 src/screen.js:1070: var selected_date = this.current_view.date; On 2017/05/03 11:40:43, ced wrote: ...
3 weeks, 2 days ago (2017-05-04 11:34:05 UTC) #14
ced
https://tryton-rietveld.appspot.com/40291002/diff/40001/src/screen.js File src/screen.js (left): https://tryton-rietveld.appspot.com/40291002/diff/40001/src/screen.js#oldcode1070 src/screen.js:1070: var selected_date = this.current_view.date; On 2017/05/04 11:34:05, xcodinas wrote: ...
3 weeks, 2 days ago (2017-05-04 12:30:48 UTC) #15
xcodinas
On 2017/05/04 12:30:48, ced wrote: > https://tryton-rietveld.appspot.com/40291002/diff/40001/src/screen.js > File src/screen.js (left): > > https://tryton-rietveld.appspot.com/40291002/diff/40001/src/screen.js#oldcode1070 > ...
2 weeks, 6 days ago (2017-05-08 07:33:46 UTC) #16
ced
On 2017/05/08 07:33:46, xcodinas wrote: > > Why is get_selected_date does not return the right ...
2 weeks, 6 days ago (2017-05-08 07:56:38 UTC) #17
xcodinas
On 2017/05/08 07:33:46, xcodinas wrote: > On 2017/05/04 12:30:48, ced wrote: > > https://tryton-rietveld.appspot.com/40291002/diff/40001/src/screen.js > ...
2 weeks, 6 days ago (2017-05-08 07:57:21 UTC) #18
xcodinas
https://tryton-rietveld.appspot.com/40291002/diff/40001/src/view/calendar.js File src/view/calendar.js (left): https://tryton-rietveld.appspot.com/40291002/diff/40001/src/view/calendar.js#oldcode269 src/view/calendar.js:269: record.field_set_client(dtstart, selected_date); On 2017/05/04 12:30:48, ced wrote: > On ...
2 weeks, 6 days ago (2017-05-08 08:29:48 UTC) #19
ced
On 2017/05/08 08:29:48, xcodinas wrote: > https://tryton-rietveld.appspot.com/40291002/diff/40001/src/view/calendar.js > File src/view/calendar.js (left): > > https://tryton-rietveld.appspot.com/40291002/diff/40001/src/view/calendar.js#oldcode269 > ...
2 weeks, 6 days ago (2017-05-08 08:56:34 UTC) #20
xcodinas
On 2017/05/08 08:56:34, ced wrote: > On 2017/05/08 08:29:48, xcodinas wrote: > > https://tryton-rietveld.appspot.com/40291002/diff/40001/src/view/calendar.js > ...
2 weeks, 4 days ago (2017-05-10 07:29:13 UTC) #21
ced
On 2017/05/10 07:29:13, xcodinas wrote: > On 2017/05/08 08:56:34, ced wrote: > > On 2017/05/08 ...
2 weeks, 4 days ago (2017-05-10 08:23:10 UTC) #22
xcodinas
Keep design between clients, add comment for gotodate
2 weeks, 3 days ago (2017-05-10 10:41:56 UTC) #23
reviewbot
flake8 OK URL: https://codereview.tryton.org/40291002
2 weeks, 3 days ago (2017-05-10 11:03:17 UTC) #24
ced
https://tryton-rietveld.appspot.com/40291002/diff/60001/src/screen.js File src/screen.js (right): https://tryton-rietveld.appspot.com/40291002/diff/60001/src/screen.js#newcode1097 src/screen.js:1097: previous_view.set_default_date(record, selected_date); Do not see why it is changed.
1 week, 3 days ago (2017-05-18 07:04:36 UTC) #25
xcodinas
Fix not necessary change
1 week, 3 days ago (2017-05-18 09:59:02 UTC) #26
ced
LGTM
1 week, 3 days ago (2017-05-18 10:09:02 UTC) #27
reviewbot
flake8 OK URL: https://codereview.tryton.org/40291002
1 week, 3 days ago (2017-05-18 10:10:43 UTC) #28
rietveld-bot_tryton.org
1 week, 2 days ago (2017-05-19 09:56:47 UTC) #29
New changeset 5ed056a1dace by Xavier Codinas in branch 'default':
Use fullcalendar date instead of saving it in view
http://hg.tryton.org/sao/rev/5ed056a1dace
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842