Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(80)

Issue 39511002: sao: Add readonly and required class on widget (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by ced
Modified:
1 month, 1 week ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/view/form.js View 1 chunk +10 lines, -0 lines 2 comments Download

Messages

Total messages: 5
ced
2 months, 1 week ago (2017-07-14 16:22:22 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/39511002
2 months, 1 week ago (2017-07-14 16:34:52 UTC) #2
pokoli
https://tryton-rietveld-hrd.appspot.com/39511002/diff/1/src/view/form.js File src/view/form.js (right): https://tryton-rietveld-hrd.appspot.com/39511002/diff/1/src/view/form.js#newcode933 src/view/form.js:933: if (!readonly && required) { why not adding both ...
2 months ago (2017-07-17 08:00:25 UTC) #3
ced
https://tryton-rietveld-hrd.appspot.com/39511002/diff/1/src/view/form.js File src/view/form.js (right): https://tryton-rietveld-hrd.appspot.com/39511002/diff/1/src/view/form.js#newcode933 src/view/form.js:933: if (!readonly && required) { On 2017/07/17 08:00:25, pokoli ...
2 months ago (2017-07-17 08:19:08 UTC) #4
rietveld-bot_tryton.org
1 month, 1 week ago (2017-08-07 17:58:51 UTC) #5
New changeset 88e184a3cf06 by Cédric Krier in branch 'default':
Add readonly and required class on widget
http://hg.tryton.org/sao/rev/88e184a3cf06
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842