Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(293)

Issue 39511002: sao: Add readonly and required class on widget

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 4 days ago by ced
Modified:
1 week, 1 day ago
Reviewers:
pokoli, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/view/form.js View 1 chunk +10 lines, -0 lines 2 comments Download

Messages

Total messages: 4
ced
1 week, 4 days ago (2017-07-14 16:22:22 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/39511002
1 week, 4 days ago (2017-07-14 16:34:52 UTC) #2
pokoli
https://tryton-rietveld-hrd.appspot.com/39511002/diff/1/src/view/form.js File src/view/form.js (right): https://tryton-rietveld-hrd.appspot.com/39511002/diff/1/src/view/form.js#newcode933 src/view/form.js:933: if (!readonly && required) { why not adding both ...
1 week, 1 day ago (2017-07-17 08:00:25 UTC) #3
ced
1 week, 1 day ago (2017-07-17 08:19:08 UTC) #4
https://tryton-rietveld-hrd.appspot.com/39511002/diff/1/src/view/form.js
File src/view/form.js (right):

https://tryton-rietveld-hrd.appspot.com/39511002/diff/1/src/view/form.js#newc...
src/view/form.js:933: if (!readonly && required) {
On 2017/07/17 08:00:25, pokoli wrote:
> why not adding both classes? 

Because readonly field are not required by the client.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842