Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(134)

Issue 38321003: stock_consignment: Initial commit (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 2 weeks ago by ced
Modified:
5 months ago
Reviewers:
prakashpp.pandey, rietveld-bot, perilla, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove wrong dependency #

Patch Set 3 : Add support shipment out and return #

Total comments: 2

Patch Set 4 : Set origin at Move level to fix the assignation issue #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1635 lines, -0 lines) Patch
A .drone.yml View 1 chunk +9 lines, -0 lines 0 comments Download
A COPYRIGHT View 1 chunk +15 lines, -0 lines 0 comments Download
A INSTALL View 1 chunk +35 lines, -0 lines 0 comments Download
A LICENSE View 1 chunk +674 lines, -0 lines 0 comments Download
A MANIFEST.in View 1 chunk +13 lines, -0 lines 0 comments Download
A README View 1 chunk +35 lines, -0 lines 0 comments Download
A __init__.py View 3 1 chunk +21 lines, -0 lines 0 comments Download
A account.py View 1 chunk +24 lines, -0 lines 0 comments Download
A doc/index.rst View 1 chunk +26 lines, -0 lines 0 comments Download
A setup.py View 1 chunk +127 lines, -0 lines 0 comments Download
A stock.py View 1 2 3 1 chunk +297 lines, -0 lines 0 comments Download
A stock.xml View 1 chunk +12 lines, -0 lines 0 comments Download
A tests/__init__.py View 1 chunk +9 lines, -0 lines 0 comments Download
A tests/scenario_stock_consignment.rst View 1 2 1 chunk +268 lines, -0 lines 0 comments Download
A tests/test_stock_consignment.py View 1 chunk +28 lines, -0 lines 0 comments Download
A tox.ini View 1 chunk +18 lines, -0 lines 0 comments Download
A tryton.cfg View 1 chunk +14 lines, -0 lines 0 comments Download
A view/location_form.xml View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 14
ced
7 months, 2 weeks ago (2017-04-11 20:57:03 UTC) #1
reviewbot
https://codereview.tryton.org/38321003/diff/1/setup.py#newcode89 setup.py:89: E501 line too long (85 > 79 characters) https://codereview.tryton.org/38321003/diff/1/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
7 months, 2 weeks ago (2017-04-11 21:02:30 UTC) #2
perilla
https://tryton-rietveld.appspot.com/38321003/diff/1/stock.py File stock.py (right): https://tryton-rietveld.appspot.com/38321003/diff/1/stock.py#newcode24 stock.py:24: depends=['type', 'warehouse'], why depends on warehouse?
7 months, 2 weeks ago (2017-04-12 13:15:13 UTC) #3
ced
https://tryton-rietveld.appspot.com/38321003/diff/1/stock.py File stock.py (right): https://tryton-rietveld.appspot.com/38321003/diff/1/stock.py#newcode24 stock.py:24: depends=['type', 'warehouse'], On 2017/04/12 13:15:12, perilla wrote: > why ...
7 months, 2 weeks ago (2017-04-12 13:32:35 UTC) #4
ced
Remove wrong dependency
7 months, 2 weeks ago (2017-04-12 13:32:35 UTC) #5
reviewbot
https://codereview.tryton.org/38321003/diff/20001/setup.py#newcode89 setup.py:89: E501 line too long (85 > 79 characters) https://codereview.tryton.org/38321003/diff/20001/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
7 months, 2 weeks ago (2017-04-12 13:58:19 UTC) #6
ced
Add support shipment out and return
6 months, 3 weeks ago (2017-05-03 14:27:21 UTC) #7
reviewbot
https://codereview.tryton.org/38321003/diff/40001/setup.py#newcode89 setup.py:89: E501 line too long (85 > 79 characters) https://codereview.tryton.org/38321003/diff/40001/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
6 months, 3 weeks ago (2017-05-03 14:31:41 UTC) #8
prakashpp.pandey
https://tryton-rietveld.appspot.com/38321003/diff/40001/stock.py File stock.py (right): https://tryton-rietveld.appspot.com/38321003/diff/40001/stock.py#newcode298 stock.py:298: cls._set_origin_consignment(shipments, 'inventory_moves') This fails in following scenario: When inventory ...
6 months, 1 week ago (2017-05-19 14:32:49 UTC) #9
ced
Set origin at Move level to fix the assignation issue
6 months ago (2017-05-22 15:49:13 UTC) #10
ced
https://tryton-rietveld.appspot.com/38321003/diff/40001/stock.py File stock.py (right): https://tryton-rietveld.appspot.com/38321003/diff/40001/stock.py#newcode298 stock.py:298: cls._set_origin_consignment(shipments, 'inventory_moves') On 2017/05/19 14:32:48, prakashpp.pandey wrote: > This ...
6 months ago (2017-05-22 15:49:15 UTC) #11
reviewbot
https://codereview.tryton.org/38321003/diff/60001/setup.py#newcode89 setup.py:89: E501 line too long (85 > 79 characters) https://codereview.tryton.org/38321003/diff/60001/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
6 months ago (2017-05-22 16:09:49 UTC) #12
prakashpp.pandey
LGTM
6 months ago (2017-05-22 16:57:02 UTC) #13
rietveld-bot_tryton.org
5 months ago (2017-06-24 08:40:55 UTC) #14
New changeset 8328d2bea1e4 by Cédric Krier in branch 'default':
Initial commit
http://hg.tryton.org/modules/stock_consignment/rev/8328d2bea1e4
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922