Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(359)

Issue 38301002: analytic_account: Set missing _parent_move_line.account depends

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 3 days ago by pokoli
Modified:
5 days, 3 hours ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Catch AttributeError and prevent crash when account is not set #

Total comments: 8

Patch Set 3 : Set missing depends for account #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M line.py View 1 2 1 chunk +4 lines, -4 lines 4 comments Download

Messages

Total messages: 18
pokoli
2 weeks, 3 days ago (2017-04-07 09:20:08 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/38301002
2 weeks, 3 days ago (2017-04-07 09:28:17 UTC) #2
ced
https://tryton-rietveld.appspot.com/38301002/diff/1/line.py File line.py (right): https://tryton-rietveld.appspot.com/38301002/diff/1/line.py#newcode107 line.py:107: None) I do not think it is good to ...
5 days, 9 hours ago (2017-04-19 09:00:32 UTC) #3
pokoli
Catch AttributeError and prevent crash when account is not set
5 days, 9 hours ago (2017-04-19 09:14:32 UTC) #4
pokoli
https://tryton-rietveld.appspot.com/38301002/diff/1/line.py File line.py (right): https://tryton-rietveld.appspot.com/38301002/diff/1/line.py#newcode107 line.py:107: None) On 2017/04/19 09:00:32, ced wrote: > I do ...
5 days, 9 hours ago (2017-04-19 09:14:46 UTC) #5
reviewbot
flake8 OK URL: https://codereview.tryton.org/38301002
5 days, 9 hours ago (2017-04-19 09:35:35 UTC) #6
ced
https://tryton-rietveld.appspot.com/38301002/diff/20001/line.py File line.py (right): https://tryton-rietveld.appspot.com/38301002/diff/20001/line.py#newcode87 line.py:87: @fields.depends('move_line') I think it should also depends on _parent_move_line.account ...
5 days, 9 hours ago (2017-04-19 09:43:45 UTC) #7
pokoli
https://tryton-rietveld.appspot.com/38301002/diff/20001/line.py File line.py (right): https://tryton-rietveld.appspot.com/38301002/diff/20001/line.py#newcode87 line.py:87: @fields.depends('move_line') On 2017/04/19 09:43:45, ced wrote: > I think ...
5 days, 8 hours ago (2017-04-19 10:41:49 UTC) #8
ced
https://tryton-rietveld.appspot.com/38301002/diff/20001/line.py File line.py (right): https://tryton-rietveld.appspot.com/38301002/diff/20001/line.py#newcode107 line.py:107: self.date = self.move_line.date On 2017/04/19 10:41:49, pokoli wrote: > ...
5 days, 7 hours ago (2017-04-19 11:03:45 UTC) #9
pokoli
https://tryton-rietveld.appspot.com/38301002/diff/20001/line.py File line.py (right): https://tryton-rietveld.appspot.com/38301002/diff/20001/line.py#newcode107 line.py:107: self.date = self.move_line.date On 2017/04/19 11:03:45, ced wrote: > ...
5 days, 7 hours ago (2017-04-19 11:55:43 UTC) #10
ced
https://tryton-rietveld.appspot.com/38301002/diff/20001/line.py File line.py (right): https://tryton-rietveld.appspot.com/38301002/diff/20001/line.py#newcode107 line.py:107: self.date = self.move_line.date On 2017/04/19 11:55:42, pokoli wrote: > ...
5 days, 6 hours ago (2017-04-19 12:08:00 UTC) #11
pokoli
Set missing depends for account
5 days, 6 hours ago (2017-04-19 12:29:19 UTC) #12
pokoli
https://tryton-rietveld.appspot.com/38301002/diff/20001/line.py File line.py (right): https://tryton-rietveld.appspot.com/38301002/diff/20001/line.py#newcode107 line.py:107: self.date = self.move_line.date On 2017/04/19 12:08:00, ced wrote: > ...
5 days, 6 hours ago (2017-04-19 12:31:13 UTC) #13
reviewbot
flake8 OK URL: https://codereview.tryton.org/38301002
5 days, 6 hours ago (2017-04-19 12:32:35 UTC) #14
ced
https://tryton-rietveld.appspot.com/38301002/diff/40001/line.py File line.py (right): https://tryton-rietveld.appspot.com/38301002/diff/40001/line.py#newcode106 line.py:106: self.date = self.move_line.date I think it is good to ...
5 days, 6 hours ago (2017-04-19 12:58:43 UTC) #15
pokoli
https://tryton-rietveld.appspot.com/38301002/diff/40001/line.py File line.py (right): https://tryton-rietveld.appspot.com/38301002/diff/40001/line.py#newcode106 line.py:106: self.date = self.move_line.date On 2017/04/19 12:58:43, ced wrote: > ...
5 days, 5 hours ago (2017-04-19 13:16:50 UTC) #16
ced
https://tryton-rietveld.appspot.com/38301002/diff/40001/line.py File line.py (right): https://tryton-rietveld.appspot.com/38301002/diff/40001/line.py#newcode106 line.py:106: self.date = self.move_line.date On 2017/04/19 13:16:50, pokoli wrote: > ...
5 days, 5 hours ago (2017-04-19 13:39:43 UTC) #17
pokoli
5 days, 3 hours ago (2017-04-19 15:53:23 UTC) #18
https://tryton-rietveld.appspot.com/38301002/diff/40001/line.py
File line.py (right):

https://tryton-rietveld.appspot.com/38301002/diff/40001/line.py#newcode106
line.py:106: self.date = self.move_line.date
On 2017/04/19 13:39:43, ced wrote:
> On 2017/04/19 13:16:50, pokoli wrote:
> > May I create a patch for the released version which includes the catch?
> 
> OK for 4.2 branch.

Done on: https://tryton-rietveld.appspot.com/36341002/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842