Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(114)

Issue 37551002: sao: Add login details in title (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by kstenger
Modified:
1 month, 3 weeks ago
Reviewers:
pokoli, rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 8

Patch Set 2 : Add Sao.set_title() #

Patch Set 3 : Add CHANGELOG #

Total comments: 9

Patch Set 4 : set_title on logout at the very end, so no call on login #

Total comments: 3

Patch Set 5 : Use brackets for new array #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -6 lines) Patch
M CHANGELOG View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/sao.js View 1 2 3 4 3 chunks +23 lines, -6 lines 0 comments Download

Messages

Total messages: 26
kstenger
2 months, 1 week ago (2017-07-11 21:42:24 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/37551002
2 months, 1 week ago (2017-07-11 22:11:41 UTC) #2
pokoli
https://tryton-rietveld-hrd.appspot.com/37551002/diff/1/src/session.js File src/session.js (right): https://tryton-rietveld-hrd.appspot.com/37551002/diff/1/src/session.js#newcode35 src/session.js:35: title += ' - ' + Sao.Session.current_session.login; this should ...
2 months, 1 week ago (2017-07-12 07:59:21 UTC) #3
kstenger
https://tryton-rietveld-hrd.appspot.com/37551002/diff/1/src/session.js File src/session.js (right): https://tryton-rietveld-hrd.appspot.com/37551002/diff/1/src/session.js#newcode35 src/session.js:35: title += ' - ' + Sao.Session.current_session.login; On 2017/07/12 ...
2 months, 1 week ago (2017-07-12 15:42:34 UTC) #4
ced
https://tryton-rietveld.appspot.com/37551002/diff/1/src/session.js File src/session.js (right): https://tryton-rietveld.appspot.com/37551002/diff/1/src/session.js#newcode35 src/session.js:35: title += ' - ' + Sao.Session.current_session.login; Maybe we ...
2 months, 1 week ago (2017-07-12 22:11:03 UTC) #5
kstenger
Add Sao.set_title()
2 months, 1 week ago (2017-07-13 15:00:19 UTC) #6
kstenger
https://tryton-rietveld.appspot.com/37551002/diff/1/src/session.js File src/session.js (right): https://tryton-rietveld.appspot.com/37551002/diff/1/src/session.js#newcode35 src/session.js:35: title += ' - ' + Sao.Session.current_session.login; On 2017/07/12 ...
2 months, 1 week ago (2017-07-13 15:00:22 UTC) #7
reviewbot
flake8 OK URL: https://codereview.tryton.org/37551002
2 months, 1 week ago (2017-07-13 15:07:20 UTC) #8
pokoli
Missing changelog
2 months ago (2017-07-17 08:23:43 UTC) #9
kstenger
Add CHANGELOG
2 months ago (2017-07-17 15:19:07 UTC) #10
reviewbot
flake8 OK URL: https://codereview.tryton.org/37551002
2 months ago (2017-07-17 15:30:16 UTC) #11
ced
https://tryton-rietveld.appspot.com/37551002/diff/40001/src/sao.js File src/sao.js (right): https://tryton-rietveld.appspot.com/37551002/diff/40001/src/sao.js#newcode240 src/sao.js:240: Sao.set_title(preferences.status_bar); I think it should always be called. https://tryton-rietveld.appspot.com/37551002/diff/40001/src/sao.js#newcode296 ...
2 months ago (2017-07-17 22:39:33 UTC) #12
kstenger
https://tryton-rietveld.appspot.com/37551002/diff/40001/src/session.js File src/session.js (right): https://tryton-rietveld.appspot.com/37551002/diff/40001/src/session.js#newcode34 src/session.js:34: Sao.set_title(''); On 2017/07/17 22:39:33, ced wrote: > I do ...
2 months ago (2017-07-17 23:20:47 UTC) #13
pokoli
https://tryton-rietveld.appspot.com/37551002/diff/40001/src/session.js File src/session.js (right): https://tryton-rietveld.appspot.com/37551002/diff/40001/src/session.js#newcode34 src/session.js:34: Sao.set_title(''); On 2017/07/17 23:20:47, kstenger wrote: > On 2017/07/17 ...
2 months ago (2017-07-18 07:28:52 UTC) #14
ced
https://tryton-rietveld.appspot.com/37551002/diff/40001/src/sao.js File src/sao.js (right): https://tryton-rietveld.appspot.com/37551002/diff/40001/src/sao.js#newcode278 src/sao.js:278: Sao.set_title(''); May need a comment to explain why it ...
2 months ago (2017-07-18 07:36:16 UTC) #15
kstenger
set_title on logout at the very end, so no call on login
1 month, 3 weeks ago (2017-07-27 03:35:06 UTC) #16
kstenger
https://tryton-rietveld.appspot.com/37551002/diff/40001/src/sao.js File src/sao.js (right): https://tryton-rietveld.appspot.com/37551002/diff/40001/src/sao.js#newcode278 src/sao.js:278: Sao.set_title(''); On 2017/07/18 07:36:16, ced wrote: > May need ...
1 month, 3 weeks ago (2017-07-27 03:35:35 UTC) #17
reviewbot
flake8 OK URL: https://codereview.tryton.org/37551002
1 month, 3 weeks ago (2017-07-27 04:09:05 UTC) #18
pokoli
https://tryton-rietveld.appspot.com/37551002/diff/40001/src/sao.js File src/sao.js (right): https://tryton-rietveld.appspot.com/37551002/diff/40001/src/sao.js#newcode278 src/sao.js:278: Sao.set_title(''); On 2017/07/27 03:35:35, kstenger wrote: > On 2017/07/18 ...
1 month, 3 weeks ago (2017-07-27 09:54:38 UTC) #19
ced
https://tryton-rietveld.appspot.com/37551002/diff/60001/src/sao.js File src/sao.js (right): https://tryton-rietveld.appspot.com/37551002/diff/60001/src/sao.js#newcode255 src/sao.js:255: var title = new Array(Sao.config.title); Why not just: [Sao.config.title] ...
1 month, 3 weeks ago (2017-07-27 20:13:11 UTC) #20
kstenger
https://tryton-rietveld.appspot.com/37551002/diff/60001/src/sao.js File src/sao.js (right): https://tryton-rietveld.appspot.com/37551002/diff/60001/src/sao.js#newcode255 src/sao.js:255: var title = new Array(Sao.config.title); On 2017/07/27 20:13:11, ced ...
1 month, 3 weeks ago (2017-07-27 21:12:34 UTC) #21
ced
https://tryton-rietveld.appspot.com/37551002/diff/60001/src/sao.js File src/sao.js (right): https://tryton-rietveld.appspot.com/37551002/diff/60001/src/sao.js#newcode255 src/sao.js:255: var title = new Array(Sao.config.title); On 2017/07/27 21:12:34, kstenger ...
1 month, 3 weeks ago (2017-07-27 22:14:49 UTC) #22
kstenger
Use brackets for new array
1 month, 3 weeks ago (2017-07-27 22:51:40 UTC) #23
reviewbot
flake8 OK URL: https://codereview.tryton.org/37551002
1 month, 3 weeks ago (2017-07-27 23:01:11 UTC) #24
ced
LGTM
1 month, 3 weeks ago (2017-07-28 06:53:00 UTC) #25
rietveld-bot_tryton.org
1 month, 3 weeks ago (2017-07-29 22:54:18 UTC) #26
New changeset 66ff54b56b96 by Karla Stenger in branch 'default':
Add login details in title
http://hg.tryton.org/sao/rev/66ff54b56b96
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842