Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(338)

Issue 37391002: commission: Don't match product and category lines when product is empty (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by pokoli
Modified:
2 months ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add function to create products #

Total comments: 4

Patch Set 3 : Fix ced comments #

Patch Set 4 : Add CHANGELOG #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -37 lines) Patch
M CHANGELOG View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M commission.py View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/test_commission.py View 1 2 2 chunks +75 lines, -37 lines 0 comments Download

Messages

Total messages: 13
pokoli
2 months, 2 weeks ago (2017-05-11 08:02:22 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/37391002
2 months, 2 weeks ago (2017-05-11 08:08:44 UTC) #2
ced
https://tryton-rietveld.appspot.com/37391002/diff/1/tests/test_commission.py File tests/test_commission.py (right): https://tryton-rietveld.appspot.com/37391002/diff/1/tests/test_commission.py#newcode98 tests/test_commission.py:98: commission_template = Template( I think many code could be ...
2 months, 1 week ago (2017-05-16 13:46:25 UTC) #3
pokoli
Add function to create products
2 months, 1 week ago (2017-05-18 12:58:52 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/37391002
2 months, 1 week ago (2017-05-18 13:01:23 UTC) #5
ced
https://tryton-rietveld.appspot.com/37391002/diff/20001/tests/test_commission.py File tests/test_commission.py (right): https://tryton-rietveld.appspot.com/37391002/diff/20001/tests/test_commission.py#newcode22 tests/test_commission.py:22: def create_product(self, name): I do not see the point ...
2 months, 1 week ago (2017-05-18 20:52:19 UTC) #6
pokoli
Fix ced comments
2 months ago (2017-05-22 11:15:33 UTC) #7
reviewbot
flake8 OK URL: https://codereview.tryton.org/37391002
2 months ago (2017-05-22 11:41:47 UTC) #8
ced
We need a changelog entry as it is a change in the behaviour.
2 months ago (2017-05-22 12:40:36 UTC) #9
pokoli
Add CHANGELOG
2 months ago (2017-05-22 12:57:48 UTC) #10
reviewbot
flake8 OK URL: https://codereview.tryton.org/37391002
2 months ago (2017-05-22 13:06:43 UTC) #11
ced
LGTM
2 months ago (2017-05-22 13:47:28 UTC) #12
rietveld-bot_tryton.org
2 months ago (2017-05-23 08:28:52 UTC) #13
New changeset e4714019ca52 by Sergi Almacellas Abellana in branch 'default':
Don't match product and category lines when product is empty
http://hg.tryton.org/modules/commission/rev/e4714019ca52
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842