Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(82)

Issue 35141002: tryton: Make readonly, required and invalid widget themable (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by ced
Modified:
1 month, 1 week ago
Reviewers:
timitos3000, rietveld-bot, nicoe, reviewbot
Visibility:
Public.

Description

- add classes to the widget - provide a minimal application style - allow to load a user theme - add the profile name to the main window issue6643

Patch Set 1 #

Patch Set 2 : Add changelog #

Total comments: 2

Patch Set 3 : Use variable and add documentation #

Patch Set 4 : Add class to label #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -15 lines) Patch
M CHANGELOG View 1 1 chunk +3 lines, -0 lines 0 comments Download
M doc/usage.rst View 1 2 3 2 chunks +21 lines, -0 lines 0 comments Download
M tryton/client.py View 1 2 2 chunks +28 lines, -0 lines 2 comments Download
M tryton/common/widget_style.py View 1 chunk +10 lines, -1 line 0 comments Download
M tryton/gui/main.py View 1 chunk +11 lines, -0 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/many2many.py View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/one2many.py View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/state_widget.py View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/widget.py View 2 chunks +12 lines, -6 lines 0 comments Download
M tryton/gui/window/view_form/view/list.py View 1 2 3 3 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 15
ced
2 months, 1 week ago (2017-07-14 16:18:19 UTC) #1
ced
Add changelog
2 months, 1 week ago (2017-07-14 16:19:17 UTC) #2
reviewbot
https://codereview.tryton.org/35141002/diff/20001/tryton/client.py#newcode186 tryton/client.py:186: F401 'goocalendar' imported but unused URL: https://codereview.tryton.org/35141002
2 months, 1 week ago (2017-07-14 16:34:49 UTC) #3
nicoe
https://tryton-rietveld.appspot.com/35141002/diff/20001/tryton/client.py File tryton/client.py (right): https://tryton-rietveld.appspot.com/35141002/diff/20001/tryton/client.py#newcode222 tryton/client.py:222: provider.load_from_data(""" I would put this CSS in a file ...
2 months, 1 week ago (2017-07-14 16:36:13 UTC) #4
ced
https://tryton-rietveld.appspot.com/35141002/diff/20001/tryton/client.py File tryton/client.py (right): https://tryton-rietveld.appspot.com/35141002/diff/20001/tryton/client.py#newcode222 tryton/client.py:222: provider.load_from_data(""" On 2017/07/14 16:36:13, nicoe wrote: > I would ...
2 months ago (2017-07-14 21:55:36 UTC) #5
ced
Use variable and add documentation
2 months ago (2017-07-14 22:03:27 UTC) #6
reviewbot
https://codereview.tryton.org/35141002/diff/40001/tryton/client.py#newcode186 tryton/client.py:186: F401 'goocalendar' imported but unused URL: https://codereview.tryton.org/35141002
2 months ago (2017-07-14 22:05:06 UTC) #7
ced
Add class to label
2 months ago (2017-07-16 11:17:15 UTC) #8
reviewbot
https://codereview.tryton.org/35141002/diff/60001/tryton/client.py#newcode186 tryton/client.py:186: F401 'goocalendar' imported but unused URL: https://codereview.tryton.org/35141002
2 months ago (2017-07-16 11:38:11 UTC) #9
timitos3000
https://tryton-rietveld.appspot.com/35141002/diff/60001/tryton/client.py File tryton/client.py (right): https://tryton-rietveld.appspot.com/35141002/diff/60001/tryton/client.py#newcode227 tryton/client.py:227: } Would it be a good idea to put ...
2 months ago (2017-07-17 11:45:20 UTC) #10
ced
https://tryton-rietveld.appspot.com/35141002/diff/60001/tryton/client.py File tryton/client.py (right): https://tryton-rietveld.appspot.com/35141002/diff/60001/tryton/client.py#newcode227 tryton/client.py:227: } On 2017/07/17 11:45:20, timitos3000 wrote: > Would it ...
2 months ago (2017-07-17 12:52:32 UTC) #11
timitos3000
On 2017/07/17 12:52:32, ced wrote: > https://tryton-rietveld.appspot.com/35141002/diff/60001/tryton/client.py > File tryton/client.py (right): > > https://tryton-rietveld.appspot.com/35141002/diff/60001/tryton/client.py#newcode227 > ...
2 months ago (2017-07-17 13:03:32 UTC) #12
ced
On 2017/07/17 13:03:32, timitos3000 wrote: > On 2017/07/17 12:52:32, ced wrote: > > https://tryton-rietveld.appspot.com/35141002/diff/60001/tryton/client.py > ...
2 months ago (2017-07-17 13:17:48 UTC) #13
timitos3000
LGTM
2 months ago (2017-07-21 10:47:18 UTC) #14
rietveld-bot_tryton.org
1 month, 1 week ago (2017-08-07 17:58:03 UTC) #15
New changeset bccb03e973db by Cédric Krier in branch 'default':
Make readonly, required and invalid widget themable
http://hg.tryton.org/tryton/rev/bccb03e973db
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842