Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(301)

Issue 35121002: sale: Ensure empty sale goes to done state

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 5 days ago by ced
Modified:
1 week, 1 day ago
Reviewers:
pokoli, reviewbot
Visibility:
Public.

Description

As there is not transition from confirmed to done, the sale must first be processed. issue6639

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -1 line) Patch
M sale.py View 2 chunks +4 lines, -1 line 0 comments Download
M setup.py View 1 chunk +1 line, -0 lines 0 comments Download
A tests/scenario_sale_empty.rst View 1 chunk +62 lines, -0 lines 4 comments Download
M tests/test_sale.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7
ced
1 week, 5 days ago (2017-07-13 09:07:49 UTC) #1
reviewbot
https://codereview.tryton.org/35121002/diff/1/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/35121002
1 week, 5 days ago (2017-07-13 09:33:20 UTC) #2
pokoli
https://tryton-rietveld-hrd.appspot.com/35121002/diff/1/tests/scenario_sale_empty.rst File tests/scenario_sale_empty.rst (right): https://tryton-rietveld-hrd.appspot.com/35121002/diff/1/tests/scenario_sale_empty.rst#newcode48 tests/scenario_sale_empty.rst:48: >>> sale.state Why is required to test state here?
1 week, 4 days ago (2017-07-14 10:52:20 UTC) #3
ced
https://tryton-rietveld-hrd.appspot.com/35121002/diff/1/tests/scenario_sale_empty.rst File tests/scenario_sale_empty.rst (right): https://tryton-rietveld-hrd.appspot.com/35121002/diff/1/tests/scenario_sale_empty.rst#newcode48 tests/scenario_sale_empty.rst:48: >>> sale.state On 2017/07/14 10:52:20, pokoli wrote: > Why ...
1 week, 4 days ago (2017-07-14 10:59:03 UTC) #4
pokoli
https://tryton-rietveld-hrd.appspot.com/35121002/diff/1/tests/scenario_sale_empty.rst File tests/scenario_sale_empty.rst (right): https://tryton-rietveld-hrd.appspot.com/35121002/diff/1/tests/scenario_sale_empty.rst#newcode48 tests/scenario_sale_empty.rst:48: >>> sale.state On 2017/07/14 10:59:03, ced wrote: > On ...
1 week, 4 days ago (2017-07-14 12:37:13 UTC) #5
ced
https://tryton-rietveld-hrd.appspot.com/35121002/diff/1/tests/scenario_sale_empty.rst File tests/scenario_sale_empty.rst (right): https://tryton-rietveld-hrd.appspot.com/35121002/diff/1/tests/scenario_sale_empty.rst#newcode48 tests/scenario_sale_empty.rst:48: >>> sale.state On 2017/07/14 12:37:13, pokoli wrote: > On ...
1 week, 4 days ago (2017-07-14 13:05:27 UTC) #6
pokoli
1 week, 1 day ago (2017-07-17 09:55:37 UTC) #7
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842