Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(105)

Issue 34991002: trytond: Decode username before logging it (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 1 week ago by ced
Modified:
5 months, 2 weeks ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

The username of request authorisation is bytes encoded in UTF-8. The logging module tries to decode it as ASCII by default. issue6517

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M trytond/protocols/dispatcher.py View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5
ced
6 months, 1 week ago (2017-05-19 10:54:06 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/34991002
6 months, 1 week ago (2017-05-19 11:09:03 UTC) #2
pokoli
LGTM
6 months ago (2017-05-23 08:37:24 UTC) #3
rietveld-bot_tryton.org
New changeset e079f5c0504e by Cédric Krier in branch 'default': Decode username before logging it http://hg.tryton.org/trytond/rev/e079f5c0504e
5 months, 3 weeks ago (2017-05-30 20:07:50 UTC) #4
rietveld-bot_tryton.org
5 months, 2 weeks ago (2017-06-13 08:01:25 UTC) #5
New changeset 2c59330d326d by Cédric Krier in branch '4.4':
Decode username before logging it
http://hg.tryton.org/trytond/rev/2c59330d326d


New changeset dc2eb1a2638a by Cédric Krier in branch '4.2':
Decode username before logging it
http://hg.tryton.org/trytond/rev/dc2eb1a2638a


New changeset 04223d7ba5fd by Cédric Krier in branch '4.0':
Decode username before logging it
http://hg.tryton.org/trytond/rev/04223d7ba5fd
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922