Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(120)

Issue 34951004: account_product: Set default category and product accounts on wizard

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by xcodinas
Modified:
1 week, 4 days ago
Reviewers:
pokoli, reviewbot, ced, albert
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5

Patch Set 2 : Fix pokoli comments #

Total comments: 1

Patch Set 3 : Fix albert comment #

Total comments: 4

Patch Set 4 : Fix ced comments #

Total comments: 1

Patch Set 5 : Add changelog, depends on new line #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -0 lines) Patch
M CHANGELOG View 1 2 3 4 1 chunk +2 lines, -0 lines 1 comment Download
M __init__.py View 1 3 chunks +5 lines, -0 lines 0 comments Download
A account.py View 1 2 3 4 1 chunk +61 lines, -0 lines 0 comments Download
A account.xml View 1 1 chunk +13 lines, -0 lines 0 comments Download
M tryton.cfg View 1 chunk +1 line, -0 lines 0 comments Download
A view/create_chart_properties_form.xml View 1 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 15
xcodinas
4 months, 1 week ago (2017-05-10 08:19:47 UTC) #1
pokoli
https://tryton-rietveld-hrd.appspot.com/34951004/diff/1/__init__.py File __init__.py (right): https://tryton-rietveld-hrd.appspot.com/34951004/diff/1/__init__.py#newcode7 __init__.py:7: import account better from . import account https://tryton-rietveld-hrd.appspot.com/34951004/diff/1/__init__.py#newcode26 __init__.py:26: ...
4 months, 1 week ago (2017-05-10 08:30:39 UTC) #2
reviewbot
https://codereview.tryton.org/34951004/diff/1/__init__.py#newcode5 __init__.py:5: F403 'from product import *' used; unable to detect undefined names https://codereview.tryton.org/34951004/diff/1/__init__.py#newcode6 __init__.py:6: ...
4 months, 1 week ago (2017-05-10 08:34:32 UTC) #3
xcodinas
Fix pokoli comments
4 months, 1 week ago (2017-05-10 09:08:28 UTC) #4
reviewbot
https://codereview.tryton.org/34951004/diff/20001/__init__.py#newcode5 __init__.py:5: F403 'from product import *' used; unable to detect undefined names https://codereview.tryton.org/34951004/diff/20001/__init__.py#newcode6 __init__.py:6: ...
4 months, 1 week ago (2017-05-10 09:31:31 UTC) #5
albert
https://tryton-rietveld.appspot.com/34951004/diff/20001/account.py File account.py (right): https://tryton-rietveld.appspot.com/34951004/diff/20001/account.py#newcode16 account.py:16: 'account.account', 'Default Account Expense', I think it should be ...
4 months, 1 week ago (2017-05-12 13:25:26 UTC) #6
xcodinas
Fix albert comment
4 months ago (2017-05-18 09:59:44 UTC) #7
reviewbot
https://codereview.tryton.org/34951004/diff/40001/__init__.py#newcode5 __init__.py:5: F403 'from product import *' used; unable to detect undefined names https://codereview.tryton.org/34951004/diff/40001/__init__.py#newcode6 __init__.py:6: ...
4 months ago (2017-05-18 10:10:40 UTC) #8
ced
https://tryton-rietveld.appspot.com/34951004/diff/40001/account.py File account.py (right): https://tryton-rietveld.appspot.com/34951004/diff/40001/account.py#newcode19 account.py:19: ('company', '=', Eval('context', {}).get('company', -1)), There is a company ...
2 months, 2 weeks ago (2017-07-02 20:09:49 UTC) #9
xcodinas
Fix ced comments
2 months, 1 week ago (2017-07-10 09:58:26 UTC) #10
reviewbot
https://codereview.tryton.org/34951004/diff/60001/__init__.py#newcode5 __init__.py:5: F403 'from product import *' used; unable to detect undefined names https://codereview.tryton.org/34951004/diff/60001/__init__.py#newcode6 __init__.py:6: ...
2 months, 1 week ago (2017-07-10 10:04:22 UTC) #11
ced
Missing changelog https://tryton-rietveld.appspot.com/34951004/diff/60001/account.py File account.py (right): https://tryton-rietveld.appspot.com/34951004/diff/60001/account.py#newcode20 account.py:20: ], depends=['company']) usually, we put depends on ...
2 months, 1 week ago (2017-07-12 21:30:31 UTC) #12
xcodinas
Add changelong, depends on new line
2 months ago (2017-07-17 11:21:31 UTC) #13
reviewbot
https://codereview.tryton.org/34951004/diff/80001/__init__.py#newcode5 __init__.py:5: F403 'from product import *' used; unable to detect undefined names https://codereview.tryton.org/34951004/diff/80001/__init__.py#newcode6 __init__.py:6: ...
2 months ago (2017-07-17 11:42:16 UTC) #14
ced
1 week, 4 days ago (2017-09-08 18:03:24 UTC) #15
LGTM

https://tryton-rietveld.appspot.com/34951004/diff/80001/CHANGELOG
File CHANGELOG (right):

https://tryton-rietveld.appspot.com/34951004/diff/80001/CHANGELOG#newcode1
CHANGELOG:1: * Set default category and product accounts on wizard
It will be clearer to talk about "configuration wizard".
And not use "set" but "allow to set".
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842