Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(346)

Issue 34701002: product: Limit cost method to fixed for service

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by xcodinas
Modified:
2 months ago
Reviewers:
pokoli, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add method in product #

Total comments: 2

Patch Set 3 : Fix comments #

Total comments: 3

Patch Set 4 : Use a domain in cost_price_method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M product.py View 1 2 3 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 12
xcodinas
2 months, 1 week ago (2017-02-15 09:52:36 UTC) #1
reviewbot
https://codereview.tryton.org/34701002/diff/1/product.py#newcode6 product.py:6: F401 'Column' imported but unused URL: https://codereview.tryton.org/34701002
2 months, 1 week ago (2017-02-15 10:09:16 UTC) #2
xcodinas
Add method in product
2 months, 1 week ago (2017-02-15 11:05:28 UTC) #3
reviewbot
https://codereview.tryton.org/34701002/diff/20001/product.py#newcode6 product.py:6: F401 'Column' imported but unused URL: https://codereview.tryton.org/34701002
2 months, 1 week ago (2017-02-15 11:33:42 UTC) #4
pokoli
https://tryton-rietveld.appspot.com/34701002/diff/20001/product.py File product.py (right): https://tryton-rietveld.appspot.com/34701002/diff/20001/product.py#newcode115 product.py:115: cost_price_methods = [ There is no need to create ...
2 months, 1 week ago (2017-02-15 11:35:35 UTC) #5
xcodinas
Fix comments
2 months, 1 week ago (2017-02-15 11:54:49 UTC) #6
reviewbot
https://codereview.tryton.org/34701002/diff/40001/product.py#newcode6 product.py:6: F401 'Column' imported but unused URL: https://codereview.tryton.org/34701002
2 months, 1 week ago (2017-02-15 11:57:50 UTC) #7
ced
https://tryton-rietveld.appspot.com/34701002/diff/40001/product.py File product.py (right): https://tryton-rietveld.appspot.com/34701002/diff/40001/product.py#newcode118 product.py:118: ('fixed', 'Fixed'), I would prefer to have a single ...
2 months, 1 week ago (2017-02-16 11:20:31 UTC) #8
pokoli
https://tryton-rietveld.appspot.com/34701002/diff/40001/product.py File product.py (right): https://tryton-rietveld.appspot.com/34701002/diff/40001/product.py#newcode119 product.py:119: ('average', 'Average'), On 2017/02/16 11:20:30, ced wrote: > The ...
2 months, 1 week ago (2017-02-16 11:51:12 UTC) #9
xcodinas
Use a domain in cost_price_method
2 months ago (2017-02-20 08:53:10 UTC) #10
reviewbot
https://codereview.tryton.org/34701002/diff/60001/product.py#newcode6 product.py:6: F401 'Column' imported but unused https://codereview.tryton.org/34701002/diff/60001/product.py#newcode56 product.py:56: E127 continuation line over-indented for visual ...
2 months ago (2017-02-20 09:10:22 UTC) #11
ced
2 months ago (2017-02-20 23:05:09 UTC) #12
On 2017/02/20 08:53:10, xcodinas wrote:
> Use a domain in cost_price_method

As domain is a constraint, I think it is better to have dynamic selection.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842