Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(355)

Issue 34091002: sao: Correctly set focus on filter form for Selection and Time fields (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by pokoli
Modified:
2 months, 3 weeks ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

We can not rely on setting the focus on the entry as the selection and time widgets store the input as separate element. So the focus must be set directly to the input to guarantee that it works for all widgets. issue6455

Patch Set 1 #

Total comments: 1

Patch Set 2 : Store input as as third element #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/screen.js View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11
pokoli
3 months ago (2017-04-20 15:03:11 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/34091002
3 months ago (2017-04-20 15:06:03 UTC) #2
ced
https://tryton-rietveld.appspot.com/34091002/diff/1/src/screen.js File src/screen.js (right): https://tryton-rietveld.appspot.com/34091002/diff/1/src/screen.js#newcode518 src/screen.js:518: var first_entry = this.search_form.fields[0][1]; Why not store input in ...
3 months ago (2017-04-20 15:42:54 UTC) #3
pokoli
Store input as as third element
3 months ago (2017-04-20 15:46:43 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/34091002
3 months ago (2017-04-20 16:01:23 UTC) #5
ced
LGTM
3 months ago (2017-04-20 20:53:43 UTC) #6
ced
On 2017/04/20 20:53:43, ced wrote: > LGTM You could be more detail and explanation.
3 months ago (2017-04-20 20:54:09 UTC) #7
pokoli
On 2017/04/20 20:54:09, ced wrote: > On 2017/04/20 20:53:43, ced wrote: > > LGTM > ...
3 months ago (2017-04-26 11:31:52 UTC) #8
ced
LGTM
3 months ago (2017-04-26 22:28:54 UTC) #9
rietveld-bot_tryton.org
New changeset b8be0b47d84c by Sergi Almacellas Abellana in branch 'default': Correctly set focus on filter ...
2 months, 4 weeks ago (2017-04-27 08:29:47 UTC) #10
rietveld-bot_tryton.org
2 months, 3 weeks ago (2017-05-03 16:55:11 UTC) #11
New changeset 95654d4eaf94 by Sergi Almacellas Abellana in branch '4.2':
Correctly set focus on filter form for Selection and Time fields
http://hg.tryton.org/sao/rev/95654d4eaf94


New changeset 153663df356d by Sergi Almacellas Abellana in branch '4.0':
Correctly set focus on filter form for Selection and Time fields
http://hg.tryton.org/sao/rev/153663df356d


New changeset 75e60c125674 by Sergi Almacellas Abellana in branch '3.8':
Correctly set focus on filter form for Selection and Time fields
http://hg.tryton.org/sao/rev/75e60c125674
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842