Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(365)

Issue 34091002: sao: Correctly set focus on filter form for Selection and Time fields

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 days, 3 hours ago by pokoli
Modified:
3 days, 22 hours ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Store input as as third element #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/screen.js View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7
pokoli
4 days, 3 hours ago (2017-04-20 15:03:11 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/34091002
4 days, 3 hours ago (2017-04-20 15:06:03 UTC) #2
ced
https://tryton-rietveld.appspot.com/34091002/diff/1/src/screen.js File src/screen.js (right): https://tryton-rietveld.appspot.com/34091002/diff/1/src/screen.js#newcode518 src/screen.js:518: var first_entry = this.search_form.fields[0][1]; Why not store input in ...
4 days, 3 hours ago (2017-04-20 15:42:54 UTC) #3
pokoli
Store input as as third element
4 days, 3 hours ago (2017-04-20 15:46:43 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/34091002
4 days, 2 hours ago (2017-04-20 16:01:23 UTC) #5
ced
LGTM
3 days, 22 hours ago (2017-04-20 20:53:43 UTC) #6
ced
3 days, 22 hours ago (2017-04-20 20:54:09 UTC) #7
On 2017/04/20 20:53:43, ced wrote:
> LGTM

You could be more detail and explanation.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842