Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(312)

Issue 32811002: sale_subscription: Initial commit (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 1 week ago by ced
Modified:
3 months, 3 weeks ago
Reviewers:
pokoli, rietveld-bot, albert, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : flake8 #

Total comments: 18

Patch Set 3 : Fix comments #

Total comments: 8

Patch Set 4 : Fix comments #

Total comments: 20

Patch Set 5 : Fix comments #

Patch Set 6 : Remove property #

Patch Set 7 : Fix default #

Patch Set 8 : Use reference first #

Patch Set 9 : Follow new help format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3222 lines, -0 lines) Patch
A .drone.yml View 1 chunk +9 lines, -0 lines 0 comments Download
A COPYRIGHT View 1 chunk +15 lines, -0 lines 0 comments Download
A INSTALL View 1 chunk +36 lines, -0 lines 0 comments Download
A LICENSE View 1 chunk +674 lines, -0 lines 0 comments Download
A MANIFEST.in View 1 chunk +13 lines, -0 lines 0 comments Download
A README View 1 chunk +35 lines, -0 lines 0 comments Download
A __init__.py View 1 2 3 4 5 1 chunk +31 lines, -0 lines 0 comments Download
A configuration.py View 1 2 3 4 5 6 1 chunk +54 lines, -0 lines 0 comments Download
A configuration.xml View 1 2 3 4 5 1 chunk +32 lines, -0 lines 0 comments Download
A doc/index.rst View 1 2 3 4 5 6 7 8 1 chunk +84 lines, -0 lines 0 comments Download
A invoice.py View 1 2 3 4 5 6 7 1 chunk +26 lines, -0 lines 0 comments Download
A recurrence.py View 1 2 3 4 5 6 7 8 1 chunk +220 lines, -0 lines 0 comments Download
A recurrence.xml View 1 chunk +82 lines, -0 lines 0 comments Download
A service.py View 1 chunk +31 lines, -0 lines 0 comments Download
A service.xml View 1 2 3 4 1 chunk +53 lines, -0 lines 0 comments Download
A setup.py View 1 2 3 4 5 6 7 1 chunk +129 lines, -0 lines 0 comments Download
A subscription.py View 1 2 3 4 5 6 7 8 1 chunk +836 lines, -0 lines 0 comments Download
A subscription.xml View 1 2 3 4 1 chunk +349 lines, -0 lines 0 comments Download
A tests/__init__.py View 1 1 chunk +10 lines, -0 lines 0 comments Download
A tests/scenario_sale_subscription.rst View 1 2 3 4 1 chunk +192 lines, -0 lines 0 comments Download
A tests/test_sale_subscription.py View 1 chunk +28 lines, -0 lines 0 comments Download
A tox.ini View 1 chunk +18 lines, -0 lines 0 comments Download
A tryton.cfg View 1 chunk +16 lines, -0 lines 0 comments Download
A view/configuration_form.xml View 1 chunk +9 lines, -0 lines 0 comments Download
A view/create_invoice_start_form.xml View 1 chunk +10 lines, -0 lines 0 comments Download
A view/line_consumption_create_start_form.xml View 1 chunk +11 lines, -0 lines 0 comments Download
A view/recurrence_rule_form.xml View 1 chunk +29 lines, -0 lines 0 comments Download
A view/recurrence_rule_list.xml View 1 chunk +16 lines, -0 lines 0 comments Download
A view/recurrence_rule_set_form.xml View 1 chunk +8 lines, -0 lines 0 comments Download
A view/recurrence_rule_set_list.xml View 1 chunk +6 lines, -0 lines 0 comments Download
A view/service_form.xml View 1 chunk +11 lines, -0 lines 0 comments Download
A view/service_list.xml View 1 chunk +8 lines, -0 lines 0 comments Download
A view/subscription_form.xml View 1 chunk +47 lines, -0 lines 0 comments Download
A view/subscription_line_consumption_form.xml View 1 chunk +11 lines, -0 lines 0 comments Download
A view/subscription_line_consumption_list.xml View 1 chunk +8 lines, -0 lines 0 comments Download
A view/subscription_line_form.xml View 1 chunk +33 lines, -0 lines 0 comments Download
A view/subscription_line_list.xml View 1 chunk +15 lines, -0 lines 0 comments Download
A view/subscription_line_list_sequence.xml View 1 chunk +15 lines, -0 lines 0 comments Download
A view/subscription_list.xml View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 26
ced
8 months, 1 week ago (2016-11-18 13:14:53 UTC) #1
reviewbot
https://codereview.tryton.org/32811002/diff/1/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too long (84 > 79 characters) URL: https://codereview.tryton.org/32811002
8 months, 1 week ago (2016-11-18 13:24:07 UTC) #2
ced
flake8
8 months, 1 week ago (2016-11-18 14:03:38 UTC) #3
reviewbot
flake8 OK URL: https://codereview.tryton.org/32811002
8 months, 1 week ago (2016-11-18 14:28:04 UTC) #4
albert
https://tryton-rietveld.appspot.com/32811002/diff/20001/recurrence.py File recurrence.py (right): https://tryton-rietveld.appspot.com/32811002/diff/20001/recurrence.py#newcode87 recurrence.py:87: wkst = fields.Selection([ I think it's better to name ...
7 months, 4 weeks ago (2016-11-28 22:15:45 UTC) #5
pokoli
https://tryton-rietveld-hrd.appspot.com/32811002/diff/20001/doc/index.rst File doc/index.rst (right): https://tryton-rietveld-hrd.appspot.com/32811002/diff/20001/doc/index.rst#newcode10 doc/index.rst:10: A subscription how some recurring services are periodically invoiced. ...
7 months, 2 weeks ago (2016-12-12 12:43:51 UTC) #6
ced
https://tryton-rietveld-hrd.appspot.com/32811002/diff/20001/doc/index.rst File doc/index.rst (right): https://tryton-rietveld-hrd.appspot.com/32811002/diff/20001/doc/index.rst#newcode10 doc/index.rst:10: A subscription how some recurring services are periodically invoiced. ...
7 months, 2 weeks ago (2016-12-12 16:47:29 UTC) #7
ced
Fix comments
7 months, 2 weeks ago (2016-12-12 16:48:09 UTC) #8
reviewbot
flake8 OK URL: https://codereview.tryton.org/32811002
7 months, 2 weeks ago (2016-12-12 16:54:46 UTC) #9
pokoli
https://tryton-rietveld.appspot.com/32811002/diff/40001/subscription.py File subscription.py (right): https://tryton-rietveld.appspot.com/32811002/diff/40001/subscription.py#newcode101 subscription.py:101: datetime.date.min)), This is not a valid pyson statement. It ...
7 months, 1 week ago (2016-12-20 08:46:40 UTC) #10
ced
https://tryton-rietveld.appspot.com/32811002/diff/40001/subscription.py File subscription.py (right): https://tryton-rietveld.appspot.com/32811002/diff/40001/subscription.py#newcode101 subscription.py:101: datetime.date.min)), On 2016/12/20 08:46:40, pokoli wrote: > This is ...
7 months, 1 week ago (2016-12-20 23:32:56 UTC) #11
ced
Fix comments
7 months, 1 week ago (2016-12-20 23:42:14 UTC) #12
reviewbot
flake8 OK URL: https://codereview.tryton.org/32811002
7 months, 1 week ago (2016-12-20 23:53:51 UTC) #13
pokoli
https://tryton-rietveld.appspot.com/32811002/diff/60001/recurrence.py File recurrence.py (right): https://tryton-rietveld.appspot.com/32811002/diff/60001/recurrence.py#newcode71 recurrence.py:71: help="A comma separated list of integers or weekday (MO, ...
5 months, 1 week ago (2017-02-16 12:48:20 UTC) #14
ced
https://tryton-rietveld.appspot.com/32811002/diff/60001/recurrence.py File recurrence.py (right): https://tryton-rietveld.appspot.com/32811002/diff/60001/recurrence.py#newcode71 recurrence.py:71: help="A comma separated list of integers or weekday (MO, ...
5 months, 1 week ago (2017-02-16 13:12:46 UTC) #15
ced
Fix comments
5 months, 1 week ago (2017-02-16 13:13:04 UTC) #16
reviewbot
https://codereview.tryton.org/32811002/diff/80001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/32811002
5 months, 1 week ago (2017-02-16 13:41:04 UTC) #17
ced
Remove property
3 months, 3 weeks ago (2017-04-01 17:36:19 UTC) #18
reviewbot
https://codereview.tryton.org/32811002/diff/100001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/32811002
3 months, 3 weeks ago (2017-04-01 17:39:18 UTC) #19
ced
Fix default
3 months, 3 weeks ago (2017-04-01 17:58:28 UTC) #20
reviewbot
https://codereview.tryton.org/32811002/diff/120001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/32811002
3 months, 3 weeks ago (2017-04-01 18:06:23 UTC) #21
ced
Use reference first
3 months, 3 weeks ago (2017-04-01 21:59:27 UTC) #22
reviewbot
https://codereview.tryton.org/32811002/diff/130001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/32811002
3 months, 3 weeks ago (2017-04-01 22:04:41 UTC) #23
ced
Follow new help format
3 months, 3 weeks ago (2017-04-01 22:15:30 UTC) #24
reviewbot
https://codereview.tryton.org/32811002/diff/150001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) URL: https://codereview.tryton.org/32811002
3 months, 3 weeks ago (2017-04-01 22:36:18 UTC) #25
rietveld-bot_tryton.org
3 months, 3 weeks ago (2017-04-01 22:40:31 UTC) #26
New changeset 2fb4b237a5b6 by C?dric Krier in branch 'default':
Initial commit
http://hg.tryton.org/modules/sale_subscription/rev/2fb4b237a5b6
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842