Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(69)

Issue 32231002: analytic_account: Make root required on entry (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 2 weeks ago by ced
Modified:
4 months, 1 week ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

The root needs to be filled to have the unique constraint working. issue6321

Patch Set 1 #

Total comments: 2

Patch Set 2 : Re-use on_change_with_required #

Total comments: 5

Patch Set 3 : Remove not necessary on_change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M account.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14
ced
5 months, 2 weeks ago (2017-04-06 14:33:45 UTC) #1
reviewbot
https://codereview.tryton.org/32231002/diff/1/account.py#newcode215 account.py:215: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
5 months, 2 weeks ago (2017-04-06 14:37:44 UTC) #2
pokoli
https://tryton-rietveld-hrd.appspot.com/32231002/diff/1/account.py File account.py (right): https://tryton-rietveld-hrd.appspot.com/32231002/diff/1/account.py#newcode485 account.py:485: self.required = self.root.mandatory why not calling on_change_with required after ...
5 months, 2 weeks ago (2017-04-06 14:48:37 UTC) #3
ced
https://tryton-rietveld-hrd.appspot.com/32231002/diff/1/account.py File account.py (right): https://tryton-rietveld-hrd.appspot.com/32231002/diff/1/account.py#newcode485 account.py:485: self.required = self.root.mandatory On 2017/04/06 14:48:37, pokoli wrote: > ...
5 months, 2 weeks ago (2017-04-06 15:05:41 UTC) #4
ced
Re-use on_change_with_required
5 months, 2 weeks ago (2017-04-06 15:15:11 UTC) #5
reviewbot
https://codereview.tryton.org/32231002/diff/20001/account.py#newcode215 account.py:215: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
5 months, 2 weeks ago (2017-04-06 15:36:36 UTC) #6
pokoli
https://tryton-rietveld.appspot.com/32231002/diff/20001/account.py File account.py (right): https://tryton-rietveld.appspot.com/32231002/diff/20001/account.py#newcode479 account.py:479: def on_change_account(self): There is a domain that enforces that ...
5 months, 2 weeks ago (2017-04-07 09:15:06 UTC) #7
ced
https://tryton-rietveld.appspot.com/32231002/diff/20001/account.py File account.py (right): https://tryton-rietveld.appspot.com/32231002/diff/20001/account.py#newcode479 account.py:479: def on_change_account(self): On 2017/04/07 09:15:06, pokoli wrote: > There ...
5 months, 2 weeks ago (2017-04-07 14:57:18 UTC) #8
pokoli
https://tryton-rietveld.appspot.com/32231002/diff/20001/account.py File account.py (right): https://tryton-rietveld.appspot.com/32231002/diff/20001/account.py#newcode479 account.py:479: def on_change_account(self): On 2017/04/07 14:57:18, ced wrote: > On ...
5 months ago (2017-04-18 08:11:00 UTC) #9
ced
https://tryton-rietveld.appspot.com/32231002/diff/20001/account.py File account.py (right): https://tryton-rietveld.appspot.com/32231002/diff/20001/account.py#newcode479 account.py:479: def on_change_account(self): On 2017/04/18 08:10:59, pokoli wrote: > On ...
5 months ago (2017-04-19 08:44:32 UTC) #10
ced
Remove not necessary on_change
5 months ago (2017-04-19 08:44:56 UTC) #11
reviewbot
https://codereview.tryton.org/32231002/diff/40001/account.py#newcode215 account.py:215: E712 comparison to True should be 'if cond is True:' or 'if cond:' ...
5 months ago (2017-04-19 08:59:38 UTC) #12
pokoli
LGTM
5 months ago (2017-04-19 09:18:33 UTC) #13
rietveld-bot_tryton.org
5 months ago (2017-04-21 08:19:21 UTC) #14
New changeset 2e409fe74a48 by C?dric Krier in branch 'default':
Make root required on entry
http://hg.tryton.org/modules/analytic_account/rev/2e409fe74a48
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842