Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(591)

Issue 31991002: account_invoice: Use Match pattern for invoice sequences

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by pokoli
Modified:
3 days, 8 hours ago
Visibility:
Public.

Description

- Also allow to customize the context used to compute sequences issue6212

Patch Set 1 #

Patch Set 2 : Remove test_state variable #

Patch Set 3 : Use match pattern #

Total comments: 21

Patch Set 4 : Fix ced's comments #

Total comments: 5

Patch Set 5 : Compute number in one function and remove checks on invoice sequences #

Patch Set 6 : Use filter and add view_ids in order to use sequence views #

Total comments: 12

Patch Set 7 : Fix ced coment's #

Patch Set 8 : Use domain instead of filter #

Total comments: 3

Patch Set 9 : Add docs and fix comments #

Total comments: 3

Patch Set 10 : fix udono's comments #

Total comments: 2

Patch Set 11 : Minor fixes on docs #

Patch Set 12 : Allow to customize the invoice_type pattern #

Patch Set 13 : Don't allow to customize the invoice_type pattern #

Total comments: 3

Patch Set 14 : Fix typo on docs #

Patch Set 15 : Only allow to read sequence configuration on account user group #

Total comments: 4

Patch Set 16 : Fix ced's comments #

Total comments: 1

Patch Set 17 : Fix migration, remove account access rule and move invoice_sequence on view #

Patch Set 18 : Remove invoice_type as pattern and keep a similar UX #

Patch Set 19 : Fix typo and test tools #

Unified diffs Side-by-side diffs Delta from patch set Stats (+317 lines, -267 lines) Patch
M CHANGELOG View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M __init__.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M account.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +144 lines, -195 lines 0 comments Download
M account.xml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 2 chunks +48 lines, -6 lines 0 comments Download
M doc/index.rst View 1 2 3 4 5 6 7 8 9 10 11 12 13 2 chunks +13 lines, -1 line 0 comments Download
M invoice.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +46 lines, -30 lines 0 comments Download
M tests/test_account_invoice.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +10 lines, -4 lines 0 comments Download
M tests/tools.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +5 lines, -4 lines 0 comments Download
M view/fiscalyear_form.xml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +2 lines, -9 lines 0 comments Download
A view/invoice_sequence_form.xml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +22 lines, -0 lines 0 comments Download
A view/invoice_sequence_list.xml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +12 lines, -0 lines 0 comments Download
A view/invoice_sequence_list_sequence.xml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +12 lines, -0 lines 0 comments Download
R view/period_form.xml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 67
pokoli
1 month ago (2017-01-23 14:29:13 UTC) #1
reviewbot
https://codereview.tryton.org/31991002/diff/1/invoice.py#newcode612 invoice.py:612: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/31991002
1 month ago (2017-01-23 14:40:14 UTC) #2
pokoli
Remove test_state variable
1 month ago (2017-01-23 14:45:31 UTC) #3
timitos3000
1 month ago (2017-01-23 14:54:59 UTC) #4
reviewbot
https://codereview.tryton.org/31991002/diff/20001/invoice.py#newcode612 invoice.py:612: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/31991002
1 month ago (2017-01-23 15:08:49 UTC) #5
udono
1 month ago (2017-01-23 15:18:49 UTC) #6
pokoli
Use match pattern
1 month ago (2017-01-23 16:59:05 UTC) #7
reviewbot
https://codereview.tryton.org/31991002/diff/40001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/31991002/diff/40001/__init__.py#newcode6 __init__.py:6: ...
1 month ago (2017-01-23 17:09:45 UTC) #8
ced
https://tryton-rietveld.appspot.com/31991002/diff/40001/account.py File account.py (right): https://tryton-rietveld.appspot.com/31991002/diff/40001/account.py#newcode21 account.py:21: 'fiscalyear', 'Sequences', label should be "Invoice Sequences" I prefer ...
1 month ago (2017-01-23 21:56:43 UTC) #9
ced
Description should be updated.
1 month ago (2017-01-23 21:57:38 UTC) #10
pokoli
Fix ced's comments
1 month ago (2017-01-24 08:39:26 UTC) #11
pokoli
https://tryton-rietveld.appspot.com/31991002/diff/40001/invoice.py File invoice.py (right): https://tryton-rietveld.appspot.com/31991002/diff/40001/invoice.py#newcode1011 invoice.py:1011: def number_sequence_context(self): On 2017/01/23 21:56:43, ced wrote: > I ...
1 month ago (2017-01-24 08:39:39 UTC) #12
reviewbot
https://codereview.tryton.org/31991002/diff/60001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/31991002/diff/60001/__init__.py#newcode6 __init__.py:6: ...
1 month ago (2017-01-24 09:09:34 UTC) #13
ced
https://tryton-rietveld.appspot.com/31991002/diff/40001/invoice.py File invoice.py (right): https://tryton-rietveld.appspot.com/31991002/diff/40001/invoice.py#newcode1011 invoice.py:1011: def number_sequence_context(self): On 2017/01/24 08:39:39, pokoli wrote: > On ...
1 month ago (2017-01-25 21:35:42 UTC) #14
pokoli
Compute number in one function and remove checks on invoice sequences
1 month ago (2017-01-26 09:53:08 UTC) #15
pokoli
https://tryton-rietveld.appspot.com/31991002/diff/60001/account.py File account.py (right): https://tryton-rietveld.appspot.com/31991002/diff/60001/account.py#newcode22 account.py:22: domain=[ On 2017/01/25 21:35:42, ced wrote: > Domain will ...
1 month ago (2017-01-26 09:54:03 UTC) #16
reviewbot
https://codereview.tryton.org/31991002/diff/70001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/31991002/diff/70001/__init__.py#newcode6 __init__.py:6: ...
1 month ago (2017-01-26 10:14:42 UTC) #17
pokoli
Use filter and add view_ids in order to use sequence views
1 month ago (2017-01-26 14:54:55 UTC) #18
reviewbot
https://codereview.tryton.org/31991002/diff/90001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/31991002/diff/90001/__init__.py#newcode6 __init__.py:6: ...
1 month ago (2017-01-26 15:13:24 UTC) #19
ced
https://tryton-rietveld.appspot.com/31991002/diff/90001/account.py File account.py (right): https://tryton-rietveld.appspot.com/31991002/diff/90001/account.py#newcode22 account.py:22: domain=[ should be a filter but as it will ...
3 weeks, 6 days ago (2017-01-30 23:41:38 UTC) #20
pokoli
https://tryton-rietveld.appspot.com/31991002/diff/90001/account.py File account.py (right): https://tryton-rietveld.appspot.com/31991002/diff/90001/account.py#newcode22 account.py:22: domain=[ On 2017/01/30 23:41:38, ced wrote: > should be ...
3 weeks, 6 days ago (2017-01-31 14:45:56 UTC) #21
pokoli
Fix ced coment's
3 weeks, 6 days ago (2017-01-31 15:15:56 UTC) #22
reviewbot
https://codereview.tryton.org/31991002/diff/110001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/31991002/diff/110001/__init__.py#newcode6 __init__.py:6: ...
3 weeks, 6 days ago (2017-01-31 15:40:29 UTC) #23
ced
https://tryton-rietveld.appspot.com/31991002/diff/90001/account.py File account.py (right): https://tryton-rietveld.appspot.com/31991002/diff/90001/account.py#newcode22 account.py:22: domain=[ On 2017/01/31 14:45:56, pokoli wrote: > On 2017/01/30 ...
3 weeks, 6 days ago (2017-01-31 15:53:02 UTC) #24
pokoli
https://tryton-rietveld.appspot.com/31991002/diff/90001/account.py File account.py (right): https://tryton-rietveld.appspot.com/31991002/diff/90001/account.py#newcode22 account.py:22: domain=[ On 2017/01/31 15:53:02, ced wrote: > On 2017/01/31 ...
3 weeks, 6 days ago (2017-01-31 16:16:47 UTC) #25
ced
https://tryton-rietveld.appspot.com/31991002/diff/90001/account.py File account.py (right): https://tryton-rietveld.appspot.com/31991002/diff/90001/account.py#newcode22 account.py:22: domain=[ On 2017/01/31 16:16:46, pokoli wrote: > On 2017/01/31 ...
3 weeks, 6 days ago (2017-01-31 22:33:04 UTC) #26
pokoli
Use domain instead of filter
3 weeks, 5 days ago (2017-02-01 09:36:02 UTC) #27
pokoli
On 2017/01/31 22:33:04, ced wrote: > https://tryton-rietveld.appspot.com/31991002/diff/90001/account.py > File account.py (right): > > https://tryton-rietveld.appspot.com/31991002/diff/90001/account.py#newcode22 > ...
3 weeks, 5 days ago (2017-02-01 09:36:06 UTC) #28
reviewbot
https://codereview.tryton.org/31991002/diff/130001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/31991002/diff/130001/__init__.py#newcode6 __init__.py:6: ...
3 weeks, 5 days ago (2017-02-01 09:45:18 UTC) #29
ced
I think the documentation should contain a description about the invoice sequence configuration. https://tryton-rietveld.appspot.com/31991002/diff/130001/invoice.py File ...
3 weeks, 5 days ago (2017-02-01 10:43:26 UTC) #30
pokoli
Add docs and fix comments
3 weeks, 5 days ago (2017-02-01 12:49:43 UTC) #31
reviewbot
https://codereview.tryton.org/31991002/diff/150001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/31991002/diff/150001/__init__.py#newcode6 __init__.py:6: ...
3 weeks, 5 days ago (2017-02-01 13:19:25 UTC) #32
udono
https://tryton-rietveld.appspot.com/31991002/diff/150001/doc/index.rst File doc/index.rst (right): https://tryton-rietveld.appspot.com/31991002/diff/150001/doc/index.rst#newcode132 doc/index.rst:132: The sequence used to compute de number of the ...
3 weeks, 5 days ago (2017-02-01 14:48:07 UTC) #33
pokoli
fix udono's comments
3 weeks, 5 days ago (2017-02-01 14:51:08 UTC) #34
reviewbot
https://codereview.tryton.org/31991002/diff/160001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/31991002/diff/160001/__init__.py#newcode6 __init__.py:6: ...
3 weeks, 5 days ago (2017-02-01 15:12:58 UTC) #35
ced
It will be good to have more feedback as it is a quite touchy change. ...
2 weeks, 5 days ago (2017-02-07 23:12:38 UTC) #36
pokoli
Minor fixes on docs
2 weeks, 5 days ago (2017-02-08 09:04:38 UTC) #37
pokoli
On 2017/02/07 23:12:38, ced wrote: > It will be good to have more feedback as ...
2 weeks, 5 days ago (2017-02-08 09:05:31 UTC) #38
reviewbot
https://codereview.tryton.org/31991002/diff/180001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/31991002/diff/180001/__init__.py#newcode6 __init__.py:6: ...
2 weeks, 5 days ago (2017-02-08 09:09:35 UTC) #39
pokoli
Allow to customize the invoice_type pattern
2 weeks, 5 days ago (2017-02-08 11:45:47 UTC) #40
reviewbot
https://codereview.tryton.org/31991002/diff/200001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/31991002/diff/200001/__init__.py#newcode6 __init__.py:6: ...
2 weeks, 5 days ago (2017-02-08 12:09:52 UTC) #41
ced
On 2017/02/08 11:45:47, pokoli wrote: > Allow to customize the invoice_type pattern What is the ...
2 weeks, 5 days ago (2017-02-08 12:15:08 UTC) #42
pokoli
Don't allow to customize the invoice_type pattern
2 weeks, 5 days ago (2017-02-08 12:22:51 UTC) #43
pokoli
On 2017/02/08 12:15:08, ced wrote: > On 2017/02/08 11:45:47, pokoli wrote: > > Allow to ...
2 weeks, 5 days ago (2017-02-08 12:23:12 UTC) #44
reviewbot
https://codereview.tryton.org/31991002/diff/220001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/31991002/diff/220001/__init__.py#newcode6 __init__.py:6: ...
2 weeks, 5 days ago (2017-02-08 12:40:15 UTC) #45
albert
https://tryton-rietveld.appspot.com/31991002/diff/220001/account.xml File account.xml (right): https://tryton-rietveld.appspot.com/31991002/diff/220001/account.xml#newcode53 account.xml:53: search="[('model', '=', 'account.invoice.sequence')]"/> I think that this access record ...
1 week, 6 days ago (2017-02-14 14:32:26 UTC) #46
pokoli
Fix typo on docs
1 week, 6 days ago (2017-02-14 14:40:42 UTC) #47
pokoli
Only allow to read sequence configuration on account user group
1 week, 6 days ago (2017-02-14 14:49:20 UTC) #48
reviewbot
https://codereview.tryton.org/31991002/diff/260001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/31991002/diff/260001/__init__.py#newcode6 __init__.py:6: ...
1 week, 6 days ago (2017-02-14 15:01:41 UTC) #49
ced
https://tryton-rietveld.appspot.com/31991002/diff/220001/account.xml File account.xml (right): https://tryton-rietveld.appspot.com/31991002/diff/220001/account.xml#newcode53 account.xml:53: search="[('model', '=', 'account.invoice.sequence')]"/> On 2017/02/14 14:32:25, albert wrote: > ...
1 week, 6 days ago (2017-02-14 18:04:35 UTC) #50
ced
On 2017/02/14 14:49:20, pokoli wrote: > Only allow to read sequence configuration on account user ...
1 week, 5 days ago (2017-02-15 20:47:55 UTC) #51
ced
The invoice type does not seem to be migrated.
1 week, 5 days ago (2017-02-15 21:00:28 UTC) #52
ced
https://tryton-rietveld.appspot.com/31991002/diff/260001/account.py File account.py (right): https://tryton-rietveld.appspot.com/31991002/diff/260001/account.py#newcode58 account.py:58: invoice_sequences = fields.One2Many('account.invoice.sequence', 'period', I'm not sure it is ...
1 week, 5 days ago (2017-02-15 21:10:28 UTC) #53
pokoli
On 2017/02/15 21:00:28, ced wrote: > The invoice type does not seem to be migrated. ...
1 week, 4 days ago (2017-02-16 09:05:09 UTC) #54
pokoli
On 2017/02/15 20:47:55, ced wrote: > On 2017/02/14 14:49:20, pokoli wrote: > > Only allow ...
1 week, 4 days ago (2017-02-16 09:06:18 UTC) #55
pokoli
Fix ced's comments
1 week, 4 days ago (2017-02-16 09:08:04 UTC) #56
ced
On 2017/02/16 09:05:09, pokoli wrote: > On 2017/02/15 21:00:28, ced wrote: > > The invoice ...
1 week, 4 days ago (2017-02-16 09:25:25 UTC) #57
ced
On 2017/02/16 09:06:18, pokoli wrote: > On 2017/02/15 20:47:55, ced wrote: > > On 2017/02/14 ...
1 week, 4 days ago (2017-02-16 09:26:23 UTC) #58
ced
On 2017/02/16 09:26:23, ced wrote: > On 2017/02/16 09:06:18, pokoli wrote: > > On 2017/02/15 ...
1 week, 4 days ago (2017-02-16 09:29:04 UTC) #59
ced
https://tryton-rietveld.appspot.com/31991002/diff/280001/view/invoice_sequence_form.xml File view/invoice_sequence_form.xml (right): https://tryton-rietveld.appspot.com/31991002/diff/280001/view/invoice_sequence_form.xml#newcode6 view/invoice_sequence_form.xml:6: <field name="sequence"/> everywhere else sequence is on the left. ...
1 week, 4 days ago (2017-02-16 09:31:11 UTC) #60
reviewbot
https://codereview.tryton.org/31991002/diff/280001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/31991002/diff/280001/__init__.py#newcode6 __init__.py:6: ...
1 week, 4 days ago (2017-02-16 09:36:08 UTC) #61
pokoli
Fix migration, remove account access rule and move invoice_sequence on view
1 week, 4 days ago (2017-02-16 09:41:09 UTC) #62
reviewbot
https://codereview.tryton.org/31991002/diff/300001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/31991002/diff/300001/__init__.py#newcode6 __init__.py:6: ...
1 week, 4 days ago (2017-02-16 09:57:59 UTC) #63
pokoli
Remove invoice_type as pattern and keep a similar UX
1 week, 3 days ago (2017-02-17 11:41:27 UTC) #64
reviewbot
https://codereview.tryton.org/31991002/diff/320001/__init__.py#newcode5 __init__.py:5: F403 'from payment_term import *' used; unable to detect undefined names https://codereview.tryton.org/31991002/diff/320001/__init__.py#newcode6 __init__.py:6: ...
1 week, 3 days ago (2017-02-17 11:59:42 UTC) #65
pokoli
Fix typo and test tools
3 days, 8 hours ago (2017-02-24 14:07:28 UTC) #66
reviewbot
3 days, 8 hours ago (2017-02-24 14:09:12 UTC) #67
https://codereview.tryton.org/31991002/diff/340001/__init__.py#newcode5
__init__.py:5:
F403 'from payment_term import *' used; unable to detect undefined names

https://codereview.tryton.org/31991002/diff/340001/__init__.py#newcode6
__init__.py:6:
F403 'from invoice import *' used; unable to detect undefined names

https://codereview.tryton.org/31991002/diff/340001/__init__.py#newcode7
__init__.py:7:
F403 'from party import *' used; unable to detect undefined names

https://codereview.tryton.org/31991002/diff/340001/__init__.py#newcode8
__init__.py:8:
F403 'from account import *' used; unable to detect undefined names

https://codereview.tryton.org/31991002/diff/340001/invoice.py#newcode1006
invoice.py:1006:
F841 local variable 'Date' is assigned to but never used

https://codereview.tryton.org/31991002/diff/340001/invoice.py#newcode612
invoice.py:612:
E127 continuation line over-indented for visual indent

URL: https://codereview.tryton.org/31991002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842