Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(111)

Issue 30501002: account_statement: Add statment origin and wizard to import them

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 months, 1 week ago by pokoli
Modified:
2 months, 2 weeks ago
Reviewers:
edbo.design, reviewbot, ced, albert
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add statment origin and wizard to import them #

Total comments: 1

Patch Set 3 : Update to tip and fix comments #

Total comments: 18

Patch Set 4 : Fix ced comments #

Total comments: 12

Patch Set 5 : Add doc and fix comments #

Total comments: 4

Patch Set 6 : Use Mixin and fix comments #

Patch Set 7 : Update to tip #

Total comments: 5

Patch Set 8 : Fix albert's comments #

Patch Set 9 : Remove unused RPC import #

Total comments: 1

Patch Set 10 : Return and empty list of origins #

Patch Set 11 : Remove unused create_payment_term form scenario #

Patch Set 12 : Fix icon name and remove journal from import start #

Patch Set 13 : Add missing functions for company field #

Patch Set 14 : Test if statement company is set #

Total comments: 3

Patch Set 15 : Manage line statement when nested with origins #

Patch Set 16 : Manage line statement when nested with origins #

Patch Set 17 : Remove uneeded view changes #

Total comments: 1

Patch Set 18 : Add comment, always call supper an add company field on statment view #

Total comments: 3

Patch Set 19 : Make lines readonly for non saved statement and don't clear statement value on line on_change_amount #

Unified diffs Side-by-side diffs Delta from patch set Stats (+469 lines, -31 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M __init__.py View 1 1 chunk +3 lines, -0 lines 0 comments Download
M doc/index.rst View 1 2 3 4 5 6 7 2 chunks +12 lines, -0 lines 0 comments Download
M statement.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 12 chunks +228 lines, -31 lines 0 comments Download
M statement.xml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +63 lines, -0 lines 0 comments Download
A tests/scenario_statement_origin.rst View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +111 lines, -0 lines 0 comments Download
M tests/test_account_statement.py View 1 15 1 chunk +4 lines, -0 lines 0 comments Download
A view/import_statement_start_view_form.xml View 1 2 3 5 6 7 8 9 10 11 1 chunk +9 lines, -0 lines 0 comments Download
M view/statement_form.xml View 1 2 3 4 5 6 7 8 9 10 11 15 16 1 chunk +4 lines, -0 lines 0 comments Download
M view/statement_line_form.xml View 1 1 chunk +2 lines, -0 lines 0 comments Download
A view/statement_origin_form.xml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +20 lines, -0 lines 0 comments Download
A view/statement_origin_tree.xml View 1 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 50
pokoli
8 months, 1 week ago (2016-09-14 14:56:44 UTC) #1
reviewbot
patch is not applicable URL: https://codereview.tryton.org/30501002
8 months, 1 week ago (2016-09-14 15:02:51 UTC) #2
pokoli
Add statment origin and wizard to import them
7 months, 2 weeks ago (2016-10-11 11:34:59 UTC) #3
reviewbot
https://codereview.tryton.org/30501002/diff/20001/__init__.py#newcode5 __init__.py:5: F403 'from .journal import *' used; unable to detect undefined names https://codereview.tryton.org/30501002/diff/20001/__init__.py#newcode6 __init__.py:6: ...
7 months, 2 weeks ago (2016-10-11 11:52:19 UTC) #4
albert
https://tryton-rietveld.appspot.com/30501002/diff/20001/CHANGELOG File CHANGELOG (right): https://tryton-rietveld.appspot.com/30501002/diff/20001/CHANGELOG#newcode2 CHANGELOG:2: * Add statment origins *statement*
6 months, 3 weeks ago (2016-10-31 12:33:13 UTC) #5
pokoli
Update to tip and fix comments
5 months, 3 weeks ago (2016-12-01 16:09:11 UTC) #6
reviewbot
https://codereview.tryton.org/30501002/diff/40001/__init__.py#newcode5 __init__.py:5: F403 'from .journal import *' used; unable to detect undefined names https://codereview.tryton.org/30501002/diff/40001/__init__.py#newcode6 __init__.py:6: ...
5 months, 3 weeks ago (2016-12-01 16:35:38 UTC) #7
ced
https://tryton-rietveld.appspot.com/30501002/diff/40001/statement.py File statement.py (right): https://tryton-rietveld.appspot.com/30501002/diff/40001/statement.py#newcode159 statement.py:159: Bool(Eval('origins', []))), I would use a default value [-1] ...
5 months ago (2016-12-18 18:18:04 UTC) #8
pokoli
Fix ced comments
5 months ago (2016-12-19 16:36:41 UTC) #9
reviewbot
https://codereview.tryton.org/30501002/diff/60001/__init__.py#newcode5 __init__.py:5: F403 'from .journal import *' used; unable to detect undefined names https://codereview.tryton.org/30501002/diff/60001/__init__.py#newcode6 __init__.py:6: ...
5 months ago (2016-12-19 16:53:03 UTC) #10
ced
The documentation should also be updated. https://tryton-rietveld.appspot.com/30501002/diff/60001/CHANGELOG File CHANGELOG (right): https://tryton-rietveld.appspot.com/30501002/diff/60001/CHANGELOG#newcode1 CHANGELOG:1: * Add wizard ...
4 months, 4 weeks ago (2016-12-26 17:07:33 UTC) #11
pokoli
Add doc and fix comments
4 months ago (2017-01-18 08:54:08 UTC) #12
pokoli
https://tryton-rietveld.appspot.com/30501002/diff/60001/statement.py File statement.py (right): https://tryton-rietveld.appspot.com/30501002/diff/60001/statement.py#newcode558 statement.py:558: class Line(sequence_ordered(), ModelSQL, ModelView): On 2016/12/26 17:07:33, ced wrote: ...
4 months ago (2017-01-18 08:54:26 UTC) #13
reviewbot
https://codereview.tryton.org/30501002/diff/80001/__init__.py#newcode5 __init__.py:5: F403 'from journal import *' used; unable to detect undefined names https://codereview.tryton.org/30501002/diff/80001/__init__.py#newcode6 __init__.py:6: ...
4 months ago (2017-01-18 09:12:25 UTC) #14
ced
https://tryton-rietveld.appspot.com/30501002/diff/60001/statement.py File statement.py (right): https://tryton-rietveld.appspot.com/30501002/diff/60001/statement.py#newcode558 statement.py:558: class Line(sequence_ordered(), ModelSQL, ModelView): On 2017/01/18 08:54:25, pokoli wrote: ...
4 months ago (2017-01-18 10:13:46 UTC) #15
pokoli
Use Mixin and fix comments
3 months, 3 weeks ago (2017-01-27 11:54:47 UTC) #16
reviewbot
https://codereview.tryton.org/30501002/diff/100001/__init__.py#newcode5 __init__.py:5: F403 'from journal import *' used; unable to detect undefined names https://codereview.tryton.org/30501002/diff/100001/__init__.py#newcode6 __init__.py:6: ...
3 months, 3 weeks ago (2017-01-27 12:13:56 UTC) #17
pokoli
Update to tip
3 months, 2 weeks ago (2017-02-02 12:00:23 UTC) #18
reviewbot
https://codereview.tryton.org/30501002/diff/120001/__init__.py#newcode5 __init__.py:5: F403 'from journal import *' used; unable to detect undefined names https://codereview.tryton.org/30501002/diff/120001/__init__.py#newcode6 __init__.py:6: ...
3 months, 2 weeks ago (2017-02-02 12:15:25 UTC) #19
albert
https://tryton-rietveld.appspot.com/30501002/diff/120001/doc/index.rst File doc/index.rst (right): https://tryton-rietveld.appspot.com/30501002/diff/120001/doc/index.rst#newcode55 doc/index.rst:55: The statement origin represents an statement line on an ...
3 months, 2 weeks ago (2017-02-02 22:35:18 UTC) #20
ced
https://tryton-rietveld.appspot.com/30501002/diff/120001/statement.py File statement.py (right): https://tryton-rietveld.appspot.com/30501002/diff/120001/statement.py#newcode942 statement.py:942: lines_amount = sum(getattr(l, 'amount') or Decimal(0) On 2017/02/02 22:35:18, ...
3 months, 2 weeks ago (2017-02-03 00:06:37 UTC) #21
pokoli
Fix albert's comments
3 months, 2 weeks ago (2017-02-03 08:14:53 UTC) #22
reviewbot
https://codereview.tryton.org/30501002/diff/140001/__init__.py#newcode5 __init__.py:5: F403 'from journal import *' used; unable to detect undefined names https://codereview.tryton.org/30501002/diff/140001/__init__.py#newcode6 __init__.py:6: ...
3 months, 2 weeks ago (2017-02-03 08:43:27 UTC) #23
pokoli
Remove unused RPC import
3 months, 2 weeks ago (2017-02-03 09:16:24 UTC) #24
reviewbot
https://codereview.tryton.org/30501002/diff/160001/__init__.py#newcode5 __init__.py:5: F403 'from journal import *' used; unable to detect undefined names https://codereview.tryton.org/30501002/diff/160001/__init__.py#newcode6 __init__.py:6: ...
3 months, 2 weeks ago (2017-02-03 09:45:06 UTC) #25
ced
https://tryton-rietveld.appspot.com/30501002/diff/160001/statement.py File statement.py (right): https://tryton-rietveld.appspot.com/30501002/diff/160001/statement.py#newcode998 statement.py:998: return self.origins I do not understand what is self.origins?
3 months, 1 week ago (2017-02-14 22:03:12 UTC) #26
pokoli
Return and empty list of origins
3 months, 1 week ago (2017-02-15 10:35:07 UTC) #27
reviewbot
https://codereview.tryton.org/30501002/diff/180001/__init__.py#newcode5 __init__.py:5: F403 'from journal import *' used; unable to detect undefined names https://codereview.tryton.org/30501002/diff/180001/__init__.py#newcode6 __init__.py:6: ...
3 months, 1 week ago (2017-02-15 10:36:17 UTC) #28
pokoli
Remove unused create_payment_term form scenario
3 months, 1 week ago (2017-02-15 11:31:31 UTC) #29
reviewbot
https://codereview.tryton.org/30501002/diff/200001/__init__.py#newcode5 __init__.py:5: F403 'from journal import *' used; unable to detect undefined names https://codereview.tryton.org/30501002/diff/200001/__init__.py#newcode6 __init__.py:6: ...
3 months, 1 week ago (2017-02-15 11:33:40 UTC) #30
pokoli
Fix icon name and remove journal from import start
3 months, 1 week ago (2017-02-15 12:19:27 UTC) #31
pokoli
Add missing functions for company field
3 months, 1 week ago (2017-02-15 12:29:08 UTC) #32
reviewbot
https://codereview.tryton.org/30501002/diff/230001/__init__.py#newcode5 __init__.py:5: F403 'from journal import *' used; unable to detect undefined names https://codereview.tryton.org/30501002/diff/230001/__init__.py#newcode6 __init__.py:6: ...
3 months, 1 week ago (2017-02-15 12:35:58 UTC) #33
pokoli
Test if statement company is set
3 months, 1 week ago (2017-02-15 13:07:54 UTC) #34
reviewbot
https://codereview.tryton.org/30501002/diff/250001/__init__.py#newcode5 __init__.py:5: F403 'from journal import *' used; unable to detect undefined names https://codereview.tryton.org/30501002/diff/250001/__init__.py#newcode6 __init__.py:6: ...
3 months, 1 week ago (2017-02-15 13:09:07 UTC) #35
EdbO.design
https://tryton-rietveld.appspot.com/30501002/diff/250001/__init__.py File __init__.py (right): https://tryton-rietveld.appspot.com/30501002/diff/250001/__init__.py#newcode18 __init__.py:18: Origin, Please move Origin before Line, otherwise you will ...
2 months, 4 weeks ago (2017-02-23 18:42:55 UTC) #36
ced
https://tryton-rietveld.appspot.com/30501002/diff/250001/tests/scenario_statement_origin.rst File tests/scenario_statement_origin.rst (right): https://tryton-rietveld.appspot.com/30501002/diff/250001/tests/scenario_statement_origin.rst#newcode105 tests/scenario_statement_origin.rst:105: >>> line.statement = statement This is not done by ...
2 months, 4 weeks ago (2017-02-23 19:28:51 UTC) #37
ced
https://tryton-rietveld.appspot.com/30501002/diff/250001/__init__.py File __init__.py (right): https://tryton-rietveld.appspot.com/30501002/diff/250001/__init__.py#newcode18 __init__.py:18: Origin, On 2017/02/23 18:42:55, EdbO.design wrote: > Please move ...
2 months, 4 weeks ago (2017-02-23 19:31:44 UTC) #38
pokoli
Manage line statement when nested with origins
2 months, 4 weeks ago (2017-02-24 12:12:37 UTC) #39
pokoli
Remove uneeded view changes
2 months, 4 weeks ago (2017-02-24 12:13:40 UTC) #40
reviewbot
https://codereview.tryton.org/30501002/diff/310001/__init__.py#newcode5 __init__.py:5: F403 'from journal import *' used; unable to detect undefined names https://codereview.tryton.org/30501002/diff/310001/__init__.py#newcode6 __init__.py:6: ...
2 months, 4 weeks ago (2017-02-24 12:35:01 UTC) #41
ced
On 2017/02/24 12:12:37, pokoli wrote: > Manage line statement when nested with origins I do ...
2 months, 4 weeks ago (2017-02-24 12:37:35 UTC) #42
ced
https://tryton-rietveld.appspot.com/30501002/diff/310001/statement.py File statement.py (right): https://tryton-rietveld.appspot.com/30501002/diff/310001/statement.py#newcode749 statement.py:749: return super(Line, self).on_change_with_company() always call super
2 months, 4 weeks ago (2017-02-24 12:37:54 UTC) #43
pokoli
Add comment, always call supper an add company field on statment view
2 months, 4 weeks ago (2017-02-24 12:52:59 UTC) #44
reviewbot
https://codereview.tryton.org/30501002/diff/330001/__init__.py#newcode5 __init__.py:5: F403 'from journal import *' used; unable to detect undefined names https://codereview.tryton.org/30501002/diff/330001/__init__.py#newcode6 __init__.py:6: ...
2 months, 4 weeks ago (2017-02-24 12:59:21 UTC) #45
ced
https://tryton-rietveld.appspot.com/30501002/diff/330001/statement.py File statement.py (right): https://tryton-rietveld.appspot.com/30501002/diff/330001/statement.py#newcode779 statement.py:779: # created lines related to origin related to an ...
2 months, 4 weeks ago (2017-02-24 14:15:08 UTC) #46
pokoli
https://tryton-rietveld.appspot.com/30501002/diff/330001/statement.py File statement.py (right): https://tryton-rietveld.appspot.com/30501002/diff/330001/statement.py#newcode779 statement.py:779: # created lines related to origin related to an ...
2 months, 4 weeks ago (2017-02-24 14:34:20 UTC) #47
ced
https://tryton-rietveld.appspot.com/30501002/diff/330001/statement.py File statement.py (right): https://tryton-rietveld.appspot.com/30501002/diff/330001/statement.py#newcode779 statement.py:779: # created lines related to origin related to an ...
2 months, 4 weeks ago (2017-02-24 14:45:51 UTC) #48
pokoli
Make lines readonly for non saved statement and don't clear statement value on line on_change_amount
2 months, 4 weeks ago (2017-02-24 15:16:11 UTC) #49
reviewbot
2 months, 4 weeks ago (2017-02-24 15:31:49 UTC) #50
https://codereview.tryton.org/30501002/diff/340001/__init__.py#newcode5
__init__.py:5:
F403 'from journal import *' used; unable to detect undefined names

https://codereview.tryton.org/30501002/diff/340001/__init__.py#newcode6
__init__.py:6:
F403 'from statement import *' used; unable to detect undefined names

https://codereview.tryton.org/30501002/diff/340001/__init__.py#newcode7
__init__.py:7:
F403 'from account import *' used; unable to detect undefined names

URL: https://codereview.tryton.org/30501002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842