Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(353)

Issue 29231002: account: Show move form after creating a move from a template (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by pokoli
Modified:
1 month, 3 weeks ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Use new action for template result and test active_model on end #

Total comments: 2

Patch Set 3 : Use intermediary variable and remove not needed list view #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M move_template.py View 1 2 3 chunks +5 lines, -4 lines 0 comments Download
M move_template.xml View 1 2 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10
pokoli
2 months, 1 week ago (2017-02-13 16:57:39 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/29231002
2 months, 1 week ago (2017-02-13 17:04:16 UTC) #2
ced
https://tryton-rietveld.appspot.com/29231002/diff/1/move_template.py File move_template.py (right): https://tryton-rietveld.appspot.com/29231002/diff/1/move_template.py#newcode321 move_template.py:321: action['views'].reverse() I'm wondering if it is not better to ...
2 months, 1 week ago (2017-02-16 10:23:33 UTC) #3
pokoli
Use new action for template result and test active_model on end
2 months ago (2017-02-17 09:23:15 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/29231002
2 months ago (2017-02-17 09:30:36 UTC) #5
ced
https://tryton-rietveld.appspot.com/29231002/diff/20001/move_template.py File move_template.py (right): https://tryton-rietveld.appspot.com/29231002/diff/20001/move_template.py#newcode324 move_template.py:324: if Transaction().context.get('active_model') == 'account.move.line': is not better to use ...
2 months ago (2017-02-20 23:03:29 UTC) #6
pokoli
Use intermediary variable and remove not needed list view
2 months ago (2017-02-21 08:50:03 UTC) #7
reviewbot
flake8 OK URL: https://codereview.tryton.org/29231002
2 months ago (2017-02-21 08:58:07 UTC) #8
ced
LGTM
2 months ago (2017-02-22 23:29:58 UTC) #9
rietveld-bot_tryton.org
1 month, 4 weeks ago (2017-02-24 09:05:12 UTC) #10
New changeset 1310afa97ee2 by Sergi Almacellas Abellana in branch 'default':
Show move form after creating a move from a template
http://hg.tryton.org/modules/account/rev/1310afa97ee2
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842