Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(934)

Issue 28251002: stock_lot_serial: Initial commit

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by nicoe
Modified:
2 weeks, 3 days ago
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add view #

Total comments: 19

Patch Set 3 : Fix pokoli's and cedk's remarks #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1283 lines, -0 lines) Patch
A .drone.yml View 1 chunk +9 lines, -0 lines 0 comments Download
A COPYRIGHT View 1 chunk +15 lines, -0 lines 0 comments Download
A INSTALL View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
A LICENSE View 1 chunk +674 lines, -0 lines 0 comments Download
A MANIFEST.in View 1 chunk +13 lines, -0 lines 0 comments Download
A README View 1 chunk +35 lines, -0 lines 0 comments Download
A __init__.py View 1 chunk +23 lines, -0 lines 0 comments Download
A doc/index.rst View 1 chunk +18 lines, -0 lines 0 comments Download
A product.py View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A product.xml View 1 1 chunk +10 lines, -0 lines 0 comments Download
A setup.py View 1 chunk +124 lines, -0 lines 0 comments Download
A stock.py View 1 2 1 chunk +92 lines, -0 lines 1 comment Download
A tests/__init__.py View 1 chunk +9 lines, -0 lines 0 comments Download
A tests/scenario_stock_lot_serial.rst View 1 chunk +150 lines, -0 lines 0 comments Download
A tests/test_stock_lot_serial.py View 1 chunk +24 lines, -0 lines 0 comments Download
A tox.ini View 1 chunk +18 lines, -0 lines 0 comments Download
A tryton.cfg View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
A view/template_form.xml View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12
nicoe
1 month, 1 week ago (2017-04-14 16:09:24 UTC) #1
reviewbot
https://codereview.tryton.org/28251002/diff/1/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) https://codereview.tryton.org/28251002/diff/1/stock.py#newcode77 stock.py:77: E712 comparison to ...
1 month, 1 week ago (2017-04-14 16:33:27 UTC) #2
nicoe
Add view
1 month, 1 week ago (2017-04-14 19:33:26 UTC) #3
reviewbot
https://codereview.tryton.org/28251002/diff/20001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) https://codereview.tryton.org/28251002/diff/20001/stock.py#newcode77 stock.py:77: E712 comparison to ...
1 month, 1 week ago (2017-04-14 19:39:14 UTC) #4
pokoli
https://tryton-rietveld-hrd.appspot.com/28251002/diff/20001/INSTALL File INSTALL (right): https://tryton-rietveld-hrd.appspot.com/28251002/diff/20001/INSTALL#newcode8 INSTALL:8: * trytond (http://www.tryton.org/) trytond_stock_lot is also required, isn't it? ...
1 month, 1 week ago (2017-04-18 09:14:42 UTC) #5
ced
https://tryton-rietveld.appspot.com/28251002/diff/20001/doc/index.rst File doc/index.rst (right): https://tryton-rietveld.appspot.com/28251002/diff/20001/doc/index.rst#newcode1 doc/index.rst:1: Stock Lot Serial Module I do not think "Serial" ...
1 month, 1 week ago (2017-04-18 09:36:50 UTC) #6
timitos3000
The module does not work for me. Even when i enter unique lots into a ...
1 month ago (2017-04-24 08:04:36 UTC) #7
nicoe
On 2017/04/24 08:04:36, timitos3000 wrote: > The module does not work for me. Even when ...
3 weeks, 2 days ago (2017-05-04 16:37:25 UTC) #8
nicoe
Fix pokoli's and cedk's remarks
3 weeks, 2 days ago (2017-05-04 16:39:03 UTC) #9
nicoe
https://tryton-rietveld-hrd.appspot.com/28251002/diff/20001/INSTALL File INSTALL (right): https://tryton-rietveld-hrd.appspot.com/28251002/diff/20001/INSTALL#newcode8 INSTALL:8: * trytond (http://www.tryton.org/) On 2017/04/18 09:14:41, pokoli wrote: > ...
3 weeks, 2 days ago (2017-05-04 16:39:05 UTC) #10
reviewbot
https://codereview.tryton.org/28251002/diff/40001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) https://codereview.tryton.org/28251002/diff/40001/stock.py#newcode6 stock.py:6: F401 'Count' imported ...
3 weeks, 2 days ago (2017-05-04 16:59:40 UTC) #11
rpit58
2 weeks, 3 days ago (2017-05-10 11:20:34 UTC) #12
https://tryton-rietveld.appspot.com/28251002/diff/40001/stock.py
File stock.py (right):

https://tryton-rietveld.appspot.com/28251002/diff/40001/stock.py#newcode60
stock.py:60: continue
I think it's better to use
key = (move.to_location.id, move.lot.id)
because one lot cannot be moved twice to the same location in one shipment
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842