Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(77)

Issue 28251002: stock_lot_serial: Initial commit

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months, 2 weeks ago by nicoe
Modified:
4 weeks, 1 day ago
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Add view #

Total comments: 19

Patch Set 3 : Fix pokoli's and cedk's remarks #

Total comments: 21

Patch Set 4 : Fix cedric remarks #

Total comments: 2

Patch Set 5 : fix Udo's remark #

Total comments: 7

Patch Set 6 : Fix remarks #

Total comments: 23

Patch Set 7 : fix remarks #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats (+1335 lines, -0 lines) Patch
A .drone.yml View 1 2 3 4 5 6 1 chunk +51 lines, -0 lines 1 comment Download
A COPYRIGHT View 1 2 3 4 5 1 chunk +15 lines, -0 lines 0 comments Download
A INSTALL View 1 2 3 4 5 1 chunk +31 lines, -0 lines 0 comments Download
A LICENSE View 1 2 3 4 5 1 chunk +674 lines, -0 lines 0 comments Download
A MANIFEST.in View 1 2 3 4 5 1 chunk +13 lines, -0 lines 1 comment Download
A README View 1 2 3 4 5 1 chunk +35 lines, -0 lines 0 comments Download
A __init__.py View 1 2 3 4 5 1 chunk +23 lines, -0 lines 0 comments Download
A doc/index.rst View 1 2 3 4 5 6 1 chunk +15 lines, -0 lines 0 comments Download
A product.py View 1 2 3 4 5 6 1 chunk +29 lines, -0 lines 0 comments Download
A product.xml View 1 2 3 4 5 1 chunk +10 lines, -0 lines 0 comments Download
A setup.py View 1 2 3 4 5 1 chunk +124 lines, -0 lines 2 comments Download
A stock.py View 1 2 3 4 5 6 1 chunk +97 lines, -0 lines 3 comments Download
A tests/__init__.py View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments Download
A tests/scenario_stock_lot_serial.rst View 1 2 3 4 5 6 1 chunk +150 lines, -0 lines 0 comments Download
A tests/test_stock_lot_serial.py View 1 2 3 4 5 1 chunk +24 lines, -0 lines 0 comments Download
A tox.ini View 1 2 3 4 5 1 chunk +18 lines, -0 lines 1 comment Download
A tryton.cfg View 1 2 3 4 5 1 chunk +9 lines, -0 lines 0 comments Download
A view/template_form.xml View 1 2 3 4 5 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 29
nicoe
7 months, 2 weeks ago (2017-04-14 16:09:24 UTC) #1
reviewbot
https://codereview.tryton.org/28251002/diff/1/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) https://codereview.tryton.org/28251002/diff/1/stock.py#newcode77 stock.py:77: E712 comparison to ...
7 months, 2 weeks ago (2017-04-14 16:33:27 UTC) #2
nicoe
Add view
7 months, 1 week ago (2017-04-14 19:33:26 UTC) #3
reviewbot
https://codereview.tryton.org/28251002/diff/20001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) https://codereview.tryton.org/28251002/diff/20001/stock.py#newcode77 stock.py:77: E712 comparison to ...
7 months, 1 week ago (2017-04-14 19:39:14 UTC) #4
pokoli
https://tryton-rietveld-hrd.appspot.com/28251002/diff/20001/INSTALL File INSTALL (right): https://tryton-rietveld-hrd.appspot.com/28251002/diff/20001/INSTALL#newcode8 INSTALL:8: * trytond (http://www.tryton.org/) trytond_stock_lot is also required, isn't it? ...
7 months, 1 week ago (2017-04-18 09:14:42 UTC) #5
ced
https://tryton-rietveld.appspot.com/28251002/diff/20001/doc/index.rst File doc/index.rst (right): https://tryton-rietveld.appspot.com/28251002/diff/20001/doc/index.rst#newcode1 doc/index.rst:1: Stock Lot Serial Module I do not think "Serial" ...
7 months, 1 week ago (2017-04-18 09:36:50 UTC) #6
timitos3000
The module does not work for me. Even when i enter unique lots into a ...
7 months ago (2017-04-24 08:04:36 UTC) #7
nicoe
On 2017/04/24 08:04:36, timitos3000 wrote: > The module does not work for me. Even when ...
6 months, 3 weeks ago (2017-05-04 16:37:25 UTC) #8
nicoe
Fix pokoli's and cedk's remarks
6 months, 3 weeks ago (2017-05-04 16:39:03 UTC) #9
nicoe
https://tryton-rietveld-hrd.appspot.com/28251002/diff/20001/INSTALL File INSTALL (right): https://tryton-rietveld-hrd.appspot.com/28251002/diff/20001/INSTALL#newcode8 INSTALL:8: * trytond (http://www.tryton.org/) On 2017/04/18 09:14:41, pokoli wrote: > ...
6 months, 3 weeks ago (2017-05-04 16:39:05 UTC) #10
reviewbot
https://codereview.tryton.org/28251002/diff/40001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) https://codereview.tryton.org/28251002/diff/40001/stock.py#newcode6 stock.py:6: F401 'Count' imported ...
6 months, 3 weeks ago (2017-05-04 16:59:40 UTC) #11
rpit58
https://tryton-rietveld.appspot.com/28251002/diff/40001/stock.py File stock.py (right): https://tryton-rietveld.appspot.com/28251002/diff/40001/stock.py#newcode60 stock.py:60: continue I think it's better to use key = ...
6 months, 2 weeks ago (2017-05-10 11:20:34 UTC) #12
ced
https://tryton-rietveld.appspot.com/28251002/diff/40001/doc/index.rst File doc/index.rst (right): https://tryton-rietveld.appspot.com/28251002/diff/40001/doc/index.rst#newcode4 doc/index.rst:4: The ``stock_lot_serial`` module implements the use and check of ...
5 months, 3 weeks ago (2017-06-01 08:45:41 UTC) #13
nicoe
Fix cedric remarks
5 months, 3 weeks ago (2017-06-01 16:51:17 UTC) #14
reviewbot
https://codereview.tryton.org/28251002/diff/60001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) https://codereview.tryton.org/28251002/diff/60001/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
5 months, 3 weeks ago (2017-06-01 17:08:01 UTC) #15
udono
https://tryton-rietveld.appspot.com/28251002/diff/60001/product.py File product.py (right): https://tryton-rietveld.appspot.com/28251002/diff/60001/product.py#newcode18 product.py:18: & ~Eval('serializable_unit', False)), serializable_unit vs … https://tryton-rietveld.appspot.com/28251002/diff/60001/product.py#newcode21 product.py:21: serializable ...
5 months, 1 week ago (2017-06-20 11:31:04 UTC) #16
nicoe
fix Udo's remark
5 months, 1 week ago (2017-06-20 13:17:10 UTC) #17
nicoe
https://tryton-rietveld.appspot.com/28251002/diff/40001/doc/index.rst File doc/index.rst (right): https://tryton-rietveld.appspot.com/28251002/diff/40001/doc/index.rst#newcode4 doc/index.rst:4: The ``stock_lot_serial`` module implements the use and check of ...
5 months, 1 week ago (2017-06-20 13:17:27 UTC) #18
reviewbot
https://codereview.tryton.org/28251002/diff/80001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) https://codereview.tryton.org/28251002/diff/80001/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
5 months, 1 week ago (2017-06-20 13:31:34 UTC) #19
ced
https://tryton-rietveld.appspot.com/28251002/diff/80001/stock.py File stock.py (right): https://tryton-rietveld.appspot.com/28251002/diff/80001/stock.py#newcode23 stock.py:23: 'lot "%(lot)s" must be 1.'), Should contain the name ...
3 months, 3 weeks ago (2017-08-03 20:51:03 UTC) #20
nicoe
Fix remarks
2 months ago (2017-09-22 10:36:05 UTC) #21
nicoe
https://tryton-rietveld.appspot.com/28251002/diff/80001/stock.py File stock.py (right): https://tryton-rietveld.appspot.com/28251002/diff/80001/stock.py#newcode23 stock.py:23: 'lot "%(lot)s" must be 1.'), On 2017/08/03 20:51:02, ced ...
2 months ago (2017-09-22 10:36:08 UTC) #22
reviewbot
https://codereview.tryton.org/28251002/diff/100001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) https://codereview.tryton.org/28251002/diff/100001/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
2 months ago (2017-09-22 10:44:40 UTC) #23
pokoli
https://tryton-rietveld.appspot.com/28251002/diff/100001/.drone.yml File .drone.yml (right): https://tryton-rietveld.appspot.com/28251002/diff/100001/.drone.yml#newcode1 .drone.yml:1: image: python:all must be updated https://tryton-rietveld.appspot.com/28251002/diff/100001/doc/index.rst File doc/index.rst (right): ...
2 months ago (2017-09-22 12:55:59 UTC) #24
timitos3000
https://codereview.tryton.org/28251002/diff/100001/product.py File product.py (right): https://codereview.tryton.org/28251002/diff/100001/product.py#newcode18 product.py:18: & ~Eval('serializable', False)), On 2017/09/22 12:55:58, pokoli wrote: > ...
1 month, 1 week ago (2017-10-17 12:48:30 UTC) #25
nicoe
https://tryton-rietveld.appspot.com/28251002/diff/100001/.drone.yml File .drone.yml (right): https://tryton-rietveld.appspot.com/28251002/diff/100001/.drone.yml#newcode1 .drone.yml:1: image: python:all On 2017/09/22 12:55:58, pokoli wrote: > must ...
1 month ago (2017-10-19 10:42:07 UTC) #26
nicoe
fix remarks
1 month ago (2017-10-19 10:58:55 UTC) #27
reviewbot
https://codereview.tryton.org/28251002/diff/120001/setup.py#newcode88 setup.py:88: E501 line too long (85 > 79 characters) https://codereview.tryton.org/28251002/diff/120001/tests/__init__.py#newcode5 tests/__init__.py:5: E501 line too ...
1 month ago (2017-10-19 11:09:11 UTC) #28
pokoli
4 weeks, 1 day ago (2017-10-26 08:44:27 UTC) #29
https://codereview.tryton.org/28251002/diff/120001/.drone.yml
File .drone.yml (right):

https://codereview.tryton.org/28251002/diff/120001/.drone.yml#newcode34
.drone.yml:34: - IMAGE: python:3.3
3.3 should be droped and 3.6 added

https://codereview.tryton.org/28251002/diff/120001/MANIFEST.in
File MANIFEST.in (right):

https://codereview.tryton.org/28251002/diff/120001/MANIFEST.in#newcode9
MANIFEST.in:9: include *.odt
should be fodt

https://codereview.tryton.org/28251002/diff/120001/setup.py
File setup.py (right):

https://codereview.tryton.org/28251002/diff/120001/setup.py#newcode78
setup.py:78: + ['tryton.cfg', 'view/*.xml', 'locale/*.po', '*.odt',
odt should be fodt

https://codereview.tryton.org/28251002/diff/120001/setup.py#newcode104
setup.py:104: 'Programming Language :: Python :: 3.3',
3.3 must be removed and 3.6 added

https://codereview.tryton.org/28251002/diff/120001/stock.py
File stock.py (right):

https://codereview.tryton.org/28251002/diff/120001/stock.py#newcode23
stock.py:23: 'in "%(move)s" of the lot "%(lot)s" must be 1%(unit)s '
I think its better to say "serializable lot" instead of "lot", to transmit the
message that this is only applicable to serializable lots.

https://codereview.tryton.org/28251002/diff/120001/stock.py#newcode27
stock.py:27: def check_lot(self):
I don't see where this is called. validate should be overriden to ensure that is
always checked.

https://codereview.tryton.org/28251002/diff/120001/stock.py#newcode94
stock.py:94: class ShipmentInternal(ShipmentSerializedLotMixin):
I think we should do the same for production adding the module as extra_depends

https://codereview.tryton.org/28251002/diff/120001/tox.ini
File tox.ini (right):

https://codereview.tryton.org/28251002/diff/120001/tox.ini#newcode2
tox.ini:2: envlist =
{py27,py33,py34,py35}-{sqlite,postgresql,mysql},pypy-{sqlite,postgresql}
same for 3.3 and 3.6 python versions
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922