Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(99)

Issue 27861002: tryton: Unify toolbar and menu definition (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months, 1 week ago by xcodinas
Modified:
2 weeks, 6 days ago
Reviewers:
pokoli, rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

- Use a unique definition - Update states of both toolbar and menu - Use a more logical order issue5644 COLLABORATOR=cedric.krier@b2ck.com

Patch Set 1 #

Total comments: 6

Patch Set 2 : Add new button, remove innecessary code, fix import /export #

Patch Set 3 : Remove export as it only needs read access #

Total comments: 1

Patch Set 4 : Fix comments #

Total comments: 2

Patch Set 5 : Use same function as buttons #

Patch Set 6 : Use different dictionary #

Total comments: 2

Patch Set 7 : Merge toolbar and menu definitions #

Patch Set 8 : Check tooltip for toolbar buttons instead of note #

Patch Set 9 : Keep original order #

Total comments: 4

Patch Set 10 : Update board, use namedtuple #

Total comments: 4

Patch Set 11 : fix comments #

Total comments: 13

Patch Set 12 : Add attribute to know if menu or toobar #

Total comments: 5

Patch Set 13 : Define ToolbarItem in tabcontent, make spacers a toolbaritem #

Patch Set 14 : Prevent two separators #

Total comments: 12

Patch Set 15 : Update to tip and fix comments #

Total comments: 2

Patch Set 16 : Fix pokoli remarks #

Total comments: 1

Patch Set 17 : Fix close tab not working #

Total comments: 5

Patch Set 18 : Make a loop for checking sensitive #

Patch Set 19 : Use object for toolbar item, use properties, set correct state #

Unified diffs Side-by-side diffs Delta from patch set Stats (+232 lines, -171 lines) Patch
M tryton/gui/window/board.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +0 lines, -26 lines 0 comments Download
M tryton/gui/window/form.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 4 chunks +18 lines, -81 lines 0 comments Download
M tryton/gui/window/tabcontent.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +177 lines, -25 lines 0 comments Download
M tryton/gui/window/view_form/view/form_gtk/one2many.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 2 chunks +37 lines, -39 lines 0 comments Download

Messages

Total messages: 67
xcodinas
9 months, 1 week ago (2016-12-14 08:37:14 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/27861002
9 months, 1 week ago (2016-12-14 09:02:48 UTC) #2
pokoli
https://tryton-rietveld-hrd.appspot.com/27861002/diff/1/tryton/gui/window/tabcontent.py File tryton/gui/window/tabcontent.py (right): https://tryton-rietveld-hrd.appspot.com/27861002/diff/1/tryton/gui/window/tabcontent.py#newcode145 tryton/gui/window/tabcontent.py:145: access = common.MODELACCESS[self.screen.model_name] What about new button? https://tryton-rietveld-hrd.appspot.com/27861002/diff/1/tryton/gui/window/tabcontent.py#newcode148 tryton/gui/window/tabcontent.py:148: ...
9 months, 1 week ago (2016-12-14 10:32:35 UTC) #3
xcodinas
Add new button, remove innecessary code, fix import /export
9 months, 1 week ago (2016-12-14 11:01:38 UTC) #4
reviewbot
flake8 OK URL: https://codereview.tryton.org/27861002
9 months, 1 week ago (2016-12-14 11:03:02 UTC) #5
xcodinas
Remove export as it only needs read access
9 months, 1 week ago (2016-12-14 11:12:25 UTC) #6
reviewbot
flake8 OK URL: https://codereview.tryton.org/27861002
9 months, 1 week ago (2016-12-14 11:22:40 UTC) #7
ced
It should be managed as set_buttons_sensitive but for menu. For that I guess we could ...
9 months ago (2016-12-16 23:06:35 UTC) #8
xcodinas
On 2016/12/16 23:06:35, ced wrote: > It should be managed as set_buttons_sensitive but for menu. ...
9 months ago (2016-12-21 11:20:29 UTC) #9
ced
On 2016/12/21 11:20:29, xcodinas wrote: > On 2016/12/16 23:06:35, ced wrote: > > It should ...
8 months, 3 weeks ago (2016-12-26 17:24:55 UTC) #10
xcodinas
On 2016/12/26 17:24:55, ced wrote: > On 2016/12/21 11:20:29, xcodinas wrote: > > On 2016/12/16 ...
8 months, 3 weeks ago (2016-12-27 09:31:51 UTC) #11
ced
On 2016/12/27 09:31:51, xcodinas wrote: > On 2016/12/26 17:24:55, ced wrote: > > On 2016/12/21 ...
8 months, 3 weeks ago (2016-12-28 15:12:58 UTC) #12
xcodinas
Fix comments
8 months, 3 weeks ago (2016-12-29 11:46:36 UTC) #13
reviewbot
flake8 OK URL: https://codereview.tryton.org/27861002
8 months, 3 weeks ago (2016-12-29 12:00:56 UTC) #14
ced
https://tryton-rietveld.appspot.com/27861002/diff/60001/tryton/gui/window/form.py File tryton/gui/window/form.py (right): https://tryton-rietveld.appspot.com/27861002/diff/60001/tryton/gui/window/form.py#newcode136 tryton/gui/window/form.py:136: self.set_menu_sensitive() Why not merge both methods? https://tryton-rietveld.appspot.com/27861002/diff/60001/tryton/gui/window/form.py#newcode337 tryton/gui/window/form.py:337: def ...
8 months, 2 weeks ago (2017-01-04 10:39:13 UTC) #15
xcodinas
Use same function as buttons
8 months, 2 weeks ago (2017-01-04 11:01:43 UTC) #16
reviewbot
flake8 OK URL: https://codereview.tryton.org/27861002
8 months, 2 weeks ago (2017-01-04 11:14:45 UTC) #17
ced
Same as sao
8 months, 2 weeks ago (2017-01-05 00:28:21 UTC) #18
xcodinas
Use different dictionary
8 months, 2 weeks ago (2017-01-05 11:43:11 UTC) #19
reviewbot
flake8 OK URL: https://codereview.tryton.org/27861002
8 months, 2 weeks ago (2017-01-05 12:18:59 UTC) #20
ced
https://tryton-rietveld.appspot.com/27861002/diff/100001/tryton/gui/window/form.py File tryton/gui/window/form.py (right): https://tryton-rietveld.appspot.com/27861002/diff/100001/tryton/gui/window/form.py#newcode334 tryton/gui/window/form.py:334: self.menu_buttons['sig_import'].props.sensitive = access['create'] What about sig_new, sig_save? https://tryton-rietveld.appspot.com/27861002/diff/100001/tryton/gui/window/tabcontent.py File ...
8 months, 2 weeks ago (2017-01-06 12:19:42 UTC) #21
xcodinas
Merge toolbar and menu definitions
8 months ago (2017-01-20 09:48:39 UTC) #22
reviewbot
flake8 OK URL: https://codereview.tryton.org/27861002
8 months ago (2017-01-20 10:08:27 UTC) #23
xcodinas
Check tooltip for toolbar buttons instead of note
8 months ago (2017-01-20 11:06:56 UTC) #24
reviewbot
flake8 OK URL: https://codereview.tryton.org/27861002
8 months ago (2017-01-20 11:16:08 UTC) #25
xcodinas
Keep original order
8 months ago (2017-01-20 11:42:21 UTC) #26
reviewbot
flake8 OK URL: https://codereview.tryton.org/27861002
8 months ago (2017-01-20 12:15:58 UTC) #27
ced
board must be updated. https://tryton-rietveld.appspot.com/27861002/diff/160001/tryton/gui/window/form.py File tryton/gui/window/form.py (right): https://tryton-rietveld.appspot.com/27861002/diff/160001/tryton/gui/window/form.py#newcode31 tryton/gui/window/form.py:31: menu_def = [ I think ...
8 months ago (2017-01-21 00:41:43 UTC) #28
xcodinas
Update board, use namedtuple
7 months, 4 weeks ago (2017-01-24 09:48:59 UTC) #29
pokoli
https://tryton-rietveld.appspot.com/27861002/diff/170001/tryton/gui/window/tabcontent.py File tryton/gui/window/tabcontent.py (right): https://tryton-rietveld.appspot.com/27861002/diff/170001/tryton/gui/window/tabcontent.py#newcode103 tryton/gui/window/tabcontent.py:103: for b in self.toolbar_def: can we find a better ...
7 months, 4 weeks ago (2017-01-24 10:02:48 UTC) #30
reviewbot
flake8 OK URL: https://codereview.tryton.org/27861002
7 months, 4 weeks ago (2017-01-24 10:08:26 UTC) #31
xcodinas
fix comments
7 months, 4 weeks ago (2017-01-24 10:14:08 UTC) #32
reviewbot
flake8 OK URL: https://codereview.tryton.org/27861002
7 months, 4 weeks ago (2017-01-24 10:46:41 UTC) #33
ced
https://tryton-rietveld.appspot.com/27861002/diff/190001/tryton/gui/window/board.py File tryton/gui/window/board.py (right): https://tryton-rietveld.appspot.com/27861002/diff/190001/tryton/gui/window/board.py#newcode19 tryton/gui/window/board.py:19: toolbar_item = namedtuple('toolbar_item', 'button_id label tooltip ' + class ...
7 months, 3 weeks ago (2017-01-30 23:12:42 UTC) #34
xcodinas
https://tryton-rietveld.appspot.com/27861002/diff/190001/tryton/gui/window/form.py File tryton/gui/window/form.py (right): https://tryton-rietveld.appspot.com/27861002/diff/190001/tryton/gui/window/form.py#newcode47 tryton/gui/window/form.py:47: toolbar_item(*(None,) * 5), On 2017/01/30 23:12:41, ced wrote: > ...
7 months, 3 weeks ago (2017-01-31 11:46:27 UTC) #35
ced
https://tryton-rietveld.appspot.com/27861002/diff/190001/tryton/gui/window/form.py File tryton/gui/window/form.py (right): https://tryton-rietveld.appspot.com/27861002/diff/190001/tryton/gui/window/form.py#newcode47 tryton/gui/window/form.py:47: toolbar_item(*(None,) * 5), On 2017/01/31 11:46:27, xcodinas wrote: > ...
7 months, 3 weeks ago (2017-01-31 12:17:18 UTC) #36
xcodinas
Add attribute to know if menu or toobar
7 months, 2 weeks ago (2017-02-01 11:24:07 UTC) #37
reviewbot
flake8 OK URL: https://codereview.tryton.org/27861002
7 months, 2 weeks ago (2017-02-01 11:45:40 UTC) #38
ced
https://tryton-rietveld.appspot.com/27861002/diff/210001/tryton/gui/window/form.py File tryton/gui/window/form.py (right): https://tryton-rietveld.appspot.com/27861002/diff/210001/tryton/gui/window/form.py#newcode32 tryton/gui/window/form.py:32: ToolbarItem = Board.ToolbarItem It does not seem logical to ...
7 months, 1 week ago (2017-02-07 23:04:57 UTC) #39
xcodinas
Define ToolbarItem in tabcontent, make spacers a toolbaritem
7 months, 1 week ago (2017-02-08 10:42:24 UTC) #40
reviewbot
flake8 OK URL: https://codereview.tryton.org/27861002
7 months, 1 week ago (2017-02-08 10:45:49 UTC) #41
ced
On 2017/02/08 10:42:24, xcodinas wrote: > make spacers a toolbaritem Why changing back again to ...
7 months, 1 week ago (2017-02-08 11:18:09 UTC) #42
xcodinas
On 2017/02/08 11:18:09, ced wrote: > On 2017/02/08 10:42:24, xcodinas wrote: > > make spacers ...
7 months, 1 week ago (2017-02-08 11:48:29 UTC) #43
ced
On 2017/02/08 11:48:29, xcodinas wrote: > On 2017/02/08 11:18:09, ced wrote: > > On 2017/02/08 ...
7 months, 1 week ago (2017-02-08 12:16:24 UTC) #44
xcodinas
On 2017/02/08 12:16:24, ced wrote: > On 2017/02/08 11:48:29, xcodinas wrote: > > On 2017/02/08 ...
7 months, 1 week ago (2017-02-09 10:28:15 UTC) #45
ced
On 2017/02/09 10:28:15, xcodinas wrote: > On 2017/02/08 12:16:24, ced wrote: > > On 2017/02/08 ...
7 months, 1 week ago (2017-02-09 10:49:53 UTC) #46
xcodinas
On 2017/02/09 10:49:53, ced wrote: > On 2017/02/09 10:28:15, xcodinas wrote: > > On 2017/02/08 ...
7 months, 1 week ago (2017-02-09 12:21:04 UTC) #47
ced
On 2017/02/09 12:21:04, xcodinas wrote: > On 2017/02/09 10:49:53, ced wrote: > > On 2017/02/09 ...
7 months, 1 week ago (2017-02-09 12:39:40 UTC) #48
xcodinas
Prevent two separators
6 months, 3 weeks ago (2017-03-01 08:52:22 UTC) #49
reviewbot
patch is not applicable URL: https://codereview.tryton.org/27861002
6 months, 3 weeks ago (2017-03-01 09:09:56 UTC) #50
ced
https://tryton-rietveld.appspot.com/27861002/diff/250001/tryton/gui/window/board.py File tryton/gui/window/board.py (right): https://tryton-rietveld.appspot.com/27861002/diff/250001/tryton/gui/window/board.py#newcode18 tryton/gui/window/board.py:18: ToolbarItem = TabContent.ToolbarItem Why this? https://tryton-rietveld.appspot.com/27861002/diff/250001/tryton/gui/window/board.py#newcode19 tryton/gui/window/board.py:19: toolbar_def = ...
6 months, 2 weeks ago (2017-03-06 21:08:12 UTC) #51
xcodinas
Update to tip and fix comments
6 months, 2 weeks ago (2017-03-07 10:29:15 UTC) #52
reviewbot
flake8 OK URL: https://codereview.tryton.org/27861002
6 months, 2 weeks ago (2017-03-07 10:36:31 UTC) #53
pokoli
https://tryton-rietveld.appspot.com/27861002/diff/270001/tryton/gui/window/form.py File tryton/gui/window/form.py (right): https://tryton-rietveld.appspot.com/27861002/diff/270001/tryton/gui/window/form.py#newcode342 tryton/gui/window/form.py:342: self.menu_buttons['save'].props.sensitive = access['create'] save is already defined , no ...
6 months, 1 week ago (2017-03-10 13:45:54 UTC) #54
xcodinas
Fix pokoli remarks
6 months, 1 week ago (2017-03-14 10:25:09 UTC) #55
reviewbot
flake8 OK URL: https://codereview.tryton.org/27861002
6 months, 1 week ago (2017-03-14 10:34:50 UTC) #56
pokoli
https://tryton-rietveld.appspot.com/27861002/diff/290001/tryton/gui/window/board.py File tryton/gui/window/board.py (right): https://tryton-rietveld.appspot.com/27861002/diff/290001/tryton/gui/window/board.py#newcode37 tryton/gui/window/board.py:37: 'close', _('_Close Tab'), None, 'tryton-close', When using this button ...
6 months, 1 week ago (2017-03-14 10:43:14 UTC) #57
xcodinas
Fix close tab not working
6 months ago (2017-03-22 10:38:19 UTC) #58
reviewbot
flake8 OK URL: https://codereview.tryton.org/27861002
6 months ago (2017-03-22 11:00:40 UTC) #59
pokoli
https://tryton-rietveld.appspot.com/27861002/diff/310001/tryton/gui/window/board.py File tryton/gui/window/board.py (right): https://tryton-rietveld.appspot.com/27861002/diff/310001/tryton/gui/window/board.py#newcode37 tryton/gui/window/board.py:37: 'win_close', _('_Close Tab'), None, 'tryton-close', I will prefer to ...
6 months ago (2017-03-22 12:22:41 UTC) #60
xcodinas
Do not retrieve current_record if not needed, fix if
5 months, 3 weeks ago (2017-03-28 07:57:43 UTC) #61
ced
https://tryton-rietveld.appspot.com/27861002/diff/310001/tryton/gui/window/board.py File tryton/gui/window/board.py (right): https://tryton-rietveld.appspot.com/27861002/diff/310001/tryton/gui/window/board.py#newcode37 tryton/gui/window/board.py:37: 'win_close', _('_Close Tab'), None, 'tryton-close', On 2017/03/22 12:22:41, pokoli ...
5 months, 3 weeks ago (2017-03-30 13:18:31 UTC) #62
xcodinas
Make a loop for checking sensitive
2 months ago (2017-07-17 10:59:49 UTC) #63
reviewbot
flake8 OK URL: https://codereview.tryton.org/27861002
2 months ago (2017-07-17 11:06:32 UTC) #64
ced
Use object for toolbar item, use properties, set correct state
1 month, 3 weeks ago (2017-07-27 17:15:46 UTC) #65
reviewbot
flake8 OK URL: https://codereview.tryton.org/27861002
1 month, 3 weeks ago (2017-07-27 17:38:48 UTC) #66
rietveld-bot_tryton.org
2 weeks, 6 days ago (2017-08-30 16:17:58 UTC) #67
New changeset 5e60da31118a by Cédric Krier in branch 'default':
Unify toolbar and menu definition
http://hg.tryton.org/tryton/rev/5e60da31118a
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842