Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(134)

Issue 27121002: stock_supply: Add support for overflowing quantities (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months ago by nicoe
Modified:
6 months, 2 weeks ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 : reupload #

Total comments: 43

Patch Set 2 : Fix remarks #

Total comments: 18

Patch Set 3 : Fix remarks #

Total comments: 9

Patch Set 4 : Fix error messages #

Total comments: 3

Patch Set 5 : Fix check_concurrent_op #

Unified diffs Side-by-side diffs Delta from patch set Stats (+314 lines, -57 lines) Patch
M CHANGELOG View 1 chunk +1 line, -0 lines 0 comments Download
M doc/index.rst View 1 2 2 chunks +22 lines, -10 lines 0 comments Download
M location.py View 1 1 chunk +11 lines, -0 lines 0 comments Download
M order_point.py View 1 2 3 4 4 chunks +84 lines, -27 lines 0 comments Download
M purchase_request.py View 1 chunk +2 lines, -2 lines 0 comments Download
M shipment.py View 1 2 3 2 chunks +29 lines, -12 lines 0 comments Download
M tests/scenario_stock_internal_supply.rst View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/scenario_stock_internal_supply_lead_time.rst View 1 chunk +1 line, -1 line 0 comments Download
A tests/scenario_stock_internal_supply_overflow.rst View 1 2 1 chunk +148 lines, -0 lines 0 comments Download
M tests/test_stock_supply.py View 1 1 chunk +5 lines, -0 lines 0 comments Download
M view/location_form.xml View 1 1 chunk +2 lines, -0 lines 0 comments Download
M view/order_point_form.xml View 1 2 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 26
nicoe
reupload
7 months ago (2017-02-16 19:21:15 UTC) #1
reviewbot
https://codereview.tryton.org/27121002/diff/20001/order_point.py#newcode52 order_point.py:52: E711 comparison to None should be 'if cond is not None:' https://codereview.tryton.org/27121002/diff/20001/order_point.py#newcode61 order_point.py:61: ...
7 months ago (2017-02-16 19:36:16 UTC) #2
ced
https://tryton-rietveld.appspot.com/27121002/diff/20001/doc/index.rst File doc/index.rst (right): https://tryton-rietveld.appspot.com/27121002/diff/20001/doc/index.rst#newcode15 doc/index.rst:15: order point also define a type which can be: ...
7 months ago (2017-02-17 00:26:20 UTC) #3
nicoe
Fix remarks
7 months ago (2017-02-17 16:50:33 UTC) #4
reviewbot
https://codereview.tryton.org/27121002/diff/40001/order_point.py#newcode54 order_point.py:54: E711 comparison to None should be 'if cond is not None:' https://codereview.tryton.org/27121002/diff/40001/order_point.py#newcode63 order_point.py:63: ...
7 months ago (2017-02-17 17:06:22 UTC) #5
nicoe
https://tryton-rietveld.appspot.com/27121002/diff/20001/doc/index.rst File doc/index.rst (right): https://tryton-rietveld.appspot.com/27121002/diff/20001/doc/index.rst#newcode15 doc/index.rst:15: order point also define a type which can be: ...
7 months ago (2017-02-17 17:10:07 UTC) #6
ced
https://tryton-rietveld.appspot.com/27121002/diff/40001/doc/index.rst File doc/index.rst (right): https://tryton-rietveld.appspot.com/27121002/diff/40001/doc/index.rst#newcode21 doc/index.rst:21: to remove https://tryton-rietveld.appspot.com/27121002/diff/40001/order_point.py File order_point.py (right): https://tryton-rietveld.appspot.com/27121002/diff/40001/order_point.py#newcode135 order_point.py:135: order_point_table ...
7 months ago (2017-02-20 09:05:29 UTC) #7
nicoe
https://tryton-rietveld.appspot.com/27121002/diff/40001/doc/index.rst File doc/index.rst (right): https://tryton-rietveld.appspot.com/27121002/diff/40001/doc/index.rst#newcode21 doc/index.rst:21: On 2017/02/20 09:05:28, ced wrote: > to remove Done. ...
7 months ago (2017-02-20 16:00:09 UTC) #8
nicoe
Fix remarks
7 months ago (2017-02-20 16:00:15 UTC) #9
reviewbot
https://codereview.tryton.org/27121002/diff/60001/order_point.py#newcode54 order_point.py:54: E711 comparison to None should be 'if cond is not None:' https://codereview.tryton.org/27121002/diff/60001/order_point.py#newcode63 order_point.py:63: ...
7 months ago (2017-02-20 16:06:04 UTC) #10
ced
https://tryton-rietveld.appspot.com/27121002/diff/40001/shipment.py File shipment.py (right): https://tryton-rietveld.appspot.com/27121002/diff/40001/shipment.py#newcode118 shipment.py:118: or location.overflowing_location): On 2017/02/20 16:00:08, nicoe wrote: > On ...
7 months ago (2017-02-20 16:23:54 UTC) #11
ced
https://tryton-rietveld.appspot.com/27121002/diff/60001/order_point.py File order_point.py (right): https://tryton-rietveld.appspot.com/27121002/diff/60001/order_point.py#newcode64 order_point.py:64: }, not standard indent https://tryton-rietveld.appspot.com/27121002/diff/60001/order_point.py#newcode184 order_point.py:184: 'provisioning_location', 'overflowing_location'): iterate ...
7 months ago (2017-02-20 22:39:40 UTC) #12
nicoe
https://tryton-rietveld.appspot.com/27121002/diff/60001/order_point.py File order_point.py (right): https://tryton-rietveld.appspot.com/27121002/diff/60001/order_point.py#newcode64 order_point.py:64: }, On 2017/02/20 22:39:40, ced wrote: > not standard ...
7 months ago (2017-02-21 09:10:22 UTC) #13
ced
https://tryton-rietveld.appspot.com/27121002/diff/60001/order_point.py File order_point.py (right): https://tryton-rietveld.appspot.com/27121002/diff/60001/order_point.py#newcode184 order_point.py:184: 'provisioning_location', 'overflowing_location'): On 2017/02/21 09:10:22, nicoe wrote: > On ...
7 months ago (2017-02-21 09:21:48 UTC) #14
nicoe
https://tryton-rietveld.appspot.com/27121002/diff/60001/order_point.py File order_point.py (right): https://tryton-rietveld.appspot.com/27121002/diff/60001/order_point.py#newcode184 order_point.py:184: 'provisioning_location', 'overflowing_location'): On 2017/02/21 09:21:48, ced wrote: > On ...
7 months ago (2017-02-21 09:34:14 UTC) #15
ced
https://tryton-rietveld.appspot.com/27121002/diff/60001/order_point.py File order_point.py (right): https://tryton-rietveld.appspot.com/27121002/diff/60001/order_point.py#newcode184 order_point.py:184: 'provisioning_location', 'overflowing_location'): On 2017/02/21 09:34:14, nicoe wrote: > On ...
7 months ago (2017-02-21 09:50:41 UTC) #16
nicoe
https://tryton-rietveld.appspot.com/27121002/diff/60001/order_point.py File order_point.py (right): https://tryton-rietveld.appspot.com/27121002/diff/60001/order_point.py#newcode184 order_point.py:184: 'provisioning_location', 'overflowing_location'): On 2017/02/21 09:50:41, ced wrote: > On ...
7 months ago (2017-02-21 10:02:25 UTC) #17
ced
https://tryton-rietveld.appspot.com/27121002/diff/60001/order_point.py File order_point.py (right): https://tryton-rietveld.appspot.com/27121002/diff/60001/order_point.py#newcode195 order_point.py:195: cls.raise_user_error('concurrent_internal_op') Indeed the error message should be different for ...
7 months ago (2017-02-21 11:08:19 UTC) #18
nicoe
Fix error messages
7 months ago (2017-02-21 14:10:52 UTC) #19
reviewbot
https://codereview.tryton.org/27121002/diff/80001/order_point.py#newcode54 order_point.py:54: E711 comparison to None should be 'if cond is not None:' https://codereview.tryton.org/27121002/diff/80001/order_point.py#newcode63 order_point.py:63: ...
7 months ago (2017-02-21 14:35:22 UTC) #20
ced
https://tryton-rietveld.appspot.com/27121002/diff/80001/order_point.py File order_point.py (right): https://tryton-rietveld.appspot.com/27121002/diff/80001/order_point.py#newcode54 order_point.py:54: & (Eval('min_quantity', None) != None)), Pyson does not make ...
6 months, 3 weeks ago (2017-02-27 22:54:20 UTC) #21
nicoe
Fix check_concurrent_op
6 months, 3 weeks ago (2017-02-28 17:26:30 UTC) #22
reviewbot
https://codereview.tryton.org/27121002/diff/100001/order_point.py#newcode54 order_point.py:54: E711 comparison to None should be 'if cond is not None:' https://codereview.tryton.org/27121002/diff/100001/order_point.py#newcode63 order_point.py:63: ...
6 months, 3 weeks ago (2017-02-28 17:31:45 UTC) #23
nicoe
https://tryton-rietveld.appspot.com/27121002/diff/80001/order_point.py File order_point.py (right): https://tryton-rietveld.appspot.com/27121002/diff/80001/order_point.py#newcode54 order_point.py:54: & (Eval('min_quantity', None) != None)), On 2017/02/27 22:54:20, ced ...
6 months, 3 weeks ago (2017-02-28 17:49:03 UTC) #24
ced
LGTM https://tryton-rietveld.appspot.com/27121002/diff/80001/order_point.py File order_point.py (right): https://tryton-rietveld.appspot.com/27121002/diff/80001/order_point.py#newcode54 order_point.py:54: & (Eval('min_quantity', None) != None)), On 2017/02/28 17:49:03, ...
6 months, 3 weeks ago (2017-02-28 21:03:32 UTC) #25
rietveld-bot_tryton.org
6 months, 3 weeks ago (2017-03-01 09:16:12 UTC) #26
New changeset 627e6be708cc by Nicolas ?vrard in branch 'default':
Add support for overflowing quantities
http://hg.tryton.org/modules/stock_supply/rev/627e6be708cc
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842