Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(641)

Issue 26401002: trytond: Ensure _check_access is removed when instantiate translation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 8 months ago by ced
Modified:
1 year, 8 months ago
Reviewers:
pokoli, rietveld-bot, reviewbot
Visibility:
Public.

Description

Since changeset 3a17f8e704a7, there is no more context leak so the context when saving is exactly the one at the instantiation. So _check_access must be removed when the translations are instantiated.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -15 lines) Patch
M trytond/ir/translation.py View 2 chunks +14 lines, -15 lines 0 comments Download

Messages

Total messages: 4
ced
1 year, 8 months ago (2016-06-14 15:57:56 UTC) #1
reviewbot
https://codereview.tryton.org/26401002/diff/1/trytond/ir/translation.py#newcode221 trytond/ir/translation.py:221: E127 continuation line over-indented for visual indent https://codereview.tryton.org/26401002/diff/1/trytond/ir/translation.py#newcode240 trytond/ir/translation.py:240: E127 continuation line over-indented ...
1 year, 8 months ago (2016-06-14 16:02:44 UTC) #2
pokoli
LGTM
1 year, 8 months ago (2016-06-14 16:05:02 UTC) #3
rietveld-bot_tryton.org
1 year, 8 months ago (2016-06-14 16:19:37 UTC) #4
New changeset 6c70dac10495 by C?dric Krier in branch 'default':
Ensure _check_access is removed when instantiate translation
http://hg.tryton.org/trytond/rev/6c70dac10495
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld bc8b922