Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(334)

Issue 26171002: trytond: Add test for selection fields methods (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 1 week ago by pokoli
Modified:
5 months ago
Reviewers:
rietveld-bot, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Test return is a list of couple #

Total comments: 2

Patch Set 3 : Fix ced's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M trytond/tests/test_tryton.py View 1 2 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 10
pokoli
5 months, 1 week ago (2017-02-16 13:04:46 UTC) #1
reviewbot
flake8 OK URL: https://codereview.tryton.org/26171002
5 months, 1 week ago (2017-02-16 13:41:00 UTC) #2
ced
https://tryton-rietveld.appspot.com/26171002/diff/1/trytond/tests/test_tryton.py File trytond/tests/test_tryton.py (right): https://tryton-rietveld.appspot.com/26171002/diff/1/trytond/tests/test_tryton.py#newcode422 trytond/tests/test_tryton.py:422: sel_func() could test the return to be a list ...
5 months, 1 week ago (2017-02-16 16:55:33 UTC) #3
pokoli
Test return is a list of couple
5 months, 1 week ago (2017-02-17 08:44:05 UTC) #4
reviewbot
https://codereview.tryton.org/26171002/diff/20001/trytond/tests/test_tryton.py#newcode437 trytond/tests/test_tryton.py:437: E303 too many blank lines (3) URL: https://codereview.tryton.org/26171002
5 months, 1 week ago (2017-02-17 09:03:07 UTC) #5
ced
https://tryton-rietveld.appspot.com/26171002/diff/20001/trytond/tests/test_tryton.py File trytond/tests/test_tryton.py (right): https://tryton-rietveld.appspot.com/26171002/diff/20001/trytond/tests/test_tryton.py#newcode411 trytond/tests/test_tryton.py:411: 'Test selection methods' no more only methods https://tryton-rietveld.appspot.com/26171002/diff/20001/trytond/tests/test_tryton.py#newcode427 trytond/tests/test_tryton.py:427: ...
5 months ago (2017-02-20 22:58:25 UTC) #6
pokoli
Fix ced's comments
5 months ago (2017-02-21 08:49:36 UTC) #7
reviewbot
flake8 OK URL: https://codereview.tryton.org/26171002
5 months ago (2017-02-21 08:58:01 UTC) #8
ced
LGTM
5 months ago (2017-02-22 23:28:59 UTC) #9
rietveld-bot_tryton.org
5 months ago (2017-02-23 08:27:56 UTC) #10
New changeset 488104918c39 by Sergi Almacellas Abellana in branch 'default':
Add test for selection fields methods
http://hg.tryton.org/trytond/rev/488104918c39
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842