Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(328)

Issue 15231002: trytond: Apply inheritance on models loaded in the pool

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 2 months ago by pokoli
Modified:
1 month, 2 weeks ago
Reviewers:
jean.cavallo, ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 7

Patch Set 2 : Fix ced's comments #

Total comments: 3

Patch Set 3 : Take in account activated modules #

Patch Set 4 : Use simpler design #

Patch Set 5 : Add CHANGELOG, doc and remove apply_base function #

Total comments: 7

Patch Set 6 : Remove expection and rename function to setup_bases #

Patch Set 7 : Define inherited classes on register #

Total comments: 5

Patch Set 8 : Use separate function to register metas #

Total comments: 5

Patch Set 9 : Update to tip #

Patch Set 10 : Update to tip and add test scenario #

Patch Set 11 : Remove unused import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -0 lines) Patch
M CHANGELOG View 1 2 3 4 5 6 7 8 9 1 chunk +2 lines, -0 lines 0 comments Download
M doc/ref/pool.rst View 1 2 3 4 5 6 7 2 chunks +9 lines, -0 lines 0 comments Download
M trytond/modules/__init__.py View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M trytond/pool.py View 1 2 3 4 5 6 7 4 chunks +39 lines, -0 lines 0 comments Download
M trytond/tests/__init__.py View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -0 lines 0 comments Download
A trytond/tests/meta.py View 1 2 3 4 5 6 7 8 9 1 chunk +18 lines, -0 lines 0 comments Download
A trytond/tests/test_meta.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 44
pokoli
2 years, 2 months ago (2015-05-01 11:54:47 UTC) #1
reviewbot
flake8 OK
2 years, 2 months ago (2015-05-01 12:01:04 UTC) #2
ced
http://codereview.tryton.org/15231002/diff/1/trytond/pool.py File trytond/pool.py (right): http://codereview.tryton.org/15231002/diff/1/trytond/pool.py#newcode83 trytond/pool.py:83: assert type_ in ('model', 'report', 'wizard', 'base') Maybe meta ...
2 years, 2 months ago (2015-05-06 14:12:43 UTC) #3
pokoli
2 years, 2 months ago (2015-05-20 08:20:31 UTC) #4
pokoli
Still WiP, and it needs some more testing. http://codereview.tryton.org/15231002/diff/1/trytond/pool.py File trytond/pool.py (right): http://codereview.tryton.org/15231002/diff/1/trytond/pool.py#newcode83 trytond/pool.py:83: assert ...
2 years, 2 months ago (2015-05-20 08:20:56 UTC) #5
reviewbot
flake8 OK
2 years, 2 months ago (2015-05-20 08:31:04 UTC) #6
ced
http://codereview.tryton.org/15231002/diff/20001/trytond/pool.py File trytond/pool.py (right): http://codereview.tryton.org/15231002/diff/20001/trytond/pool.py#newcode210 trytond/pool.py:210: bases = tuple(self.bases.values()) Why tuple? http://codereview.tryton.org/15231002/diff/20001/trytond/pool.py#newcode210 trytond/pool.py:210: bases = ...
2 years, 2 months ago (2015-05-20 15:24:25 UTC) #7
pokoli
Take in account activated modules
7 months, 1 week ago (2016-12-20 10:57:47 UTC) #8
reviewbot
flake8 OK URL: https://codereview.tryton.org/15231002
7 months, 1 week ago (2016-12-20 11:03:38 UTC) #9
ced
I can not understand what is happening and how it works. I think this is ...
7 months, 1 week ago (2016-12-20 23:40:36 UTC) #10
pokoli
On 2016/12/20 23:40:36, ced wrote: > I can not understand what is happening and how ...
7 months ago (2016-12-21 08:25:53 UTC) #11
pokoli
Use simpler design
5 months, 4 weeks ago (2017-01-27 12:43:32 UTC) #12
pokoli
Add CHANGELOG, doc and remove apply_base function
5 months, 4 weeks ago (2017-01-27 12:49:44 UTC) #13
reviewbot
https://codereview.tryton.org/15231002/diff/80001/trytond/modules/__init__.py#newcode295 trytond/modules/__init__.py:295: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/15231002
5 months, 4 weeks ago (2017-01-27 13:17:37 UTC) #14
ced
https://tryton-rietveld.appspot.com/15231002/diff/80001/trytond/modules/__init__.py File trytond/modules/__init__.py (right): https://tryton-rietveld.appspot.com/15231002/diff/80001/trytond/modules/__init__.py#newcode243 trytond/modules/__init__.py:243: if type == 'meta': I think meta should still ...
5 months, 2 weeks ago (2017-02-10 22:29:15 UTC) #15
pokoli
Remove expection and rename function to setup_bases
5 months, 1 week ago (2017-02-13 16:36:50 UTC) #16
pokoli
https://tryton-rietveld.appspot.com/15231002/diff/80001/trytond/pool.py File trytond/pool.py (right): https://tryton-rietveld.appspot.com/15231002/diff/80001/trytond/pool.py#newcode198 trytond/pool.py:198: # Apply only if they have a common ancestor ...
5 months, 1 week ago (2017-02-13 16:37:02 UTC) #17
reviewbot
https://codereview.tryton.org/15231002/diff/100001/trytond/modules/__init__.py#newcode292 trytond/modules/__init__.py:292: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/15231002
5 months, 1 week ago (2017-02-13 17:04:09 UTC) #18
ced
https://tryton-rietveld.appspot.com/15231002/diff/80001/trytond/pool.py File trytond/pool.py (right): https://tryton-rietveld.appspot.com/15231002/diff/80001/trytond/pool.py#newcode198 trytond/pool.py:198: # Apply only if they have a common ancestor ...
5 months, 1 week ago (2017-02-16 10:05:06 UTC) #19
pokoli
Define inherited classes on register
5 months, 1 week ago (2017-02-17 13:31:58 UTC) #20
reviewbot
https://codereview.tryton.org/15231002/diff/120001/trytond/modules/__init__.py#newcode292 trytond/modules/__init__.py:292: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/15231002
5 months, 1 week ago (2017-02-17 14:10:21 UTC) #21
ced
https://tryton-rietveld.appspot.com/15231002/diff/120001/trytond/pool.py File trytond/pool.py (right): https://tryton-rietveld.appspot.com/15231002/diff/120001/trytond/pool.py#newcode50 trytond/pool.py:50: metas = { I think it does not take ...
4 months, 3 weeks ago (2017-03-01 19:21:08 UTC) #22
pokoli
Use separate function to register metas
4 months, 3 weeks ago (2017-03-02 09:36:10 UTC) #23
reviewbot
https://codereview.tryton.org/15231002/diff/140001/trytond/modules/__init__.py#newcode292 trytond/modules/__init__.py:292: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/15231002
4 months, 3 weeks ago (2017-03-02 10:07:02 UTC) #24
jean.cavallo
https://tryton-rietveld.appspot.com/15231002/diff/140001/trytond/pool.py File trytond/pool.py (right): https://tryton-rietveld.appspot.com/15231002/diff/140001/trytond/pool.py#newcode101 trytond/pool.py:101: assert issubclass(cls.__class__, PoolMeta), cls Why should the cls inherit ...
4 months, 3 weeks ago (2017-03-06 08:34:43 UTC) #25
pokoli
https://tryton-rietveld.appspot.com/15231002/diff/140001/trytond/pool.py File trytond/pool.py (right): https://tryton-rietveld.appspot.com/15231002/diff/140001/trytond/pool.py#newcode213 trytond/pool.py:213: self._pool[database][type_][cls.__name__] = cls On 2017/03/06 08:34:43, jean.cavallo wrote: > ...
4 months, 3 weeks ago (2017-03-06 09:10:53 UTC) #26
jean.cavallo
https://tryton-rietveld.appspot.com/15231002/diff/140001/trytond/pool.py File trytond/pool.py (right): https://tryton-rietveld.appspot.com/15231002/diff/140001/trytond/pool.py#newcode213 trytond/pool.py:213: self._pool[database][type_][cls.__name__] = cls On 2017/03/06 09:10:52, pokoli wrote: > ...
4 months, 3 weeks ago (2017-03-06 09:18:07 UTC) #27
pokoli
https://tryton-rietveld.appspot.com/15231002/diff/140001/trytond/pool.py File trytond/pool.py (right): https://tryton-rietveld.appspot.com/15231002/diff/140001/trytond/pool.py#newcode213 trytond/pool.py:213: self._pool[database][type_][cls.__name__] = cls On 2017/03/06 09:18:07, jean.cavallo wrote: > ...
4 months, 3 weeks ago (2017-03-06 09:30:45 UTC) #28
jean.cavallo
On 2017/03/06 09:30:45, pokoli wrote: > https://tryton-rietveld.appspot.com/15231002/diff/140001/trytond/pool.py > File trytond/pool.py (right): > > https://tryton-rietveld.appspot.com/15231002/diff/140001/trytond/pool.py#newcode213 > ...
4 months, 3 weeks ago (2017-03-06 09:41:26 UTC) #29
pokoli
On 2017/03/06 09:41:26, jean.cavallo wrote: > On 2017/03/06 09:30:45, pokoli wrote: > > https://tryton-rietveld.appspot.com/15231002/diff/140001/trytond/pool.py > ...
4 months, 3 weeks ago (2017-03-06 09:59:22 UTC) #30
jean.cavallo
On 2017/03/06 09:59:22, pokoli wrote: > Indeed it will be: > > class Generated(Mixin, MyClass, ...
4 months, 3 weeks ago (2017-03-06 10:15:31 UTC) #31
jean.cavallo
(BTW I am not sure to fully understand how the MRO works, so I may ...
4 months, 3 weeks ago (2017-03-06 10:19:24 UTC) #32
ced
On 2017/03/06 10:15:31, jean.cavallo wrote: > On 2017/03/06 09:59:22, pokoli wrote: > > Indeed it ...
4 months, 3 weeks ago (2017-03-06 10:39:58 UTC) #33
pokoli
On 2017/03/06 10:15:31, jean.cavallo wrote: > On 2017/03/06 09:59:22, pokoli wrote: > > Indeed it ...
4 months, 3 weeks ago (2017-03-06 10:42:15 UTC) #34
jean.cavallo
2017-03-06 11:39 GMT+01:00 Cédric Krier <cedric.krier@b2ck.com>: > If it is the case that means your ...
4 months, 3 weeks ago (2017-03-06 10:52:27 UTC) #35
pokoli
Hi Jean, Sorry for the delay. El 06/03/17 a les 11:52, Jean Cavallo ha escrit: ...
4 months, 2 weeks ago (2017-03-08 08:59:10 UTC) #36
jean.cavallo
On 2017/03/08 08:59:10, pokoli wrote: > Hi Jean, > > Sorry for the delay. Hi ...
4 months, 2 weeks ago (2017-03-08 09:43:26 UTC) #37
ced
It is difficult to follow design discussion on codereview (because it is not the purpose ...
4 months, 2 weeks ago (2017-03-08 09:57:31 UTC) #38
pokoli
Update to tip
4 months ago (2017-03-22 12:38:45 UTC) #39
reviewbot
https://codereview.tryton.org/15231002/diff/160001/trytond/modules/__init__.py#newcode292 trytond/modules/__init__.py:292: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/15231002
4 months ago (2017-03-22 13:01:55 UTC) #40
pokoli
Update to tip and add test scenario
1 month, 2 weeks ago (2017-06-07 14:55:09 UTC) #41
reviewbot
https://codereview.tryton.org/15231002/diff/180001/trytond/tests/__init__.py#newcode5 trytond/tests/__init__.py:5: F403 'from test import *' used; unable to detect undefined names https://codereview.tryton.org/15231002/diff/180001/trytond/tests/__init__.py#newcode6 trytond/tests/__init__.py:6: ...
1 month, 2 weeks ago (2017-06-07 15:09:27 UTC) #42
pokoli
Remove unused import
1 month, 2 weeks ago (2017-06-07 15:13:42 UTC) #43
reviewbot
1 month, 2 weeks ago (2017-06-07 15:30:00 UTC) #44
https://codereview.tryton.org/15231002/diff/200001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:5:
F403 'from test import *' used; unable to detect undefined names

https://codereview.tryton.org/15231002/diff/200001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:6:
F403 'from model import *' used; unable to detect undefined names

https://codereview.tryton.org/15231002/diff/200001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:7:
F403 'from modelview import *' used; unable to detect undefined names

https://codereview.tryton.org/15231002/diff/200001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:8:
F403 'from mptt import *' used; unable to detect undefined names

https://codereview.tryton.org/15231002/diff/200001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:9:
F403 'from import_data import *' used; unable to detect undefined names

https://codereview.tryton.org/15231002/diff/200001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:10:
F403 'from export_data import *' used; unable to detect undefined names

https://codereview.tryton.org/15231002/diff/200001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:11:
F403 'from trigger import *' used; unable to detect undefined names

https://codereview.tryton.org/15231002/diff/200001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:12:
F403 'from access import *' used; unable to detect undefined names

https://codereview.tryton.org/15231002/diff/200001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:13:
F403 'from wizard import *' used; unable to detect undefined names

https://codereview.tryton.org/15231002/diff/200001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:14:
F403 'from workflow import *' used; unable to detect undefined names

https://codereview.tryton.org/15231002/diff/200001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:15:
F403 'from copy_ import *' used; unable to detect undefined names

https://codereview.tryton.org/15231002/diff/200001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:16:
F403 'from history import *' used; unable to detect undefined names

https://codereview.tryton.org/15231002/diff/200001/trytond/tests/__init__.py#...
trytond/tests/__init__.py:17:
F403 'from field_context import *' used; unable to detect undefined names

https://codereview.tryton.org/15231002/diff/200001/trytond/modules/__init__.p...
trytond/modules/__init__.py:292:
E127 continuation line over-indented for visual indent

URL: https://codereview.tryton.org/15231002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842