Tryton Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(589)

Issue 15231002: trytond: Apply inheritance on models loaded in the pool

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 10 months ago by pokoli
Modified:
1 week, 3 days ago
Reviewers:
ced, reviewbot
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 7

Patch Set 2 : Fix ced's comments #

Total comments: 3

Patch Set 3 : Take in account activated modules #

Patch Set 4 : Use simpler design #

Patch Set 5 : Add CHANGELOG, doc and remove apply_base function #

Total comments: 7

Patch Set 6 : Remove expection and rename function to setup_bases #

Patch Set 7 : Define inherited classes on register #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M CHANGELOG View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M doc/ref/pool.rst View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M trytond/modules/__init__.py View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M trytond/pool.py View 1 2 3 4 5 6 4 chunks +31 lines, -1 line 0 comments Download

Messages

Total messages: 21
pokoli
1 year, 10 months ago (2015-05-01 11:54:47 UTC) #1
reviewbot
flake8 OK
1 year, 10 months ago (2015-05-01 12:01:04 UTC) #2
ced
http://codereview.tryton.org/15231002/diff/1/trytond/pool.py File trytond/pool.py (right): http://codereview.tryton.org/15231002/diff/1/trytond/pool.py#newcode83 trytond/pool.py:83: assert type_ in ('model', 'report', 'wizard', 'base') Maybe meta ...
1 year, 9 months ago (2015-05-06 14:12:43 UTC) #3
pokoli
1 year, 9 months ago (2015-05-20 08:20:31 UTC) #4
pokoli
Still WiP, and it needs some more testing. http://codereview.tryton.org/15231002/diff/1/trytond/pool.py File trytond/pool.py (right): http://codereview.tryton.org/15231002/diff/1/trytond/pool.py#newcode83 trytond/pool.py:83: assert ...
1 year, 9 months ago (2015-05-20 08:20:56 UTC) #5
reviewbot
flake8 OK
1 year, 9 months ago (2015-05-20 08:31:04 UTC) #6
ced
http://codereview.tryton.org/15231002/diff/20001/trytond/pool.py File trytond/pool.py (right): http://codereview.tryton.org/15231002/diff/20001/trytond/pool.py#newcode210 trytond/pool.py:210: bases = tuple(self.bases.values()) Why tuple? http://codereview.tryton.org/15231002/diff/20001/trytond/pool.py#newcode210 trytond/pool.py:210: bases = ...
1 year, 9 months ago (2015-05-20 15:24:25 UTC) #7
pokoli
Take in account activated modules
2 months, 1 week ago (2016-12-20 10:57:47 UTC) #8
reviewbot
flake8 OK URL: https://codereview.tryton.org/15231002
2 months, 1 week ago (2016-12-20 11:03:38 UTC) #9
ced
I can not understand what is happening and how it works. I think this is ...
2 months, 1 week ago (2016-12-20 23:40:36 UTC) #10
pokoli
On 2016/12/20 23:40:36, ced wrote: > I can not understand what is happening and how ...
2 months, 1 week ago (2016-12-21 08:25:53 UTC) #11
pokoli
Use simpler design
1 month ago (2017-01-27 12:43:32 UTC) #12
pokoli
Add CHANGELOG, doc and remove apply_base function
1 month ago (2017-01-27 12:49:44 UTC) #13
reviewbot
https://codereview.tryton.org/15231002/diff/80001/trytond/modules/__init__.py#newcode295 trytond/modules/__init__.py:295: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/15231002
1 month ago (2017-01-27 13:17:37 UTC) #14
ced
https://tryton-rietveld.appspot.com/15231002/diff/80001/trytond/modules/__init__.py File trytond/modules/__init__.py (right): https://tryton-rietveld.appspot.com/15231002/diff/80001/trytond/modules/__init__.py#newcode243 trytond/modules/__init__.py:243: if type == 'meta': I think meta should still ...
2 weeks, 3 days ago (2017-02-10 22:29:15 UTC) #15
pokoli
Remove expection and rename function to setup_bases
2 weeks ago (2017-02-13 16:36:50 UTC) #16
pokoli
https://tryton-rietveld.appspot.com/15231002/diff/80001/trytond/pool.py File trytond/pool.py (right): https://tryton-rietveld.appspot.com/15231002/diff/80001/trytond/pool.py#newcode198 trytond/pool.py:198: # Apply only if they have a common ancestor ...
2 weeks ago (2017-02-13 16:37:02 UTC) #17
reviewbot
https://codereview.tryton.org/15231002/diff/100001/trytond/modules/__init__.py#newcode292 trytond/modules/__init__.py:292: E127 continuation line over-indented for visual indent URL: https://codereview.tryton.org/15231002
2 weeks ago (2017-02-13 17:04:09 UTC) #18
ced
https://tryton-rietveld.appspot.com/15231002/diff/80001/trytond/pool.py File trytond/pool.py (right): https://tryton-rietveld.appspot.com/15231002/diff/80001/trytond/pool.py#newcode198 trytond/pool.py:198: # Apply only if they have a common ancestor ...
1 week, 4 days ago (2017-02-16 10:05:06 UTC) #19
pokoli
Define inherited classes on register
1 week, 3 days ago (2017-02-17 13:31:58 UTC) #20
reviewbot
1 week, 3 days ago (2017-02-17 14:10:21 UTC) #21
https://codereview.tryton.org/15231002/diff/120001/trytond/modules/__init__.p...
trytond/modules/__init__.py:292:
E127 continuation line over-indented for visual indent

URL: https://codereview.tryton.org/15231002
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cd18842